From: "Ser, Simon" <simon.ser@intel.com>
To: "guillaume.tucker@collabora.com" <guillaume.tucker@collabora.com>,
"Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>,
"Latvala, Petri" <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v4 2/4] gitlab-ci: add libatomic to docker images
Date: Tue, 25 Jun 2019 10:48:43 +0000 [thread overview]
Message-ID: <15b6bc1656aa987ef408ba52b33403b0c1997508.camel@intel.com> (raw)
In-Reply-To: <def2edafe1432008d56bc7da892c374f46ef1aac.1561393147.git.guillaume.tucker@collabora.com>
On Mon, 2019-06-24 at 17:22 +0100, Guillaume Tucker wrote:
> Add libatomic to the Fedora docker image so it can link binaries that
> use __atomic_* functions. Also explicitly add libatomic1 to Debian
> docker images as it is needed in particular on non-x86 architectures
> for run-time linkage.
>
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Reviewed-by: Simon Ser <simon.ser@intel.com>
> ---
>
> Notes:
> v2: add libatomic1 in Debian docker images
> v3: add libatomic1 for non-x86 arches in Debian docker images
> v4: rebase to add libatomic1 in Dockerfile.debian-minimal
>
> Dockerfile.debian-arm64 | 1 +
> Dockerfile.debian-armhf | 1 +
> Dockerfile.debian-minimal | 1 +
> Dockerfile.fedora | 2 +-
> 4 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Dockerfile.debian-arm64 b/Dockerfile.debian-arm64
> index 7b3a3c7ca803..c9fb28c804b8 100644
> --- a/Dockerfile.debian-arm64
> +++ b/Dockerfile.debian-arm64
> @@ -14,6 +14,7 @@ RUN dpkg --add-architecture arm64
> RUN apt-get update
> RUN apt-get install -y \
> gcc-aarch64-linux-gnu \
> + libatomic1:arm64 \
> libpciaccess-dev:arm64 \
> libkmod-dev:arm64 \
> libprocps-dev:arm64 \
> diff --git a/Dockerfile.debian-armhf b/Dockerfile.debian-armhf
> index c67a1e2acf6a..3a133d849d68 100644
> --- a/Dockerfile.debian-armhf
> +++ b/Dockerfile.debian-armhf
> @@ -14,6 +14,7 @@ RUN dpkg --add-architecture armhf
> RUN apt-get update
> RUN apt-get install -y \
> gcc-arm-linux-gnueabihf \
> + libatomic1:armhf \
> libpciaccess-dev:armhf \
> libkmod-dev:armhf \
> libprocps-dev:armhf \
> diff --git a/Dockerfile.debian-minimal b/Dockerfile.debian-minimal
> index bbe70bed2fb4..63844694dafa 100644
> --- a/Dockerfile.debian-minimal
> +++ b/Dockerfile.debian-minimal
> @@ -6,6 +6,7 @@ RUN apt-get install -y \
> flex \
> bison \
> pkg-config \
> + libatomic1 \
> libpciaccess-dev \
> libkmod-dev \
> libprocps-dev \
> diff --git a/Dockerfile.fedora b/Dockerfile.fedora
> index 6686e587613d..c84b412b0723 100644
> --- a/Dockerfile.fedora
> +++ b/Dockerfile.fedora
> @@ -1,7 +1,7 @@
> FROM fedora:30
>
> RUN dnf install -y \
> - gcc flex bison meson ninja-build xdotool \
> + gcc flex bison libatomic meson ninja-build xdotool \
> 'pkgconfig(libdrm)' \
> 'pkgconfig(pciaccess)' \
> 'pkgconfig(libkmod)' \
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-25 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 16:22 [igt-dev] [PATCH i-g-t v4 0/4] Use C11 atomics Guillaume Tucker
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 1/4] meson: add libatomic dependency Guillaume Tucker
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 2/4] gitlab-ci: add libatomic to docker images Guillaume Tucker
2019-06-25 10:48 ` Ser, Simon [this message]
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 3/4] i915/gem_create: use atomic_* instead of __sync_* Guillaume Tucker
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 4/4] tests/sw_sync: " Guillaume Tucker
2019-06-24 16:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for Use C11 atomics (rev4) Patchwork
2019-06-25 7:19 ` Ser, Simon
2019-06-25 8:55 ` Guillaume Tucker
2019-06-25 8:06 ` [igt-dev] ✓ Fi.CI.BAT: success for Use C11 atomics (rev5) Patchwork
2019-06-25 9:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-25 10:54 ` [igt-dev] [PATCH i-g-t v4 0/4] Use C11 atomics Ser, Simon
2019-06-25 13:04 ` [Intel-gfx] " Guillaume Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15b6bc1656aa987ef408ba52b33403b0c1997508.camel@intel.com \
--to=simon.ser@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=guillaume.tucker@collabora.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox