public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ser, Simon" <simon.ser@intel.com>
To: "guillaume.tucker@collabora.com" <guillaume.tucker@collabora.com>,
	"Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>,
	"Latvala, Petri" <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v4 0/4] Use C11 atomics
Date: Tue, 25 Jun 2019 10:54:23 +0000	[thread overview]
Message-ID: <7643ddeebd6cba07197b76b9c646436029f0027b.camel@intel.com> (raw)
In-Reply-To: <cover.1561393147.git.guillaume.tucker@collabora.com>

On Mon, 2019-06-24 at 17:22 +0100, Guillaume Tucker wrote:
> This series replaces calls to the __sync_* functions with the more
> recent atomic_* ones defined in stdatomic.h in gem_create and
> sw_sync.  It also adds dependency on libatomic when required, that is
> to say when the CPU architecture doesn't provide native support for
> some atomic operations.  This makes the tests more portable, in
> particular for 32-bit MIPS which doesn't support 64-bit atomics.

Thanks for this series! Pushed:

To gitlab.freedesktop.org:drm/igt-gpu-tools.git
   a6f5cc854efb..5eafa33dbdb1  master -> master

> v2:
>  - add linker test to only add dependency on libatomic when needed
>  - only add libatomic dependency to gem_create and sw_sync
>  - use stdatomic.h and _Atomic type modifier
>  - explicitly require libatomic in all Docker images
> 
> v3:
>  - use sub-arch libatomic1 in Debian docker images
>  - use null_dep in meson.build
> 
> v4:
>  - rebase with changes in Dockerfile.debian-minimal
> 
> Guillaume Tucker (4):
>   meson: add libatomic dependency
>   gitlab-ci: add libatomic to docker images
>   i915/gem_create: use atomic_* instead of __sync_*
>   tests/sw_sync: use atomic_* instead of __sync_*
> 
>  Dockerfile.debian-arm64   |  1 +
>  Dockerfile.debian-armhf   |  1 +
>  Dockerfile.debian-minimal |  1 +
>  Dockerfile.fedora         |  2 +-
>  meson.build               | 14 ++++++++++++++
>  tests/Makefile.am         |  3 ++-
>  tests/i915/gem_create.c   | 16 ++++++++++++----
>  tests/meson.build         | 17 +++++++++++++++--
>  tests/sw_sync.c           | 12 ++++++------
>  9 files changed, 53 insertions(+), 14 deletions(-)
> 
> --
> 2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-06-25 10:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24 16:22 [igt-dev] [PATCH i-g-t v4 0/4] Use C11 atomics Guillaume Tucker
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 1/4] meson: add libatomic dependency Guillaume Tucker
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 2/4] gitlab-ci: add libatomic to docker images Guillaume Tucker
2019-06-25 10:48   ` Ser, Simon
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 3/4] i915/gem_create: use atomic_* instead of __sync_* Guillaume Tucker
2019-06-24 16:22 ` [igt-dev] [PATCH i-g-t v4 4/4] tests/sw_sync: " Guillaume Tucker
2019-06-24 16:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for Use C11 atomics (rev4) Patchwork
2019-06-25  7:19   ` Ser, Simon
2019-06-25  8:55     ` Guillaume Tucker
2019-06-25  8:06 ` [igt-dev] ✓ Fi.CI.BAT: success for Use C11 atomics (rev5) Patchwork
2019-06-25  9:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-25 10:54 ` Ser, Simon [this message]
2019-06-25 13:04   ` [Intel-gfx] [PATCH i-g-t v4 0/4] Use C11 atomics Guillaume Tucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7643ddeebd6cba07197b76b9c646436029f0027b.camel@intel.com \
    --to=simon.ser@intel.com \
    --cc=arkadiusz.hiler@intel.com \
    --cc=guillaume.tucker@collabora.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox