Re: [PATCH i-g-t v3 04/17] tests/kms_async_flips: limit S/R to first and last CRTC

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]


On 21-08-2026 06:18 pm, Michał Grzelak wrote:
> In order to increase tests performance limit suspend-resume's execution
> to only first and last CRTC.
>
> v2->v3
> - add missing S-O-B
>
> Signed-off-by: Michał Grzelak<michal.grzelak@intel.com>
> ---
>   tests/kms_async_flips.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 03348d958d..5c143e71df 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -873,18 +873,23 @@ static void run_test(data_t *data, void (*test)(data_t *))
>   {
>   	igt_crtc_t *crtc;
>   	igt_display_t *display = &data->display;
> +	int idx;
>   
>   	if (data->atomic_path)
>   		require_atomic_async_cap(data);
>   
>   	for_each_connected_output(display, data->output) {
>   		for_each_crtc(&data->display, crtc) {
> -			if(!igt_crtc_connector_valid(crtc, data->output))
> +			if (!igt_crtc_connector_valid(crtc, data->output))
>   				continue;
>   
>   			data->crtc = crtc;
>   			igt_display_reset(display);
>   
> +			idx = display->crtcs->crtc_index;
-->IMO: display->crtcsis pointer to the first element to the crtc array  
and always gives same but not current being iterated , please check this 
once
> +			if (data->suspend_resume && (idx != 0 || idx != display->n_crtcs - 1))
-->You mean to skip if not first and last?
> +				continue;
> +
>   			igt_output_set_crtc(data->output,
>   					    crtc);
>   			if (!intel_pipe_output_combo_valid(display))

[-- Attachment #2: Type: text/html, Size: 2309 bytes --]