Re: [PATCH i-g-t v3 16/17] tests/kms_ccs: limit #crtcs tested during suspend

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

On 21-08-2026 06:18 pm, Michał Grzelak wrote:
> Limit execution of suspend tests to first and last active CRTC unless
> using `extended` flag. This reduces default execution time of the test.
> In turn this can lower chances of hitting CI timeout.
>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>   tests/intel/kms_ccs.c | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_ccs.c b/tests/intel/kms_ccs.c
> index 11bc30769c..3aeb1a57df 100644
> --- a/tests/intel/kms_ccs.c
> +++ b/tests/intel/kms_ccs.c
> @@ -191,6 +191,7 @@ typedef struct {
>   	int fb_list_length;
>   	bool do_hibernate;
>   	bool all_outputs;
> +	bool all_crtcs;
>   	struct {
>   		struct igt_fb fb;
>   		int width, height;
> @@ -1157,6 +1158,9 @@ static void test_output(data_t *data, const int testnum)
>   			}
>   
>   			for_each_connected_output(&data->display, data->output) {
> +				int first = data->display.crtcs[0].crtc_index;
> +				int last = data->display.crtcs[data->display.n_crtcs-1].crtc_index;
-->IMO: they don’t depend on output so checking them inside make same 
values on each iteration...
> +
>   				if (!data->all_outputs && (data->flags & TEST_SUSPEND) &&
>   				    output_count >= OUTPUT_LIMIT)
>   					continue;
> @@ -1175,6 +1179,10 @@ static void test_output(data_t *data, const int testnum)
>   					if (!intel_pipe_output_combo_valid(&data->display))
>   						continue;
>   
> +					if (!data->all_crtcs && (data->flags & TEST_SUSPEND) &&
> +					    crtc->crtc_index != first && crtc->crtc_index != last)
> +						continue;
> +
>   					igt_dynamic_f("pipe-%s-%s",
>   								    igt_crtc_name(crtc),
>   								    data->output->name) {
> @@ -1234,6 +1242,9 @@ static int opt_handler(int opt, int opt_index, void *opt_data)
>   	case 'n':
>   		data->all_outputs = true;
>   		break;
> +	case 'e':
> +		data->all_crtcs = true;
> +		break;
>   	default:
>   		return IGT_OPT_HANDLER_ERROR;
>   	}
> @@ -1248,9 +1259,10 @@ static const char *help_str =
>   "  -s <seed>\tSeed for random number generator\n"
>   "  -r\t\tOn suspend test do full hibernate with reboot\n"
>   "  -n\t\tRun on all connectors. (By default suspend subtests will run on 2 connectors)\n"
> +"  -e\t\tRun on all CRTCs. (By default subtests will run on two CRTCs)\n"
> -->Check this runs on 2 crts or 3 crtcs?
>   ;
>   
> -int igt_main_args("csrn:", NULL, help_str, opt_handler, &data)
> +int igt_main_args("csrne:", NULL, help_str, opt_handler, &data)
>   {
>   	igt_fixture() {
>   		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_XE);