From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Subject: Re: [PATCH i-g-t] lib/igt_kmod: stop using KMOD_REMOVE_FORCE, again
Date: Thu, 5 Dec 2024 06:36:22 -0800 [thread overview]
Message-ID: <173340930937.3402771.11812401822016192248.b4-ty@intel.com> (raw)
In-Reply-To: <20241030234908.858018-1-lucas.demarchi@intel.com>
On Wed, 30 Oct 2024 16:49:08 -0700, Lucas De Marchi wrote:
> Just like done in commit 93ad5b785ea0 ("lib/igt_kmod: stop using
> KMOD_REMOVE_FORCE"). From igt perspective, if a module can't be removed,
> forcing its removal is not the right thing to do: the test should just
> fail and be fixed.
>
> If the kernel actually enforces KMOD_REMOVE_FORCE, then it would just
> taint and all tests get aborted. Lastly, our kernel config doesn't have
> CONFIG_MODULE_FORCE_UNLOAD set, so this is pointless for multiple times.
>
> [...]
Applied, thanks for the review.
[1/1] lib/igt_kmod: stop using KMOD_REMOVE_FORCE, again
commit: b0c59bb94e6c990589eb6825c1436ce412804dae
Best regards,
--
Lucas De Marchi <lucas.demarchi@intel.com>
prev parent reply other threads:[~2024-12-05 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 23:49 [PATCH i-g-t] lib/igt_kmod: stop using KMOD_REMOVE_FORCE, again Lucas De Marchi
2024-10-31 1:57 ` ✓ CI.xeBAT: success for " Patchwork
2024-10-31 2:01 ` ✓ Fi.CI.BAT: " Patchwork
2024-10-31 3:41 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-31 12:30 ` ✗ Fi.CI.IGT: " Patchwork
2024-11-19 13:36 ` [PATCH i-g-t] " Vivekanandan, Balasubramani
2024-12-05 14:36 ` Lucas De Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173340930937.3402771.11812401822016192248.b4-ty@intel.com \
--to=lucas.demarchi@intel.com \
--cc=balasubramani.vivekanandan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox