Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t] lib/igt_kmod: stop using KMOD_REMOVE_FORCE, again
Date: Wed, 30 Oct 2024 16:49:08 -0700	[thread overview]
Message-ID: <20241030234908.858018-1-lucas.demarchi@intel.com> (raw)

Just like done in commit 93ad5b785ea0 ("lib/igt_kmod: stop using
KMOD_REMOVE_FORCE"). From igt perspective, if a module can't be removed,
forcing its removal is not the right thing to do: the test should just
fail and be fixed.

If the kernel actually enforces KMOD_REMOVE_FORCE, then it would just
taint and all tests get aborted. Lastly, our kernel config doesn't have
CONFIG_MODULE_FORCE_UNLOAD set, so this is pointless for multiple times.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_kmod.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 75a0d057c..cc3e5e5b1 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -1409,8 +1409,7 @@ static void __igt_kunit(struct igt_ktest *tst,
 			char glob[1024];
 			int i;
 
-			igt_skip_on(kmod_module_remove_module(tst->kmod,
-							      KMOD_REMOVE_FORCE));
+			igt_skip_on(kmod_module_remove_module(tst->kmod, 0));
 			igt_skip_on(igt_kernel_tainted(&taints));
 
 			igt_assert_lt(snprintf(glob, sizeof(glob), "%s.%s",
-- 
2.47.0


             reply	other threads:[~2024-10-30 23:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 23:49 Lucas De Marchi [this message]
2024-10-31  1:57 ` ✓ CI.xeBAT: success for lib/igt_kmod: stop using KMOD_REMOVE_FORCE, again Patchwork
2024-10-31  2:01 ` ✓ Fi.CI.BAT: " Patchwork
2024-10-31  3:41 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-31 12:30 ` ✗ Fi.CI.IGT: " Patchwork
2024-11-19 13:36 ` [PATCH i-g-t] " Vivekanandan, Balasubramani
2024-12-05 14:36 ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030234908.858018-1-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox