From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_render: Rewrite test to take advantage of igt_display.
Date: Tue, 30 Jan 2018 09:01:14 +0100 [thread overview]
Message-ID: <20180130080114.GN2759@phenom.ffwll.local> (raw)
In-Reply-To: <891fc5fe-db82-16d3-970e-18eff5d32b2a@linux.intel.com>
On Wed, Jan 24, 2018 at 12:22:07PM +0100, Maarten Lankhorst wrote:
> Op 24-01-18 om 12:08 schreef Chris Wilson:
> > Quoting Maarten Lankhorst (2018-01-24 10:25:00)
> >> This test was taking ~100s for each subtest, and both tests were the same,
> >> but required the user to pay attention. I've changed it to automated
> >> checking with CRC, and removed the subtests.
> > What do we do here that isn't covered by kms_frontbuffer*? My guess
> > would be do simple testing of more configurations (as opposed to
> > kms_frontbuffer that does lots of different drawing to the same
> > configuration).
> Hm probably right. I wouldn't mind removing it too, to be honest..
Originally added by Imre and reviewed by Rodrigo, but no mention why we
need this testcase:
commit 528b1f381c4e67c2e63e23b5597070fffe8033d6
Author: Imre Deak <imre.deak@intel.com>
Date: Thu May 30 22:59:59 2013 +0300
tests: add kms_render
Add a test going through all connectors/crtcs/modes/formats painting to
a front FB with CPU or painting to a back FB with CPU and blitting it
to the front FB.
Only formats understood by cairo are supported for now.
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
I'm voting for removal too, assuming Imre doesn't come up with a very good
reason for why we need it.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-01-30 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 10:25 [igt-dev] [PATCH i-g-t] tests/kms_render: Rewrite test to take advantage of igt_display Maarten Lankhorst
2018-01-24 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-01-24 11:08 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-01-24 11:22 ` Maarten Lankhorst
2018-01-30 8:01 ` Daniel Vetter [this message]
2018-01-30 9:54 ` Maarten Lankhorst
2018-01-31 14:25 ` Imre Deak
2018-01-24 11:55 ` Mika Kahola
2018-01-24 13:24 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130080114.GN2759@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox