[igt-dev] [PATCH i-g-t 1/3] overlay: add missing foreground option

[igt-dev] [PATCH i-g-t 1/3] overlay: add missing foreground option

[Lionel Landwerlin]

It seems we handle -f but we forgot to list it.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 overlay/overlay.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/overlay/overlay.c b/overlay/overlay.c
index 4804f813..545af7bc 100644
--- a/overlay/overlay.c
+++ b/overlay/overlay.c
@@ -840,6 +840,7 @@ static void usage(const char *progname)
 	printf("\t--geometry|-G <width>x<height>+<x-offset>+<y-offset>\tExact window placement and size\n");
 	printf("\t--position|-P (top|middle|bottom)-(left|centre|right)\tPlace the window in a particular corner\n");
 	printf("\t--size|-S <width>x<height> | <scale>%%\t\t\tWindow size\n");
+	printf("\t--foreground|-f\t\t\t\t\t\tKeep the application in foreground\n");
 	printf("\t--help|-h\t\t\t\t\t\tThis help message\n");
 }
 
@@ -850,6 +851,7 @@ int main(int argc, char **argv)
 		{"geometry", 1, 0, 'G'},
 		{"position", 1, 0, 'P'},
 		{"size", 1, 0, 'S'},
+		{"foreground", 0, 0, 'f'},
 		{"help", 0, 0, 'h'},
 		{NULL, 0, 0, 0,}
 	};
-- 
2.15.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/3] overlay: reindent tracepoint parser

[Lionel Landwerlin]

I wrote it, but couldn't reread myself... This doesn't contain any
change apart from reindenting.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 overlay/tracepoint_format.leg | 37 ++++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 19 deletions(-)

diff --git a/overlay/tracepoint_format.leg b/overlay/tracepoint_format.leg
index 7a09149d..0db9a55f 100644
--- a/overlay/tracepoint_format.leg
+++ b/overlay/tracepoint_format.leg
@@ -1,28 +1,27 @@
 TracepointFmt =
-    'name' ':' Space n:PropertyName EndLine
-        { free(v.string); }
-    'ID:' Space v:Number EndLine
-        { yy->ctx.tp->event_id = v.integer; }
+    'name' ':' Space n:PropertyName EndLine { free(v.string); }
+    'ID:' Space v:Number EndLine { yy->ctx.tp->event_id = v.integer; }
     'format:' EndLine
     Field+
     'print fmt:' [^.]* !.
 
-Field         = Space (Property ';' Space)+ EndLine
-        { yy->ctx.tp->n_fields++; }
-              | EndLine
+Field = Space (Property ';' Space)+ EndLine
+            { yy->ctx.tp->n_fields++; }
+      | EndLine
 
-Property      = 'offset' ':' v:Number
-        { yy->ctx.tp->fields[yy->ctx.tp->n_fields].offset = v.integer; }
-              | 'size' ':' v:Number
-        { yy->ctx.tp->fields[yy->ctx.tp->n_fields].size = v.integer; }
-              | 'signed' ':' v:Number
-        { yy->ctx.tp->fields[yy->ctx.tp->n_fields].is_signed = v.integer != 0; }
-              | 'field' ':' v:PropertyValue
-        { snprintf(yy->ctx.tp->fields[yy->ctx.tp->n_fields].name,
-                   sizeof(yy->ctx.tp->fields[yy->ctx.tp->n_fields].name),
-                   "%s", strrchr(v.string, ' ') + 1); free(v.string); }
-              | n:PropertyName ':' v:PropertyValue
-        { free(n.string); free(v.string); }
+Property = 'offset' ':' v:Number
+               { yy->ctx.tp->fields[yy->ctx.tp->n_fields].offset = v.integer; }
+         | 'size' ':' v:Number
+               { yy->ctx.tp->fields[yy->ctx.tp->n_fields].size = v.integer; }
+         | 'signed' ':' v:Number
+               { yy->ctx.tp->fields[yy->ctx.tp->n_fields].is_signed = v.integer != 0; }
+         | 'field' ':' v:PropertyValue
+               { snprintf(yy->ctx.tp->fields[yy->ctx.tp->n_fields].name,
+			  sizeof(yy->ctx.tp->fields[yy->ctx.tp->n_fields].name),
+			  "%s", strrchr(v.string, ' ') + 1);
+		 free(v.string); }
+         | n:PropertyName ':' v:PropertyValue
+               { free(n.string); free(v.string); }
 
 PropertyName  = < [A-Za-z0-9_]+ >
         { $$.string = strdup(yytext); }
-- 
2.15.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/3] overlay: fix invalid pointer access

[Lionel Landwerlin]

The 'v' variable isn't defined in this part of the 'TracepointFmt'
rule but because of the way the generator produces code (one function
per rule) it doesn't realize we're accessing a variable from a
different case of the rule and this doesn't lead to a C compiler error
on undefined variable.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 overlay/tracepoint_format.leg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/overlay/tracepoint_format.leg b/overlay/tracepoint_format.leg
index 0db9a55f..5503e1cc 100644
--- a/overlay/tracepoint_format.leg
+++ b/overlay/tracepoint_format.leg
@@ -1,5 +1,5 @@
 TracepointFmt =
-    'name' ':' Space n:PropertyName EndLine { free(v.string); }
+    'name' ':' Space n:PropertyName EndLine { free(n.string); }
     'ID:' Space v:Number EndLine { yy->ctx.tp->event_id = v.integer; }
     'format:' EndLine
     Field+
-- 
2.15.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/3] overlay: add missing foreground option

[Chris Wilson]

Quoting Lionel Landwerlin (2018-02-01 17:32:14)
> It seems we handle -f but we forgot to list it.

There's a usage()! That seems unlike me ;)
 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 3/3] overlay: fix invalid pointer access

[Chris Wilson]

Quoting Lionel Landwerlin (2018-02-01 17:32:16)
> The 'v' variable isn't defined in this part of the 'TracepointFmt'
> rule but because of the way the generator produces code (one function
> per rule) it doesn't realize we're accessing a variable from a
> different case of the rule and this doesn't lead to a C compiler error
> on undefined variable.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>  overlay/tracepoint_format.leg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/overlay/tracepoint_format.leg b/overlay/tracepoint_format.leg
> index 0db9a55f..5503e1cc 100644
> --- a/overlay/tracepoint_format.leg
> +++ b/overlay/tracepoint_format.leg
> @@ -1,5 +1,5 @@
>  TracepointFmt =
> -    'name' ':' Space n:PropertyName EndLine { free(v.string); }
> +    'name' ':' Space n:PropertyName EndLine { free(n.string); }

Oh, and I think I can even parse this snippet!

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/3] overlay: reindent tracepoint parser

[Chris Wilson]

Quoting Lionel Landwerlin (2018-02-01 17:32:15)
> I wrote it, but couldn't reread myself... This doesn't contain any
> change apart from reindenting.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

Skimmed the changes looking for non-mechanical changes, so assuming the
indentation isn't part of the parser (*cough* python *cough*),
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/3] overlay: reindent tracepoint parser

[Lionel Landwerlin]

On 01/02/18 17:47, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-02-01 17:32:15)
>> I wrote it, but couldn't reread myself... This doesn't contain any
>> change apart from reindenting.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Skimmed the changes looking for non-mechanical changes, so assuming the
> indentation isn't part of the parser (*cough* python *cough*),
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
It's not.
And I don't get python ;)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] overlay: add missing foreground option

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/3] overlay: add missing foreground option
URL   : https://patchwork.freedesktop.org/series/37494/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
902b754804ff76fbbf048ff889a95a4d7c0da5e6 tests/perf: fix report validity check on gen10+

with latest DRM-Tip kernel build CI_DRM_3713
cc6c1df8bef5 drm-tip: 2018y-02m-01d-16h-46m-26s UTC integration manifest

No testlist changes.

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:419s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:431s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:371s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:492s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:486s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:489s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:469s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:455s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:570s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:414s
fi-gdg-551       total:288  pass:180  dwarn:0   dfail:0   fail:0   skip:108 time:281s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:389s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:403s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:413s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:464s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:418s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:459s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:497s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:458s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:500s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:577s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:429s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:507s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:525s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:488s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:475s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:412s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:429s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:522s
Blacklisted hosts:
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:470s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_850/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/3] overlay: add missing foreground option

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/3] overlay: add missing foreground option
URL   : https://patchwork.freedesktop.org/series/37494/
State : failure

== Summary ==

Test perf:
        Subgroup polling:
                pass       -> FAIL       (shard-hsw) fdo#102252
Test kms_sysfs_edid_timing:
                warn       -> PASS       (shard-apl) fdo#100047
Test kms_flip:
        Subgroup plain-flip-fb-recreate:
                fail       -> PASS       (shard-hsw) fdo#100368
        Subgroup flip-vs-panning-vs-hang-interruptible:
                dmesg-warn -> PASS       (shard-snb) fdo#103821
Test gem_exec_suspend:
        Subgroup basic-s4-devices:
                pass       -> INCOMPLETE (shard-snb)

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821

shard-apl        total:2836 pass:1750 dwarn:1   dfail:0   fail:21  skip:1064 time:12512s
shard-hsw        total:2836 pass:1732 dwarn:1   dfail:0   fail:12  skip:1090 time:11658s
shard-snb        total:2775 pass:1299 dwarn:1   dfail:0   fail:9   skip:1465 time:6316s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_850/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev