* [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS
@ 2018-02-05 11:56 Thierry Reding
2018-02-05 11:56 ` [Intel-gfx] [PATCH i-g-t 2/2] tools/intel_dp_compliance: Add missing GLIB_CFLAGS Thierry Reding
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Thierry Reding @ 2018-02-05 11:56 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
From: Thierry Reding <treding@nvidia.com>
testdisplay.h includes the glib.h header file but the Makefile does not
explicitly pass a -I option with the path containing that header, hence
causing the build to fail. Note that this doesn't seem to happen with a
recent enough version of cairo, which implicitly provides the correct
-I option.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
tests/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 1b9a7b0a2311..8472a6bf0a73 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -149,6 +149,8 @@ kms_chamelium_LDADD = $(LDADD) $(XMLRPC_LIBS) $(LIBUDEV_LIBS)
audio_CFLAGS = $(AM_CFLAGS) $(ALSA_CFLAGS)
audio_LDADD = $(LDADD) $(ALSA_LIBS)
+testdisplay_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS)
+
amdgpu_amd_basic_CFLAGS = $(AM_CFLAGS) $(DRM_AMDGPU_CFLAGS)
amdgpu_amd_basic_LDADD = $(LDADD) $(DRM_AMDGPU_LIBS)
amdgpu_amd_cs_nop_CFLAGS = $(AM_CFLAGS) $(DRM_AMDGPU_CFLAGS)
--
2.15.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH i-g-t 2/2] tools/intel_dp_compliance: Add missing GLIB_CFLAGS
2018-02-05 11:56 [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Thierry Reding
@ 2018-02-05 11:56 ` Thierry Reding
2018-02-05 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2018-02-05 11:56 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
From: Thierry Reding <treding@nvidia.com>
intel_dp_compliance.h includes the glib.h header file but the Makefile
does not explicitly pass a -I option with the path containing that
header, hence causing the build to fail. Note that this doesn't seem to
happen with a recent enough version of cairo, which implicitly provides
the correct -I option.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
tools/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index dcf282eaff4e..d28c59fcf8ba 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -9,7 +9,7 @@ endif
if HAVE_UDEV
bin_PROGRAMS += intel_dp_compliance
-intel_dp_compliance_CFLAGS = $(AM_CFLAGS)
+intel_dp_compliance_CFLAGS = $(AM_CFLAGS) $(GLIB_CFLAGS)
intel_dp_compliance_LDADD = $(top_builddir)/lib/libintel_tools.la
endif
--
2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS
2018-02-05 11:56 [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Thierry Reding
2018-02-05 11:56 ` [Intel-gfx] [PATCH i-g-t 2/2] tools/intel_dp_compliance: Add missing GLIB_CFLAGS Thierry Reding
@ 2018-02-05 12:30 ` Patchwork
2018-02-05 14:27 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-02-27 13:38 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-05 12:30 UTC (permalink / raw)
To: Thierry Reding; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS
URL : https://patchwork.freedesktop.org/series/37655/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
c219cc5307474cb53612ca759354f9473955e110 tools: Clear unused fields in register spec
with latest DRM-Tip kernel build CI_DRM_3721
04c7e906ad23 drm-tip: 2018y-02m-05d-11h-21m-11s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713
Test gem_ringfill:
Subgroup basic-default-hang:
incomplete -> DMESG-WARN (fi-pnv-d510) fdo#101600
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:420s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:423s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:377s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:283s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:482s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:486s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:467s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:464s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:573s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:415s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:282s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:511s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:390s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:397s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:415s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:454s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:410s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:464s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:494s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:454s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:501s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:576s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:432s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:512s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:525s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:486s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:492s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:414s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:431s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:522s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:397s
Blacklisted hosts:
fi-cnl-y3 total:288 pass:261 dwarn:1 dfail:0 fail:0 skip:26 time:576s
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:471s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_864/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS
2018-02-05 11:56 [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Thierry Reding
2018-02-05 11:56 ` [Intel-gfx] [PATCH i-g-t 2/2] tools/intel_dp_compliance: Add missing GLIB_CFLAGS Thierry Reding
2018-02-05 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Patchwork
@ 2018-02-05 14:27 ` Patchwork
2018-02-27 13:38 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-05 14:27 UTC (permalink / raw)
To: Thierry Reding; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS
URL : https://patchwork.freedesktop.org/series/37655/
State : failure
== Summary ==
Warning: bzip CI_DRM_3721/shard-glkb6/results32.json.bz2 wasn't in correct JSON format
Test gem_eio:
Subgroup in-flight-contexts:
fail -> PASS (shard-hsw) fdo#104676
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-cur-indfb-draw-pwrite:
fail -> PASS (shard-apl) fdo#101623
Test kms_flip_tiling:
Subgroup flip-y-tiled:
pass -> FAIL (shard-apl) fdo#103822
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-apl) fdo#99912
Test kms_flip:
Subgroup 2x-dpms-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw)
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-apl total:2836 pass:1750 dwarn:1 dfail:0 fail:20 skip:1064 time:12426s
shard-hsw total:2836 pass:1733 dwarn:1 dfail:0 fail:11 skip:1090 time:11565s
shard-snb total:2836 pass:1328 dwarn:1 dfail:0 fail:10 skip:1497 time:6526s
Blacklisted hosts:
shard-kbl total:2836 pass:1868 dwarn:6 dfail:1 fail:22 skip:939 time:9437s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_864/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS
2018-02-05 11:56 [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Thierry Reding
` (2 preceding siblings ...)
2018-02-05 14:27 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-02-27 13:38 ` Petri Latvala
2018-02-27 13:50 ` Arkadiusz Hiler
3 siblings, 1 reply; 6+ messages in thread
From: Petri Latvala @ 2018-02-27 13:38 UTC (permalink / raw)
To: Thierry Reding, Arkadiusz Hiler; +Cc: igt-dev, intel-gfx
On Mon, Feb 05, 2018 at 12:56:10PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> testdisplay.h includes the glib.h header file but the Makefile does not
> explicitly pass a -I option with the path containing that header, hence
> causing the build to fail. Note that this doesn't seem to happen with a
> recent enough version of cairo, which implicitly provides the correct
> -I option.
Hmm. We only have GLIB_CFLAGS when HAVE_GLIB, but testdisplay is
always built. Same for intel_dp_compliance.
Should we make glib mandatory as well? Arek, thoughts?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS
2018-02-27 13:38 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
@ 2018-02-27 13:50 ` Arkadiusz Hiler
0 siblings, 0 replies; 6+ messages in thread
From: Arkadiusz Hiler @ 2018-02-27 13:50 UTC (permalink / raw)
To: Thierry Reding, igt-dev, intel-gfx
On Tue, Feb 27, 2018 at 03:38:58PM +0200, Petri Latvala wrote:
> On Mon, Feb 05, 2018 at 12:56:10PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > testdisplay.h includes the glib.h header file but the Makefile does not
> > explicitly pass a -I option with the path containing that header, hence
> > causing the build to fail. Note that this doesn't seem to happen with a
> > recent enough version of cairo, which implicitly provides the correct
> > -I option.
>
>
> Hmm. We only have GLIB_CFLAGS when HAVE_GLIB, but testdisplay is
> always built. Same for intel_dp_compliance.
>
> Should we make glib mandatory as well? Arek, thoughts?
Yep, making sounds good. It's extremely common and we use it also for
the igtrc handling.
This allows us to remove quite a few more ifdefs and will make couple of
pending reworks easier :-)
- Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-27 13:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-05 11:56 [igt-dev] [PATCH i-g-t 1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Thierry Reding
2018-02-05 11:56 ` [Intel-gfx] [PATCH i-g-t 2/2] tools/intel_dp_compliance: Add missing GLIB_CFLAGS Thierry Reding
2018-02-05 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/testdisplay: Explicitly use GLIB_CFLAGS Patchwork
2018-02-05 14:27 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-02-27 13:38 ` [igt-dev] [PATCH i-g-t 1/2] " Petri Latvala
2018-02-27 13:50 ` Arkadiusz Hiler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox