[igt-dev] [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl

[igt-dev] [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl

[Chris Wilson]

==24749== Syscall param ioctl(generic) points to uninitialised byte(s)
==24749==    at 0x6A8ADC7: ioctl (syscall-template.S:84)
==24749==    by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0)
==24749==    by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022)
==24749==    by 0x112937: set_dpms (kms_flip.c:263)
==24749==    by 0x112937: run_test_step (kms_flip.c:776)
==24749==    by 0x112937: event_loop (kms_flip.c:1138)
==24749==    by 0x115468: run_test_on_crtc_set (kms_flip.c:1378)
==24749==    by 0x115468: run_test (kms_flip.c:1450)
==24749==    by 0x1111CF: main (kms_flip.c:1673)
==24749==  Address 0x1ffefff2a0 is on thread 1's stack
==24749==  in frame #2, created by kmstest_set_connector_dpms (igt_kms.c:1012)

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_kms.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index eb57f4a9..ecc7a799 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1108,11 +1108,10 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
 	bool found_it = false;
 
 	for (i = 0; i < connector->count_props; i++) {
-		struct drm_mode_get_property prop;
+		struct drm_mode_get_property prop = {
+			.prop_id = connector->props[i],
+		};
 
-		prop.prop_id = connector->props[i];
-		prop.count_values = 0;
-		prop.count_enum_blobs = 0;
 		if (drmIoctl(fd, DRM_IOCTL_MODE_GETPROPERTY, &prop))
 			continue;
 
-- 
2.16.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/kms: Clear unused fields for getproperty ioctl

[Patchwork]

== Series Details ==

Series: lib/kms: Clear unused fields for getproperty ioctl
URL   : https://patchwork.freedesktop.org/series/38144/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
7a02d3056fe93fd2ddd2986f7d3db5f384ee22a0 lib: force a reset on an uncooperative i915 device

with latest DRM-Tip kernel build CI_DRM_3760
fb7ff325f927 drm-tip: 2018y-02m-13d-10h-09m-45s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:265  dwarn:0   dfail:0   fail:2   skip:21  time:447s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:429s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:376s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:499s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:289s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:484s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:473s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:473s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:567s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:569s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:414s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:285s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:259  dwarn:0   dfail:0   fail:2   skip:27  time:414s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:416s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:457s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:415s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:457s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:496s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:502s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:595s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:432s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:512s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:528s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:494s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:474s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:417s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:435s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:522s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:409s
Blacklisted hosts:
fi-glk-dsi       total:122  pass:109  dwarn:0   dfail:0   fail:0   skip:12 

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_909/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: warning for lib/kms: Clear unused fields for getproperty ioctl

[Patchwork]

== Series Details ==

Series: lib/kms: Clear unused fields for getproperty ioctl
URL   : https://patchwork.freedesktop.org/series/38144/
State : warning

== Summary ==

Test kms_mmap_write_crc:
                skip       -> PASS       (shard-apl)
Test kms_flip:
        Subgroup plain-flip-fb-recreate-interruptible:
                fail       -> PASS       (shard-snb) fdo#100368 +1
        Subgroup modeset-vs-vblank-race-interruptible:
                fail       -> PASS       (shard-apl) fdo#103060
Test pm_rpm:
        Subgroup modeset-stress-extra-wait:
                fail       -> PASS       (shard-hsw) fdo#105069 +2
Test kms_cursor_crc:
        Subgroup cursor-64x64-suspend:
                skip       -> PASS       (shard-snb) fdo#102365
Test perf_pmu:
        Subgroup semaphore-wait-rcs0:
                fail       -> PASS       (shard-apl) fdo#105011
Test perf:
        Subgroup oa-exponents:
                pass       -> FAIL       (shard-apl) fdo#102254
Test pm_rc6_residency:
        Subgroup rc6-accuracy:
                pass       -> SKIP       (shard-snb)
Test kms_setmode:
        Subgroup basic:
                pass       -> FAIL       (shard-apl) fdo#99912
Test kms_atomic_transition:
        Subgroup 1x-modeset-transitions:
                pass       -> FAIL       (shard-apl) fdo#103207

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#105069 https://bugs.freedesktop.org/show_bug.cgi?id=105069
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#105011 https://bugs.freedesktop.org/show_bug.cgi?id=105011
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207

shard-apl        total:3344 pass:1739 dwarn:1   dfail:0   fail:22  skip:1580 time:13840s
shard-hsw        total:3427 pass:1718 dwarn:1   dfail:0   fail:53  skip:1654 time:14817s
shard-snb        total:3427 pass:1349 dwarn:1   dfail:0   fail:10  skip:2067 time:7647s
Blacklisted hosts:
shard-kbl        total:3427 pass:1862 dwarn:40  dfail:2   fail:21  skip:1502 time:11134s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_909/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl

[Ville Syrjälä]

On Tue, Feb 13, 2018 at 09:30:40AM +0000, Chris Wilson wrote:
> ==24749== Syscall param ioctl(generic) points to uninitialised byte(s)
> ==24749==    at 0x6A8ADC7: ioctl (syscall-template.S:84)
> ==24749==    by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0)
> ==24749==    by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022)
> ==24749==    by 0x112937: set_dpms (kms_flip.c:263)
> ==24749==    by 0x112937: run_test_step (kms_flip.c:776)
> ==24749==    by 0x112937: event_loop (kms_flip.c:1138)
> ==24749==    by 0x115468: run_test_on_crtc_set (kms_flip.c:1378)
> ==24749==    by 0x115468: run_test (kms_flip.c:1450)
> ==24749==    by 0x1111CF: main (kms_flip.c:1673)
> ==24749==  Address 0x1ffefff2a0 is on thread 1's stack
> ==24749==  in frame #2, created by kmstest_set_connector_dpms (igt_kms.c:1012)
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Looks like all of the other fields are either stuff the kernel will
return to us, or ignored on account of the count_ stuff. So the kernel
doesn't seem to be missing any crucial input sanity checks.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  lib/igt_kms.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index eb57f4a9..ecc7a799 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1108,11 +1108,10 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
>  	bool found_it = false;
>  
>  	for (i = 0; i < connector->count_props; i++) {
> -		struct drm_mode_get_property prop;
> +		struct drm_mode_get_property prop = {
> +			.prop_id = connector->props[i],
> +		};
>  
> -		prop.prop_id = connector->props[i];
> -		prop.count_values = 0;
> -		prop.count_enum_blobs = 0;
>  		if (drmIoctl(fd, DRM_IOCTL_MODE_GETPROPERTY, &prop))
>  			continue;
>  
> -- 
> 2.16.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev