Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/perf_pmu: Skip hotplug test on Broxton
@ 2018-02-21 10:57 Tvrtko Ursulin
  2018-02-21 10:59 ` [Intel-gfx] " Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Tvrtko Ursulin @ 2018-02-21 10:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Apollolake machine in the shards cannot bring the CPU0 back online so
skip the test on all Broxtons for now.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/perf_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 0beb91976102..b6debf523201 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd)
 	int fd, ret;
 	int cur = 0;
 
+	igt_require(IS_BROXTON(intel_get_drm_devid(gem_fd)));
 	igt_require(cpu0_hotplug_support());
 
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(I915_ENGINE_CLASS_RENDER, 0));
-- 
2.14.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Skip hotplug test on Broxton
  2018-02-21 10:57 [igt-dev] [PATCH i-g-t] tests/perf_pmu: Skip hotplug test on Broxton Tvrtko Ursulin
@ 2018-02-21 10:59 ` Chris Wilson
  2018-02-21 10:59 ` [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-02-21 10:59 UTC (permalink / raw)
  To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx

Quoting Tvrtko Ursulin (2018-02-21 10:57:38)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Apollolake machine in the shards cannot bring the CPU0 back online so
> skip the test on all Broxtons for now.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  tests/perf_pmu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 0beb91976102..b6debf523201 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd)
>         int fd, ret;
>         int cur = 0;
>  
> +       igt_require(IS_BROXTON(intel_get_drm_devid(gem_fd)));
>         igt_require(cpu0_hotplug_support());

I would plonk it in cpu0_hotplug_support() with a one-liner explanation?

Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Intel-gfx] [PATCH i-g-t v2] tests/perf_pmu: Skip hotplug test on Broxton
  2018-02-21 10:57 [igt-dev] [PATCH i-g-t] tests/perf_pmu: Skip hotplug test on Broxton Tvrtko Ursulin
  2018-02-21 10:59 ` [Intel-gfx] " Chris Wilson
@ 2018-02-21 10:59 ` Tvrtko Ursulin
  2018-02-21 11:00   ` [igt-dev] " Chris Wilson
  2018-02-21 17:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Skip hotplug test on Broxton (rev3) Patchwork
  2018-02-21 21:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 1 reply; 8+ messages in thread
From: Tvrtko Ursulin @ 2018-02-21 10:59 UTC (permalink / raw)
  To: igt-dev; +Cc: Intel-gfx

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Apollolake machine in the shards cannot bring the CPU0 back online so
skip the test on all Broxtons for now.

v2: Fix inverted check.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/perf_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 0beb91976102..b9ddd0d27bce 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd)
 	int fd, ret;
 	int cur = 0;
 
+	igt_require(!IS_BROXTON(intel_get_drm_devid(gem_fd)));
 	igt_require(cpu0_hotplug_support());
 
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(I915_ENGINE_CLASS_RENDER, 0));
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v2] tests/perf_pmu: Skip hotplug test on Broxton
  2018-02-21 10:59 ` [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
@ 2018-02-21 11:00   ` Chris Wilson
  2018-02-21 11:03     ` [igt-dev] [PATCH i-g-t v3] " Tvrtko Ursulin
  0 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2018-02-21 11:00 UTC (permalink / raw)
  To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin

Quoting Tvrtko Ursulin (2018-02-21 10:59:32)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Apollolake machine in the shards cannot bring the CPU0 back online so
> skip the test on all Broxtons for now.
> 
> v2: Fix inverted check.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  tests/perf_pmu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 0beb91976102..b9ddd0d27bce 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd)
>         int fd, ret;
>         int cur = 0;
>  
> +       igt_require(!IS_BROXTON(intel_get_drm_devid(gem_fd)));
>         igt_require(cpu0_hotplug_support());

igt_skip_on() then. It produces nicer output than inverting everywhere.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] [PATCH i-g-t v3] tests/perf_pmu: Skip hotplug test on Broxton
  2018-02-21 11:00   ` [igt-dev] " Chris Wilson
@ 2018-02-21 11:03     ` Tvrtko Ursulin
  2018-02-21 11:06       ` [igt-dev] [Intel-gfx] " Chris Wilson
  0 siblings, 1 reply; 8+ messages in thread
From: Tvrtko Ursulin @ 2018-02-21 11:03 UTC (permalink / raw)
  To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Apollolake machine in the shards cannot bring the CPU0 back online so
skip the test on all Broxtons for now.

v2: Fix inverted check.
v3: igt_skip_on. (Chris Wilson)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/perf_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 0beb91976102..1d5a33025cc5 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -966,6 +966,7 @@ static void cpu_hotplug(int gem_fd)
 	int fd, ret;
 	int cur = 0;
 
+	igt_skip_on(IS_BROXTON(intel_get_drm_devid(gem_fd)));
 	igt_require(cpu0_hotplug_support());
 
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(I915_ENGINE_CLASS_RENDER, 0));
-- 
2.14.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t v3] tests/perf_pmu: Skip hotplug test on Broxton
  2018-02-21 11:03     ` [igt-dev] [PATCH i-g-t v3] " Tvrtko Ursulin
@ 2018-02-21 11:06       ` Chris Wilson
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-02-21 11:06 UTC (permalink / raw)
  To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx

Quoting Tvrtko Ursulin (2018-02-21 11:03:32)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Apollolake machine in the shards cannot bring the CPU0 back online so
> skip the test on all Broxtons for now.
> 
> v2: Fix inverted check.
> v3: igt_skip_on. (Chris Wilson)
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Skip hotplug test on Broxton (rev3)
  2018-02-21 10:57 [igt-dev] [PATCH i-g-t] tests/perf_pmu: Skip hotplug test on Broxton Tvrtko Ursulin
  2018-02-21 10:59 ` [Intel-gfx] " Chris Wilson
  2018-02-21 10:59 ` [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
@ 2018-02-21 17:02 ` Patchwork
  2018-02-21 21:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-02-21 17:02 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: igt-dev

== Series Details ==

Series: tests/perf_pmu: Skip hotplug test on Broxton (rev3)
URL   : https://patchwork.freedesktop.org/series/38689/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
960e55a87d7b7d7385063e37cc9f281df2be8037 igt/gem_ctx_isolation: Check isolation of registers between contexts

with latest DRM-Tip kernel build CI_DRM_3816
42d073db2a85 drm-tip: 2018y-02m-21d-14h-03m-58s UTC integration manifest

No testlist changes.

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                fail       -> PASS       (fi-ivb-3520m)
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
                fail       -> PASS       (fi-ivb-3520m)
        Subgroup suspend-read-crc-pipe-c:
                fail       -> PASS       (fi-ivb-3520m)

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:422s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:426s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:375s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:491s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:287s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:478s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:467s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:456s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:566s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:415s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:284s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:509s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:386s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:410s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:455s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:411s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:454s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:489s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:449s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:496s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:589s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:429s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:503s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:521s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:491s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:480s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:408s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:431s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:524s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:394s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_971/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for tests/perf_pmu: Skip hotplug test on Broxton (rev3)
  2018-02-21 10:57 [igt-dev] [PATCH i-g-t] tests/perf_pmu: Skip hotplug test on Broxton Tvrtko Ursulin
                   ` (2 preceding siblings ...)
  2018-02-21 17:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Skip hotplug test on Broxton (rev3) Patchwork
@ 2018-02-21 21:32 ` Patchwork
  3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-02-21 21:32 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: igt-dev

== Series Details ==

Series: tests/perf_pmu: Skip hotplug test on Broxton (rev3)
URL   : https://patchwork.freedesktop.org/series/38689/
State : success

== Summary ==

Warning: bzip IGTPW_971/shard-kbl5/results17.json.bz2 wasn't in correct JSON format
Test gem_eio:
        Subgroup in-flight:
                incomplete -> PASS       (shard-apl)
Test perf_pmu:
        Subgroup cpu-hotplug:
                incomplete -> SKIP       (shard-apl) fdo#104965
Test kms_flip:
        Subgroup 2x-dpms-vs-vblank-race:
                pass       -> INCOMPLETE (shard-hsw) fdo#103060
        Subgroup flip-vs-expired-vblank-interruptible:
                pass       -> FAIL       (shard-apl) fdo#102887
        Subgroup plain-flip-ts-check-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368 +1
Test kms_plane_multiple:
        Subgroup legacy-pipe-b-tiling-none:
                skip       -> PASS       (shard-snb)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-c-frame-sequence:
                fail       -> PASS       (shard-apl) fdo#103481
Test perf:
        Subgroup polling:
                pass       -> FAIL       (shard-hsw) fdo#102252
        Subgroup buffer-fill:
                pass       -> FAIL       (shard-apl) fdo#103755
Test kms_cursor_crc:
        Subgroup cursor-256x256-suspend:
                pass       -> SKIP       (shard-snb) fdo#103375
Test kms_atomic_transition:
        Subgroup 1x-modeset-transitions-nonblocking-fencing:
                fail       -> PASS       (shard-apl) fdo#103207
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
                pass       -> SKIP       (shard-snb) fdo#101623
Test kms_vblank:
        Subgroup pipe-b-wait-busy-hang:
                skip       -> PASS       (shard-snb)

fdo#104965 https://bugs.freedesktop.org/show_bug.cgi?id=104965
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623

shard-apl        total:3465 pass:1818 dwarn:1   dfail:0   fail:15  skip:1631 time:12443s
shard-hsw        total:3424 pass:1743 dwarn:1   dfail:0   fail:3   skip:1675 time:11779s
shard-snb        total:3465 pass:1355 dwarn:1   dfail:1   fail:2   skip:2106 time:6688s
Blacklisted hosts:
shard-kbl        total:3294 pass:1868 dwarn:1   dfail:0   fail:13  skip:1410 time:8632s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_971/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-02-21 21:32 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 10:57 [igt-dev] [PATCH i-g-t] tests/perf_pmu: Skip hotplug test on Broxton Tvrtko Ursulin
2018-02-21 10:59 ` [Intel-gfx] " Chris Wilson
2018-02-21 10:59 ` [Intel-gfx] [PATCH i-g-t v2] " Tvrtko Ursulin
2018-02-21 11:00   ` [igt-dev] " Chris Wilson
2018-02-21 11:03     ` [igt-dev] [PATCH i-g-t v3] " Tvrtko Ursulin
2018-02-21 11:06       ` [igt-dev] [Intel-gfx] " Chris Wilson
2018-02-21 17:02 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Skip hotplug test on Broxton (rev3) Patchwork
2018-02-21 21:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox