From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 08/11] trace.pl: Fix engine busy accounting in split mode
Date: Tue, 6 Mar 2018 12:43:12 +0000 [thread overview]
Message-ID: <20180306124315.30208-9-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180306124315.30208-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
In split mode all requests have to be added up since they were previously
re-arranged so there is no overlap.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: John Harrison <John.C.Harrison@intel.com>
---
scripts/trace.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/trace.pl b/scripts/trace.pl
index 27b39efcebbd..e7ce273ef26a 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -596,7 +596,8 @@ foreach my $key (@sorted_keys) {
$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
$db{$key}->{'duration'} = $notify - $start;
- $running{$ring} += $end - $start unless exists $db{$key}->{'no-end'};
+ $running{$ring} += $end - $start if $correct_durations or
+ not exists $db{$key}->{'no-end'};
$runnable{$ring} += $db{$key}->{'execute-delay'};
$queued{$ring} += $start - $db{$key}->{'execute-delay'} - $db{$key}->{'queue'};
--
2.14.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-03-06 12:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 12:43 [Intel-gfx] [PATCH i-g-t v2 00/11] trace.pl fixes Tvrtko Ursulin
2018-03-06 12:43 ` [Intel-gfx] [PATCH i-g-t 01/11] trace.pl: Catch-up with tracepoint renames Tvrtko Ursulin
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 02/11] scripts/trace.pl: More hash key optimisations Tvrtko Ursulin
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 03/11] scripts/trace.pl: Sort order Tvrtko Ursulin
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 04/11] scripts/trace.pl: Calculate stats only after all munging Tvrtko Ursulin
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 05/11] scripts/trace.pl: Simplify 'end' & 'notify' generation Tvrtko Ursulin
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 06/11] trace.pl: Move sortQueue near its user Tvrtko Ursulin
2018-04-18 16:56 ` [Intel-gfx] " Lionel Landwerlin
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 07/11] trace.pl: Move min/max timestamp lookup to last loop Tvrtko Ursulin
2018-04-18 16:56 ` Lionel Landwerlin
2018-03-06 12:43 ` Tvrtko Ursulin [this message]
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 09/11] trace.pl: Add support for colouring context execution Tvrtko Ursulin
2018-04-18 17:02 ` [igt-dev] [Intel-gfx] " Lionel Landwerlin
2018-03-06 12:43 ` [Intel-gfx] [PATCH i-g-t 10/11] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-03-06 12:43 ` [igt-dev] [PATCH i-g-t 11/11] trace.pl: Fix request split mode Tvrtko Ursulin
2018-03-06 14:18 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes (rev2) Patchwork
2018-03-06 19:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-04-18 14:52 ` [igt-dev] [PATCH i-g-t v2 00/11] trace.pl fixes Tvrtko Ursulin
-- strict thread matches above, loose matches on Subject: below --
2018-01-30 10:11 [igt-dev] [PATCH i-g-t " Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 08/11] trace.pl: Fix engine busy accounting in split mode Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306124315.30208-9-tvrtko.ursulin@linux.intel.com \
--to=tursulin@ursulin.net \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox