* [igt-dev] [PATCH i-g-t] tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer
@ 2018-03-09 20:43 Ville Syrjala
2018-03-09 21:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ville Syrjala @ 2018-03-09 20:43 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
On most platforms ARGB8888 is only supported by the cursor plane,
which doesn't support tiled buffers. Hence the kernel is under no
obligation to accept the request to create a tiled ARGB888
framebuffer. Apparently we've been letting this slip through so
far, but that is about to change.
Fortunately the resulting fb was neer actually used (in fact the
kernel would have rejected the setplane/atomic ioctl with such
a framebuffer). All we're really interested here is the gem BO
which we feed to the kernel via the setcursor ioctl after changing
the tiling to linear. To avoid changing the test drastically we
can simply change the fb to XRGB8888, which combined with X-tiling
is supported on all platforms.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/pm_rpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 04be8c544826..d2b837fe9255 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -1446,7 +1446,7 @@ static void cursor_subtest(bool dpms)
LOCAL_DRM_FORMAT_MOD_NONE, &cursor_fb1);
igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
LOCAL_DRM_FORMAT_MOD_NONE, &cursor_fb2);
- igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+ igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_XRGB8888,
LOCAL_I915_FORMAT_MOD_X_TILED, &cursor_fb3);
fill_igt_fb(&cursor_fb1, 0xFF00FFFF);
--
2.16.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer
2018-03-09 20:43 [igt-dev] [PATCH i-g-t] tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer Ville Syrjala
@ 2018-03-09 21:08 ` Patchwork
2018-03-09 21:23 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-03-10 5:50 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-03-09 21:08 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer
URL : https://patchwork.freedesktop.org/series/39722/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
5d71d7782a830843c7231fbd72ab3edae19b48d7 igt/gem_fd_exhaustion: Modify fs.nr_open for duration of the test
with latest DRM-Tip kernel build CI_DRM_3905
2e2ef5a5221a drm-tip: 2018y-03m-09d-14h-28m-10s UTC integration manifest
No testlist changes.
---- Known issues:
Test debugfs_test:
Subgroup read_all_entries:
incomplete -> PASS (fi-snb-2520m) fdo#103713
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:424s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:375s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:505s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:491s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:490s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:484s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:468s
fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:404s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:580s
fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:596s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:415s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:291s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:520s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:397s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:411s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:465s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:420s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:468s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:462s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:509s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:582s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:435s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:523s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:538s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:503s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:485s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:425s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:429s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:524s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:394s
Blacklisted hosts:
fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:503s
fi-cnl-drrs total:288 pass:257 dwarn:3 dfail:0 fail:0 skip:19 time:518s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1100/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer
2018-03-09 20:43 [igt-dev] [PATCH i-g-t] tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer Ville Syrjala
2018-03-09 21:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-03-09 21:23 ` Chris Wilson
2018-03-10 5:50 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-03-09 21:23 UTC (permalink / raw)
To: Ville Syrjala, igt-dev
Quoting Ville Syrjala (2018-03-09 20:43:08)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> On most platforms ARGB8888 is only supported by the cursor plane,
> which doesn't support tiled buffers. Hence the kernel is under no
> obligation to accept the request to create a tiled ARGB888
> framebuffer. Apparently we've been letting this slip through so
> far, but that is about to change.
>
> Fortunately the resulting fb was neer actually used (in fact the
> kernel would have rejected the setplane/atomic ioctl with such
> a framebuffer). All we're really interested here is the gem BO
> which we feed to the kernel via the setcursor ioctl after changing
> the tiling to linear. To avoid changing the test drastically we
> can simply change the fb to XRGB8888, which combined with X-tiling
> is supported on all platforms.
Yup, XRGB can be used for cursor as well as all the other planes, so no
loss of generality (and as stated much gained!).
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer
2018-03-09 20:43 [igt-dev] [PATCH i-g-t] tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer Ville Syrjala
2018-03-09 21:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-09 21:23 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2018-03-10 5:50 ` Patchwork
2018-03-12 15:08 ` Ville Syrjälä
2 siblings, 1 reply; 5+ messages in thread
From: Patchwork @ 2018-03-10 5:50 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer
URL : https://patchwork.freedesktop.org/series/39722/
State : failure
== Summary ==
---- Possible new issues:
Test kms_chv_cursor_fail:
Subgroup pipe-a-128x128-left-edge:
fail -> PASS (shard-apl)
Test kms_flip_tiling:
Subgroup flip-to-y-tiled:
pass -> FAIL (shard-apl)
---- Known issues:
Test gem_eio:
Subgroup in-flight:
incomplete -> PASS (shard-apl) fdo#105341 +1
Test kms_cursor_crc:
Subgroup cursor-128x128-suspend:
skip -> INCOMPLETE (shard-hsw) fdo#103540
Test kms_flip:
Subgroup plain-flip-ts-check-interruptible:
fail -> PASS (shard-hsw) fdo#100368 +1
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3467 pass:1825 dwarn:1 dfail:0 fail:8 skip:1632 time:12253s
shard-hsw total:3427 pass:1755 dwarn:1 dfail:0 fail:2 skip:1667 time:11254s
shard-snb total:3467 pass:1365 dwarn:1 dfail:0 fail:1 skip:2100 time:6986s
Blacklisted hosts:
shard-kbl total:3435 pass:1932 dwarn:1 dfail:0 fail:7 skip:1494 time:9085s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1100/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-12 15:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-09 20:43 [igt-dev] [PATCH i-g-t] tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer Ville Syrjala
2018-03-09 21:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-03-09 21:23 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-03-10 5:50 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2018-03-12 15:08 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox