Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Katarzyna Dec <katarzyna.dec@intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 01/20] tests/psr: Print the reason for skipping when sink lacks PSR support
Date: Fri, 13 Apr 2018 12:57:02 +0200	[thread overview]
Message-ID: <20180413105702.GA13079@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20180411023732.32362-1-dhinakaran.pandiyan@intel.com>

On Tue, Apr 10, 2018 at 07:37:13PM -0700, Dhinakaran Pandiyan wrote:
> And rename the function to match what it does.
> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
> ---
>  tests/kms_psr_sink_crc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 98d29ba9..93807c03 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -193,7 +193,7 @@ static void fill_render(data_t *data, uint32_t handle, unsigned char color)
>  	gem_bo_busy(data->drm_fd, handle);
>  }
>  
> -static bool psr_possible(data_t *data)
> +static bool sink_support(data_t *data)
>  {
>  	char buf[512];
>  
> @@ -513,8 +513,8 @@ int main(int argc, char *argv[])
>  
>  		igt_set_module_param_int("enable_psr", running_with_psr_disabled ?
>  					 0 : 1);
> -
> -		igt_skip_on(!psr_possible(&data));
> +		igt_require_f(sink_support(&data),
> +			      "Sink does not support PSR\n");
>  
>  		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
>  		igt_assert(data.bufmgr);
> -- 
> 2.14.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-04-13 10:57 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11  2:37 [igt-dev] [PATCH i-g-t 01/20] tests/psr: Print the reason for skipping when sink lacks PSR support Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 02/20] tests/psr: Remove "psr_" prefix from basic and drrs subtests Dhinakaran Pandiyan
2018-04-13 10:57   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 03/20] tests/psr: Rename psr_active() to psr_enabled() Dhinakaran Pandiyan
2018-04-13 10:58   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 04/20] tests/psr: Store the debugfs file descriptor Dhinakaran Pandiyan
2018-04-13 10:58   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 05/20] tests/psr: Assert sink CRC length and make use of igt_sysfs_read() Dhinakaran Pandiyan
2018-04-13 10:59   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 06/20] tests/psr: Optimize check for green frame Dhinakaran Pandiyan
2018-04-13 10:59   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 07/20] tests/psr: Kill MMAP_GTT_WAITING Dhinakaran Pandiyan
2018-04-12 11:11   ` Katarzyna Dec
2018-04-16 21:44     ` Pandiyan, Dhinakaran
2018-04-23 23:01       ` Rodrigo Vivi
2018-04-16 22:08     ` Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 08/20] tests/psr: Merge PSR dpms and suspend variants Dhinakaran Pandiyan
2018-04-12 11:20   ` Katarzyna Dec
2018-04-16 21:46     ` Pandiyan, Dhinakaran
2018-04-17  7:58       ` Katarzyna Dec
2018-04-23 23:03       ` Rodrigo Vivi
2018-04-16 22:10     ` Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 09/20] tests/psr: Check for PSR entry more often and only for a second Dhinakaran Pandiyan
2018-04-12 11:25   ` Katarzyna Dec
2018-04-16 22:43     ` Dhinakaran Pandiyan
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 10/20] tests/psr: Remove delay between dpms toggle Dhinakaran Pandiyan
2018-04-12 11:26   ` Katarzyna Dec
2018-04-13  0:24     ` Dhinakaran Pandiyan
2018-04-13 11:05       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 11/20] tests/psr: Check for drrs status only after checking for PSR Dhinakaran Pandiyan
2018-04-13 11:21   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 12/20] tests/sink_crc_basic: Debug print CRC values Dhinakaran Pandiyan
2018-04-13 11:22   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 13/20] tests/psr: Get rid of global variable running_with_psr_disabled Dhinakaran Pandiyan
2018-04-13 11:22   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 14/20] tests/psr: Make testing with sink CRC non-default Dhinakaran Pandiyan
2018-04-13 11:22   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 15/20] tests/psr: Eliminate storing pointers for igt_plane_type Dhinakaran Pandiyan
2018-04-13 11:23   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 16/20] tests/psr: Pass data_t pointer to dpms_off_on Dhinakaran Pandiyan
2018-04-13 11:23   ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 17/20] tests/psr: Prepare for using timestamps Dhinakaran Pandiyan
2018-04-12 12:50   ` Katarzyna Dec
2018-04-13  0:21     ` Dhinakaran Pandiyan
2018-04-13 11:33       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 18/20] tests/psr: Check for timestamp support Dhinakaran Pandiyan
2018-04-12 12:52   ` Katarzyna Dec
2018-04-13  0:13     ` Dhinakaran Pandiyan
2018-04-13 11:34       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 19/20] tests/psr: Test PSR using interrupt timestamps Dhinakaran Pandiyan
2018-04-12 12:56   ` Katarzyna Dec
2018-04-16 22:49     ` [igt-dev] [PATCH i-g-t v2] " Dhinakaran Pandiyan
2018-04-17 12:53       ` Katarzyna Dec
2018-04-11  2:37 ` [igt-dev] [PATCH i-g-t 20/20] tests/psr: Add more PSR subtests to fast feedback list Dhinakaran Pandiyan
2018-04-11  8:42   ` Petri Latvala
2018-04-11 16:14     ` Pandiyan, Dhinakaran
2018-04-13  9:16       ` Petri Latvala
2018-04-15  1:13         ` Dhinakaran Pandiyan
2018-04-23 23:06           ` Rodrigo Vivi
2018-04-23 23:58             ` Dhinakaran Pandiyan
2018-04-24  9:34               ` Petri Latvala
2018-04-24 15:32                 ` Saarinen, Jani
2018-04-24 17:48                   ` Dhinakaran Pandiyan
2018-04-24 21:28                     ` Rodrigo Vivi
2018-04-25  8:34                       ` Petri Latvala
2018-04-25 17:56                         ` Pandiyan, Dhinakaran
2018-04-25 20:15                           ` Rodrigo Vivi
2018-04-11  3:07 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/20] tests/psr: Print the reason for skipping when sink lacks PSR support Patchwork
2018-04-11  3:53 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
2018-04-12 11:08 ` [igt-dev] [PATCH i-g-t 01/20] " Katarzyna Dec
2018-04-12 13:03 ` Katarzyna Dec
2018-04-13 10:57 ` Katarzyna Dec [this message]
2018-04-16 23:10 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,01/20] tests/psr: Print the reason for skipping when sink lacks PSR support (rev2) Patchwork
2018-04-25 21:00 ` Patchwork
2018-04-26  8:40   ` Petri Latvala
2018-05-09 23:41     ` Dhinakaran Pandiyan
2018-04-26  9:58 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180413105702.GA13079@kdec5-desk.ger.corp.intel.com \
    --to=katarzyna.dec@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox