Re: [igt-dev] [PATCH i-g-t 20/20] tests/psr: Add more PSR subtests to fast feedback list

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Apr 25, 2018 at 10:56:51AM -0700, Pandiyan, Dhinakaran wrote:
> 
> 
> 
> On Wed, 2018-04-25 at 11:34 +0300, Petri Latvala wrote:
> > On Tue, Apr 24, 2018 at 02:28:17PM -0700, Rodrigo Vivi wrote:
> > > On Tue, Apr 24, 2018 at 10:48:43AM -0700, Dhinakaran Pandiyan wrote:
> > > > 
> > > > 
> > > > 
> > > > On Tue, 2018-04-24 at 15:32 +0000, Saarinen, Jani wrote:
> > > > > HI, 
> > > > > 
> > > > > > -----Original Message-----
> > > > > > From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of Petri
> > > > > > Latvala
> > > > > > Sent: tiistai 24. huhtikuuta 2018 12.34
> > > > > > To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, Rodrigo
> > > > > > <rodrigo.vivi@intel.com>
> > > > > > Cc: igt-dev@lists.freedesktop.org
> > > > > > Subject: Re: [igt-dev] [PATCH i-g-t 20/20] tests/psr: Add more PSR subtests to
> > > > > > fast feedback list
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On 04/24/2018 02:58 AM, Dhinakaran Pandiyan wrote:
> > > > > > >
> > > > > > >
> > > > > > > On Mon, 2018-04-23 at 16:06 -0700, Rodrigo Vivi wrote:
> > > > > > >> On Sat, Apr 14, 2018 at 06:13:40PM -0700, Dhinakaran Pandiyan wrote:
> > > > > > >>> On Fri, 2018-04-13 at 12:16 +0300, Petri Latvala wrote:
> > > > > > >>>> On Wed, Apr 11, 2018 at 07:14:36PM +0300, Pandiyan, Dhinakaran wrote:
> > > > > > >>>>> Yeah, that is expected. The kernel patches are not in yet.
> > > > > > >>>> The requirement for using --sink-crc is going away when kernel side
> > > > > > >>>> patches land? Or how is this planned?
> > > > > > >>>>
> > > > > > >>> Irrespective of whether or when the kernel patches land, --sink-crc
> > > > > > >>> will not be used for CI. --sink-crc is being retained for developers
> > > > > > >>> to manually use it for debug and possibly fix the code in future.
> > > > > > >>>
> > > > > > >>> Having said that, the kernel patches adding time stamp support
> > > > > > >>> should land soon, after which the tests will not skip.
> > > > > > >> Ok, I finally looked to all patches on this series and I support all of them.
> > > > > > >>
> > > > > > >> My only concern is actually with patch 14 that is around this discussion here...
> > > > > > >>
> > > > > > >> For me it seems that or you run with interactive debug on or with
> > > > > > >> sink_crc and CI is not running with any so it will all skip.
> > > > > > >>
> > > > > > >> Unless I missunderstood something on that patch...
> > > > > > >>
> > > > > > >> If CI still runs without requiring any extra option I'm in favor of
> > > > > > >> the whole series and I'm tending to merge it soon...
> > > > > > >>
> > > > > > > CI will not need any options. Timestamps are supported by default on
> > > > > > > all platforms except CHV/VLV. We don't have those platforms in CI and
> > > > > > > I am planning to nuke PSR support for them.
> > > > > > >
> > > > > > 
> > > > > > These machines are VLV:
> > > > > > fi-byt-j1900
> > > > > > fi-byt-n2820
> > > > > Also CHV=BSW => fi-bsw-n3050
> > > > > 
> > > > 
> > > > No psr panels on them.
> > > 
> > > Ok, so it seems no need for waiting...
> > > 
> > > 
> > > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > on the series.
> > > 
> > > but let's see if Petri has more concerns.
> > 
> > 
> > No objections except for the fast-feedback.testlist changes. PSR
> > additions is acked in practice, but the tests need to first actually
> > run.
> > 
> 
> Petri,
> 
> If your concern is about tests getting skipped on PSR capable CI
> platforms, that is not a problem anymore. The kernel support was merged
> and the tests should not skip on these platforms.
> 
> References:
> 3f983e54fdad drm/i915/psr: Timestamps for PSR entry and exit interrupts.
> 54fd3149598c drm/i915/psr: Control PSR interrupts via debugfs
> e04f7ece1c45 drm/i915: Enable edp psr error interrupts on bdw+
> fc34044248b6 drm/i915: Enable edp psr error interrupts on hsw
> 
> 
> Anyone with privileges to the patchwork retest button should retest this
> series, if there are still concerns.

done...

> 
> 
> Rodrigo,
> 
> Can you merge the rest of the patches please? Or trigger a retest and
> merge the fast-feedback patch too?

Since I triggered the re-test I will give a time for it to run to avoid any
race issues between CI and me merging the patches.

(I think I should push only the first patch so you complete 5 patches
and get the rights to push the rest hehe just kidding ;))
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev