[igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Do not use scaling on haswell.

[igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Do not use scaling on haswell.

[Maarten Lankhorst]

Haswell doesn't support scaling the sprite planes, so we fail with
-ERANGE. Do the same as we do for gen9 pipe C, and do not attempt
to scale the sprite plane. It will fail, and the kernel will no
hide the failure from us.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106606
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_panel_fitting.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index 5dce101003c5..eacc6bc0bc11 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -134,11 +134,14 @@ static void test_panel_fitting(data_t *d)
 		igt_display_commit2(display, COMMIT_UNIVERSAL);
 
 		/*
+		 * haswell doesn't support scaling at all.
+		 *
 		 * gen9 pipe C has only 1 scaler shared with the crtc, which
 		 * means pipe scaling can't work simultaneously with panel
 		 * fitting.
 		 */
-		if (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C)
+		if (IS_HASWELL(intel_get_drm_devid(display->drm_fd)) ||
+		    (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C))
 			igt_plane_set_size(d->plane2, d->fb2.width-200, d->fb2.height-200);
 
 		/* enable panel fitting along with sprite scaling */
-- 
2.17.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_panel_fitting: Do not use scaling on haswell.

[Patchwork]

== Series Details ==

Series: tests/kms_panel_fitting: Do not use scaling on haswell.
URL   : https://patchwork.freedesktop.org/series/43673/
State : failure

== Summary ==

Applying: tests/kms_panel_fitting: Do not use scaling on haswell.
Using index info to reconstruct a base tree...
M	tests/kms_panel_fitting.c
Falling back to patching base and 3-way merge...
Auto-merging tests/kms_panel_fitting.c
CONFLICT (content): Merge conflict in tests/kms_panel_fitting.c
Patch failed at 0001 tests/kms_panel_fitting: Do not use scaling on haswell.
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_panel_fitting: Do not use scaling on haswell.

[Patchwork]

== Series Details ==

Series: tests/kms_panel_fitting: Do not use scaling on haswell.
URL   : https://patchwork.freedesktop.org/series/43673/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4227 -> IGTPW_1391 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/43673/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1391 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-hsw-4770:        FAIL (fdo#100368) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927


== Participating hosts (44 -> 38) ==

  Missing    (6): fi-ilk-m540 fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4495 -> IGTPW_1391
    * Piglit: piglit_4495 -> piglit_4497

  CI_DRM_4227: a8727d3fe03770e4d523468dfbc487dfe01597d3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1391: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1391/
  IGT_4495: 71c7a5740913d2618f44bca252669efe8a84f4c9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4495: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
  piglit_4497: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1391/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Do not use scaling on haswell.

[Ville Syrjälä]

On Thu, May 24, 2018 at 09:03:44AM +0200, Maarten Lankhorst wrote:
> Haswell doesn't support scaling the sprite planes,

HSW/BDW/VLV/CHV

> so we fail with
> -ERANGE. Do the same as we do for gen9 pipe C, and do not attempt
> to scale the sprite plane. It will fail, and the kernel will no
> hide the failure from us.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106606
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_panel_fitting.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 5dce101003c5..eacc6bc0bc11 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -134,11 +134,14 @@ static void test_panel_fitting(data_t *d)
>  		igt_display_commit2(display, COMMIT_UNIVERSAL);
>  
>  		/*
> +		 * haswell doesn't support scaling at all.
> +		 *
>  		 * gen9 pipe C has only 1 scaler shared with the crtc, which
>  		 * means pipe scaling can't work simultaneously with panel
>  		 * fitting.
>  		 */
> -		if (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C)
> +		if (IS_HASWELL(intel_get_drm_devid(display->drm_fd)) ||
> +		    (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C))
>  			igt_plane_set_size(d->plane2, d->fb2.width-200, d->fb2.height-200);
>  
>  		/* enable panel fitting along with sprite scaling */
> -- 
> 2.17.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Do not use scaling on haswell.

[Maarten Lankhorst]

Op 24-05-18 om 12:40 schreef Ville Syrjälä:
> On Thu, May 24, 2018 at 09:03:44AM +0200, Maarten Lankhorst wrote:
>> Haswell doesn't support scaling the sprite planes,
> HSW/BDW/VLV/CHV
Oh right, read it wrong in intel_sprite.c

Just blacklist gen7 != IVB && gen8?
>> so we fail with
>> -ERANGE. Do the same as we do for gen9 pipe C, and do not attempt
>> to scale the sprite plane. It will fail, and the kernel will no
>> hide the failure from us.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106606
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>  tests/kms_panel_fitting.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>> index 5dce101003c5..eacc6bc0bc11 100644
>> --- a/tests/kms_panel_fitting.c
>> +++ b/tests/kms_panel_fitting.c
>> @@ -134,11 +134,14 @@ static void test_panel_fitting(data_t *d)
>>  		igt_display_commit2(display, COMMIT_UNIVERSAL);
>>  
>>  		/*
>> +		 * haswell doesn't support scaling at all.
>> +		 *
>>  		 * gen9 pipe C has only 1 scaler shared with the crtc, which
>>  		 * means pipe scaling can't work simultaneously with panel
>>  		 * fitting.
>>  		 */
>> -		if (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C)
>> +		if (IS_HASWELL(intel_get_drm_devid(display->drm_fd)) ||
>> +		    (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C))
>>  			igt_plane_set_size(d->plane2, d->fb2.width-200, d->fb2.height-200);
>>  
>>  		/* enable panel fitting along with sprite scaling */
>> -- 
>> 2.17.0
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_panel_fitting: Do not use scaling on haswell.

[Ville Syrjälä]

On Thu, May 24, 2018 at 12:50:27PM +0200, Maarten Lankhorst wrote:
> Op 24-05-18 om 12:40 schreef Ville Syrjälä:
> > On Thu, May 24, 2018 at 09:03:44AM +0200, Maarten Lankhorst wrote:
> >> Haswell doesn't support scaling the sprite planes,
> > HSW/BDW/VLV/CHV
> Oh right, read it wrong in intel_sprite.c
> 
> Just blacklist gen7 != IVB && gen8?

Whatever works I guess.

> >> so we fail with
> >> -ERANGE. Do the same as we do for gen9 pipe C, and do not attempt
> >> to scale the sprite plane. It will fail, and the kernel will no
> >> hide the failure from us.
> >>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106606
> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >> ---
> >>  tests/kms_panel_fitting.c | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> >> index 5dce101003c5..eacc6bc0bc11 100644
> >> --- a/tests/kms_panel_fitting.c
> >> +++ b/tests/kms_panel_fitting.c
> >> @@ -134,11 +134,14 @@ static void test_panel_fitting(data_t *d)
> >>  		igt_display_commit2(display, COMMIT_UNIVERSAL);
> >>  
> >>  		/*
> >> +		 * haswell doesn't support scaling at all.
> >> +		 *
> >>  		 * gen9 pipe C has only 1 scaler shared with the crtc, which
> >>  		 * means pipe scaling can't work simultaneously with panel
> >>  		 * fitting.
> >>  		 */
> >> -		if (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C)
> >> +		if (IS_HASWELL(intel_get_drm_devid(display->drm_fd)) ||
> >> +		    (intel_gen(intel_get_drm_devid(display->drm_fd)) == 9 && pipe == PIPE_C))
> >>  			igt_plane_set_size(d->plane2, d->fb2.width-200, d->fb2.height-200);
> >>  
> >>  		/* enable panel fitting along with sprite scaling */
> >> -- 
> >> 2.17.0
> >>
> >> _______________________________________________
> >> igt-dev mailing list
> >> igt-dev@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_panel_fitting: Do not use scaling on haswell.

[Patchwork]

== Series Details ==

Series: tests/kms_panel_fitting: Do not use scaling on haswell.
URL   : https://patchwork.freedesktop.org/series/43673/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4495_full -> IGTPW_1391_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1391_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1391_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/43673/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1391_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-blt:
      shard-kbl:          PASS -> SKIP

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          SKIP -> PASS +1

    
== Known issues ==

  Here are the changes found in IGTPW_1391_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      shard-kbl:          NOTRUN -> DMESG-FAIL (fdo#106560)

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#102887)

    igt@kms_flip@dpms-vs-vblank-race:
      shard-apl:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-hsw:          PASS -> FAIL (fdo#103060)
      shard-glk:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368) +2

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#104724) +1

    igt@kms_rotation_crc@cursor-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925, fdo#104724)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-apl:          PASS -> FAIL (fdo#103925, fdo#104724)

    igt@testdisplay:
      shard-glk:          PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_gtt:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS
      shard-glk:          FAIL -> PASS

    igt@drv_selftest@live_hangcheck:
      shard-apl:          DMESG-FAIL (fdo#106560) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#106023, fdo#103665) -> PASS

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
      shard-glk:          FAIL (fdo#105703) -> PASS

    {igt@kms_available_modes_crc@available_mode_test_crc}:
      shard-snb:          FAIL (fdo#106641) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#102887) -> PASS +1

    igt@kms_flip@plain-flip-ts-check:
      shard-hsw:          FAIL (fdo#100368) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4495 -> IGTPW_1391
    * Linux: CI_DRM_4225 -> CI_DRM_4227
    * Piglit: piglit_4495 -> piglit_4497

  CI_DRM_4225: 88ca72d89921db7a46dfb1492e2059e04a7b6c5e @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4227: a8727d3fe03770e4d523468dfbc487dfe01597d3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1391: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1391/
  IGT_4495: 71c7a5740913d2618f44bca252669efe8a84f4c9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4495: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
  piglit_4497: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1391/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev