* [igt-dev] [PATCH i-g-t] lib/rendercopy: Use gen8_wm_kernel__affine
@ 2018-07-03 15:41 Chris Wilson
2018-07-03 16:04 ` [igt-dev] [Intel-gfx] " Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-07-03 15:41 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
The shaders/blit.g7a has weird artefacts (random pixel kill) when
drawing with to an odd destination coordinate. Rather than debug the
issue with the assembler, replace the kernel with the one used by SNA
for simple copies.
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/rendercopy_gen8.c | 10 ++++------
lib/rendercopy_gen9.c | 10 ++++------
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
index 2b5d9b52e..2e590e391 100644
--- a/lib/rendercopy_gen8.c
+++ b/lib/rendercopy_gen8.c
@@ -51,12 +51,10 @@ struct {
/* see shaders/ps/blit.g7a */
static const uint32_t ps_kernel[][4] = {
#if 1
- { 0x0060005a, 0x21403ae8, 0x3a0000c0, 0x008d0040 },
- { 0x0060005a, 0x21603ae8, 0x3a0000c0, 0x008d0080 },
- { 0x0060005a, 0x21803ae8, 0x3a0000d0, 0x008d0040 },
- { 0x0060005a, 0x21a03ae8, 0x3a0000d0, 0x008d0080 },
- { 0x02800031, 0x2e0022e8, 0x0e000140, 0x08840001 },
- { 0x05800031, 0x200022e0, 0x0e000e00, 0x90031000 },
+ { 0x0080005a, 0x2f403ae8, 0x3a0000c0, 0x008d0040 },
+ { 0x0080005a, 0x2f803ae8, 0x3a0000d0, 0x008d0040 },
+ { 0x02800031, 0x2e203a48, 0x0e8d0f40, 0x08840001 },
+ { 0x05800031, 0x20003a40, 0x0e8d0e20, 0x90031000 },
#else
/* Write all -1 */
{ 0x00600001, 0x2e000608, 0x00000000, 0x3f800000 },
diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index 0157ced9c..79e312409 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -52,12 +52,10 @@ struct {
/* see shaders/ps/blit.g7a */
static const uint32_t ps_kernel[][4] = {
#if 1
- { 0x0060005a, 0x21403ae8, 0x3a0000c0, 0x008d0040 },
- { 0x0060005a, 0x21603ae8, 0x3a0000c0, 0x008d0080 },
- { 0x0060005a, 0x21803ae8, 0x3a0000d0, 0x008d0040 },
- { 0x0060005a, 0x21a03ae8, 0x3a0000d0, 0x008d0080 },
- { 0x02800031, 0x2e0022e8, 0x0e000140, 0x08840001 },
- { 0x05800031, 0x200022e0, 0x0e000e00, 0x90031000 },
+ { 0x0080005a, 0x2f403ae8, 0x3a0000c0, 0x008d0040 },
+ { 0x0080005a, 0x2f803ae8, 0x3a0000d0, 0x008d0040 },
+ { 0x02800031, 0x2e203a48, 0x0e8d0f40, 0x08840001 },
+ { 0x05800031, 0x20003a40, 0x0e8d0e20, 0x90031000 },
#else
/* Write all -1 */
{ 0x00600001, 0x2e000608, 0x00000000, 0x3f800000 },
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] lib/rendercopy: Use gen8_wm_kernel__affine
2018-07-03 15:41 [igt-dev] [PATCH i-g-t] lib/rendercopy: Use gen8_wm_kernel__affine Chris Wilson
@ 2018-07-03 16:04 ` Ville Syrjälä
2018-07-03 16:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-04 1:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2018-07-03 16:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Jul 03, 2018 at 04:41:35PM +0100, Chris Wilson wrote:
> The shaders/blit.g7a has weird artefacts (random pixel kill) when
> drawing with to an odd destination coordinate. Rather than debug the
> issue with the assembler, replace the kernel with the one used by SNA
> for simple copies.
>
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Yep, works on my chv and skl.
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
I can see the obvious pln(8) -> pln(16) change from the hex, but
didn't bother reading through the assembly to try and figure out
what the rest of the differences amount to. So I'll just toss in
an ack.
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/rendercopy_gen8.c | 10 ++++------
> lib/rendercopy_gen9.c | 10 ++++------
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
> index 2b5d9b52e..2e590e391 100644
> --- a/lib/rendercopy_gen8.c
> +++ b/lib/rendercopy_gen8.c
> @@ -51,12 +51,10 @@ struct {
> /* see shaders/ps/blit.g7a */
> static const uint32_t ps_kernel[][4] = {
> #if 1
> - { 0x0060005a, 0x21403ae8, 0x3a0000c0, 0x008d0040 },
> - { 0x0060005a, 0x21603ae8, 0x3a0000c0, 0x008d0080 },
> - { 0x0060005a, 0x21803ae8, 0x3a0000d0, 0x008d0040 },
> - { 0x0060005a, 0x21a03ae8, 0x3a0000d0, 0x008d0080 },
> - { 0x02800031, 0x2e0022e8, 0x0e000140, 0x08840001 },
> - { 0x05800031, 0x200022e0, 0x0e000e00, 0x90031000 },
> + { 0x0080005a, 0x2f403ae8, 0x3a0000c0, 0x008d0040 },
> + { 0x0080005a, 0x2f803ae8, 0x3a0000d0, 0x008d0040 },
> + { 0x02800031, 0x2e203a48, 0x0e8d0f40, 0x08840001 },
> + { 0x05800031, 0x20003a40, 0x0e8d0e20, 0x90031000 },
> #else
> /* Write all -1 */
> { 0x00600001, 0x2e000608, 0x00000000, 0x3f800000 },
> diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> index 0157ced9c..79e312409 100644
> --- a/lib/rendercopy_gen9.c
> +++ b/lib/rendercopy_gen9.c
> @@ -52,12 +52,10 @@ struct {
> /* see shaders/ps/blit.g7a */
> static const uint32_t ps_kernel[][4] = {
> #if 1
> - { 0x0060005a, 0x21403ae8, 0x3a0000c0, 0x008d0040 },
> - { 0x0060005a, 0x21603ae8, 0x3a0000c0, 0x008d0080 },
> - { 0x0060005a, 0x21803ae8, 0x3a0000d0, 0x008d0040 },
> - { 0x0060005a, 0x21a03ae8, 0x3a0000d0, 0x008d0080 },
> - { 0x02800031, 0x2e0022e8, 0x0e000140, 0x08840001 },
> - { 0x05800031, 0x200022e0, 0x0e000e00, 0x90031000 },
> + { 0x0080005a, 0x2f403ae8, 0x3a0000c0, 0x008d0040 },
> + { 0x0080005a, 0x2f803ae8, 0x3a0000d0, 0x008d0040 },
> + { 0x02800031, 0x2e203a48, 0x0e8d0f40, 0x08840001 },
> + { 0x05800031, 0x20003a40, 0x0e8d0e20, 0x90031000 },
> #else
> /* Write all -1 */
> { 0x00600001, 0x2e000608, 0x00000000, 0x3f800000 },
> --
> 2.18.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/rendercopy: Use gen8_wm_kernel__affine
2018-07-03 15:41 [igt-dev] [PATCH i-g-t] lib/rendercopy: Use gen8_wm_kernel__affine Chris Wilson
2018-07-03 16:04 ` [igt-dev] [Intel-gfx] " Ville Syrjälä
@ 2018-07-03 16:11 ` Patchwork
2018-07-04 1:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-03 16:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib/rendercopy: Use gen8_wm_kernel__affine
URL : https://patchwork.freedesktop.org/series/45846/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4420 -> IGTPW_1527 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1527 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1527, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/45846/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1527:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: SKIP -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
{fi-cfl-8109u}: SKIP -> PASS +36
== Known issues ==
Here are the changes found in IGTPW_1527 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-no-display:
{fi-skl-iommu}: NOTRUN -> FAIL (fdo#106066) +2
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
{fi-skl-iommu}: NOTRUN -> FAIL (fdo#106686) +2
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#106066 https://bugs.freedesktop.org/show_bug.cgi?id=106066
fdo#106686 https://bugs.freedesktop.org/show_bug.cgi?id=106686
== Participating hosts (44 -> 41) ==
Additional (2): fi-glk-j4005 fi-skl-iommu
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4532 -> IGTPW_1527
CI_DRM_4420: d9596d1a02b553958c684ef2ea0d3e64e8f68efe @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1527: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1527/
IGT_4532: 840d12e2f050b784552197403d6575a57b6e896d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1527/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib/rendercopy: Use gen8_wm_kernel__affine
2018-07-03 15:41 [igt-dev] [PATCH i-g-t] lib/rendercopy: Use gen8_wm_kernel__affine Chris Wilson
2018-07-03 16:04 ` [igt-dev] [Intel-gfx] " Ville Syrjälä
2018-07-03 16:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-04 1:52 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-07-04 1:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib/rendercopy: Use gen8_wm_kernel__affine
URL : https://patchwork.freedesktop.org/series/45846/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4532_full -> IGTPW_1527_full =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1527_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1527_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/45846/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1527_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_cursor_legacy@all-pipes-torture-bo:
shard-apl: PASS -> DMESG-WARN
shard-snb: PASS -> DMESG-WARN
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-ctx-render:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1527_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-kbl: PASS -> FAIL (fdo#105347)
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@gem_ctx_switch@basic-all-light:
shard-hsw: PASS -> INCOMPLETE (fdo#103540)
igt@gem_exec_schedule@independent-render:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#105454, fdo#106509)
igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled:
shard-glk: PASS -> FAIL (fdo#104724)
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925, fdo#104724)
igt@pm_rpm@legacy-planes:
shard-kbl: NOTRUN -> FAIL (fdo#106539)
==== Possible fixes ====
igt@gem_exec_big:
shard-hsw: INCOMPLETE (fdo#103540) -> PASS
igt@gem_tiled_fence_blits@normal:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@gem_workarounds@suspend-resume-context:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS +1
igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_flip_tiling@flip-to-y-tiled:
shard-glk: FAIL (fdo#104724) -> PASS +1
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#103925, fdo#104724) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106539 https://bugs.freedesktop.org/show_bug.cgi?id=106539
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4532 -> IGTPW_1527
* Linux: CI_DRM_4404 -> CI_DRM_4420
CI_DRM_4404: ceaab659002c938f1788b7458d5081fadc3c1ddc @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4420: d9596d1a02b553958c684ef2ea0d3e64e8f68efe @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1527: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1527/
IGT_4532: 840d12e2f050b784552197403d6575a57b6e896d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1527/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-04 1:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 15:41 [igt-dev] [PATCH i-g-t] lib/rendercopy: Use gen8_wm_kernel__affine Chris Wilson
2018-07-03 16:04 ` [igt-dev] [Intel-gfx] " Ville Syrjälä
2018-07-03 16:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-04 1:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox