From: Deepak Rawat <drawat@vmware.com>
To: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-graphics-maintainer@vmware.com, thellstrom@vmware.com,
syeh@vmware.com
Cc: Deepak Rawat <drawat@vmware.com>
Subject: [Intel-gfx] [PATCH i-g-t 3/5] tests/kms: Don't check crtc state for vmwgfx legacy set_crtc
Date: Wed, 5 Sep 2018 17:03:48 -0700 [thread overview]
Message-ID: <20180906000350.2478-4-drawat@vmware.com> (raw)
In-Reply-To: <20180906000350.2478-1-drawat@vmware.com>
For a Xorg bug vmwgfx has a kernel workaround which reset the value of
mode::type. This will cause crtc state not to match what is expected.
Signed-off-by: Deepak Rawat <drawat@vmware.com>
---
tests/kms_atomic.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index ac02baf0..72714e12 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -237,7 +237,12 @@ static void crtc_commit(igt_pipe_t *pipe, igt_plane_t *plane,
{
igt_display_commit2(pipe->display, s);
- crtc_check_current_state(pipe, pipe->values, plane->values, relax);
+ /*
+ * For a vmwgfx xorg driver bug kernel module reset the value of
+ * mode::type so crtc state check fails for legacy commit
+ */
+ if (!is_vmwgfx_device(pipe->display->drm_fd) || !(s == COMMIT_LEGACY))
+ crtc_check_current_state(pipe, pipe->values, plane->values, relax);
plane_check_current_state(plane, plane->values, relax);
}
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-06 0:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 0:03 [igt-dev] [PATCH i-g-t 0/5] vmwgfx as a new driver for igt-gpu-tools Deepak Rawat
2018-09-06 0:03 ` [igt-dev] [PATCH i-g-t 1/5] lib/igt_vmwgfx: Add vmwgfx device Deepak Rawat
2018-09-06 8:42 ` Petri Latvala
2018-09-06 10:54 ` [igt-dev] [Intel-gfx] " Jani Nikula
2018-09-06 0:03 ` [igt-dev] [PATCH i-g-t 2/5] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers Deepak Rawat
2018-09-06 8:49 ` Chris Wilson
2018-09-06 0:03 ` Deepak Rawat [this message]
2018-09-06 8:54 ` [Intel-gfx] [igt-dev] [PATCH i-g-t 3/5] tests/kms: Don't check crtc state for vmwgfx legacy set_crtc Chris Wilson
2018-09-06 0:03 ` [igt-dev] [PATCH i-g-t 4/5] lib/igt_fb: Check for stride before creating cairo surface Deepak Rawat
2018-09-06 8:58 ` [igt-dev] [Intel-gfx] " Chris Wilson
2018-09-06 22:24 ` Deepak Singh Rawat
2018-09-06 0:03 ` [PATCH i-g-t 5/5] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Deepak Rawat
2018-09-06 10:10 ` [igt-dev] ✓ Fi.CI.BAT: success for vmwgfx as a new driver for igt-gpu-tools Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906000350.2478-4-drawat@vmware.com \
--to=drawat@vmware.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=syeh@vmware.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox