Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/5] lib/igt_vmwgfx: Add vmwgfx device

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 06 Sep 2018, Petri Latvala <petri.latvala@intel.com> wrote:
> On Wed, Sep 05, 2018 at 05:03:46PM -0700, Deepak Rawat wrote:
>> Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests.
>> 
>> Signed-off-by: Deepak Rawat <drawat@vmware.com>
>> ---
>>  lib/drmtest.c | 9 ++++++++-
>>  lib/drmtest.h | 3 +++
>>  2 files changed, 11 insertions(+), 1 deletion(-)
>> 
>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>> index bfa2e0f0..563d5b8b 100644
>> --- a/lib/drmtest.c
>> +++ b/lib/drmtest.c
>> @@ -105,6 +105,11 @@ bool is_i915_device(int fd)
>>  	return __is_device(fd, "i915");
>>  }
>>  
>> +bool is_vmwgfx_device(int fd)
>> +{
>> +	return __is_device(fd, "vmwg");
>> +}
>> +
>>  static bool has_known_intel_chipset(int fd)
>>  {
>>  	struct drm_i915_getparam gp;
>> @@ -205,7 +210,7 @@ static const struct module {
>>  	{ DRIVER_VC4, "vc4" },
>>  	{ DRIVER_VGEM, "vgem" },
>>  	{ DRIVER_VIRTIO, "virtio-gpu" },
>> -	{ DRIVER_VIRTIO, "virtio_gpu" },
>> +	{ DRIVER_VMWGFX, "vmwgfx" },
>>  	{}
>
>
> Don't remove the second virtio-gpu line, there's a reason for it.
>
> .... we should probably add a comment there.

Don't keep us in suspense!

Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev