From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com
Subject: [igt-dev] [RESEND, v3 1/5] kms_plane: Remove redundant modeset after CRC capture
Date: Thu, 6 Sep 2018 10:23:56 +0300 [thread overview]
Message-ID: <20180906072400.7963-2-gwan-gyeong.mun@intel.com> (raw)
In-Reply-To: <20180906072400.7963-1-gwan-gyeong.mun@intel.com>
From: Imre Deak <imre.deak@intel.com>
The null modeset after capturing the CRC is redundant; detaching the FB
from the plane is enough for the next modeset to work properly. This
speed things up especially on slow panels.
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/kms_plane.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 3999dde8..aceae591 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -88,7 +88,6 @@ test_grab_crc(data_t *data, igt_output_t *output, enum pipe pipe,
igt_pipe_crc_collect_crc(data->pipe_crc, crc);
igt_plane_set_fb(primary, NULL);
- igt_display_commit(&data->display);
igt_remove_fb(data->drm_fd, &fb);
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-06 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 7:23 [igt-dev] [RESEND,v3 0/5] kms_plane: Add clipping subtests Gwan-gyeong Mun
2018-09-06 7:23 ` Gwan-gyeong Mun [this message]
2018-09-06 7:23 ` [igt-dev] [RESEND, v3 2/5] lib: Export helpers to get rotation/tiling strings Gwan-gyeong Mun
2018-09-06 7:23 ` [igt-dev] [RESEND, v3 3/5] kms_plane: Split helpers creating reference FB and capturing CRC Gwan-gyeong Mun
2018-09-06 7:23 ` [igt-dev] [RESEND, v3 4/5] kms_plane: Add a helper of capturing CRC with commit style Gwan-gyeong Mun
2018-09-06 7:24 ` [igt-dev] [RESEND,v3 5/5] kms_plane: Add clipping subtests Gwan-gyeong Mun
2018-09-07 10:48 ` Imre Deak
2018-09-07 15:18 ` Mun, Gwan-gyeong
2018-09-10 14:05 ` Imre Deak
2018-09-06 8:28 ` [igt-dev] ✗ Fi.CI.BAT: failure for kms_plane: Add clipping subtests (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906072400.7963-2-gwan-gyeong.mun@intel.com \
--to=gwan-gyeong.mun@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox