From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com
Subject: [igt-dev] [RESEND, v3 4/5] kms_plane: Add a helper of capturing CRC with commit style
Date: Thu, 6 Sep 2018 10:23:59 +0300 [thread overview]
Message-ID: <20180906072400.7963-5-gwan-gyeong.mun@intel.com> (raw)
In-Reply-To: <20180906072400.7963-1-gwan-gyeong.mun@intel.com>
As a legacy style commit does not allow changing of primary plane rotation
on non-first commit, it adds a helper of capturing CRC with commit style
argument for testing of primary plane rotation.
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
tests/kms_plane.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 3f48c821..3d08893f 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -61,8 +61,9 @@ static void test_fini(data_t *data)
}
static void
-test_grab_crc_for_fb(data_t *data, igt_output_t *output, enum pipe pipe,
- igt_fb_t *fb, igt_crc_t *crc /* out */)
+test_grab_crc_for_fb2(data_t *data, igt_output_t *output, enum pipe pipe,
+ igt_fb_t *fb, igt_crc_t *crc /* out */,
+ enum igt_commit_style s)
{
igt_plane_t *primary;
char *crc_str;
@@ -74,7 +75,8 @@ test_grab_crc_for_fb(data_t *data, igt_output_t *output, enum pipe pipe,
igt_plane_set_fb(primary, fb);
- ret = igt_display_try_commit2(&data->display, COMMIT_LEGACY);
+ ret = igt_display_try_commit2(&data->display, s);
+
igt_skip_on(ret != 0);
igt_pipe_crc_collect_crc(data->pipe_crc, crc);
@@ -86,6 +88,13 @@ test_grab_crc_for_fb(data_t *data, igt_output_t *output, enum pipe pipe,
free(crc_str);
}
+static void
+test_grab_crc_for_fb(data_t *data, igt_output_t *output, enum pipe pipe,
+ igt_fb_t *fb, igt_crc_t *crc /* out */)
+{
+ test_grab_crc_for_fb2(data, output, pipe, fb, crc, COMMIT_LEGACY);
+}
+
static void
test_create_fb_for_output(data_t *data, igt_output_t *output, color_t *fb_color,
igt_fb_t *fb)
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-06 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 7:23 [igt-dev] [RESEND,v3 0/5] kms_plane: Add clipping subtests Gwan-gyeong Mun
2018-09-06 7:23 ` [igt-dev] [RESEND, v3 1/5] kms_plane: Remove redundant modeset after CRC capture Gwan-gyeong Mun
2018-09-06 7:23 ` [igt-dev] [RESEND, v3 2/5] lib: Export helpers to get rotation/tiling strings Gwan-gyeong Mun
2018-09-06 7:23 ` [igt-dev] [RESEND, v3 3/5] kms_plane: Split helpers creating reference FB and capturing CRC Gwan-gyeong Mun
2018-09-06 7:23 ` Gwan-gyeong Mun [this message]
2018-09-06 7:24 ` [igt-dev] [RESEND,v3 5/5] kms_plane: Add clipping subtests Gwan-gyeong Mun
2018-09-07 10:48 ` Imre Deak
2018-09-07 15:18 ` Mun, Gwan-gyeong
2018-09-10 14:05 ` Imre Deak
2018-09-06 8:28 ` [igt-dev] ✗ Fi.CI.BAT: failure for kms_plane: Add clipping subtests (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906072400.7963-5-gwan-gyeong.mun@intel.com \
--to=gwan-gyeong.mun@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox