[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

Add a warning to update test if GEN version is not recognized.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_ctx_isolation.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
index 4325e1c2..bd07b141 100644
--- a/tests/gem_ctx_isolation.c
+++ b/tests/gem_ctx_isolation.c
@@ -700,7 +700,9 @@ igt_main
 		igt_require(has_context_isolation);
 
 		gen = intel_gen(intel_get_drm_devid(fd));
-		//igt_ci_fail_on(gen > LAST_KNOWN_GEN);
+
+		igt_warn_on_f(gen > LAST_KNOWN_GEN,
+				"GEN not recognized! Test needs to be updated to run.");
 		igt_skip_on(gen > LAST_KNOWN_GEN);
 	}
 
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Chris Wilson]

Quoting Antonio Argenziano (2018-09-06 20:59:57)
> Add a warning to update test if GEN version is not recognized.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/gem_ctx_isolation.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
> index 4325e1c2..bd07b141 100644
> --- a/tests/gem_ctx_isolation.c
> +++ b/tests/gem_ctx_isolation.c
> @@ -700,7 +700,9 @@ igt_main
>                 igt_require(has_context_isolation);
>  
>                 gen = intel_gen(intel_get_drm_devid(fd));
> -               //igt_ci_fail_on(gen > LAST_KNOWN_GEN);
> +
> +               igt_warn_on_f(gen > LAST_KNOWN_GEN,
> +                               "GEN not recognized! Test needs to be updated to run.");
>                 igt_skip_on(gen > LAST_KNOWN_GEN);

Unquestionably an improvement,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Remember to :set cino=:0,(0 though, i.e. continuation lines should be
indented to the bracket.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

On 06/09/18 13:03, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-09-06 20:59:57)
>> Add a warning to update test if GEN version is not recognized.
>>
>> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>>   tests/gem_ctx_isolation.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
>> index 4325e1c2..bd07b141 100644
>> --- a/tests/gem_ctx_isolation.c
>> +++ b/tests/gem_ctx_isolation.c
>> @@ -700,7 +700,9 @@ igt_main
>>                  igt_require(has_context_isolation);
>>   
>>                  gen = intel_gen(intel_get_drm_devid(fd));
>> -               //igt_ci_fail_on(gen > LAST_KNOWN_GEN);
>> +
>> +               igt_warn_on_f(gen > LAST_KNOWN_GEN,
>> +                               "GEN not recognized! Test needs to be updated to run.");
>>                  igt_skip_on(gen > LAST_KNOWN_GEN);
> 
> Unquestionably an improvement,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Remember to :set cino=:0,(0 though, i.e. continuation lines should be
> indented to the bracket.

Thanks, I'll change it when pushing,

Antonio

> -Chris
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

Add a warning to update test if GEN version is not recognized.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_ctx_isolation.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
index 4325e1c2..bd07b141 100644
--- a/tests/gem_ctx_isolation.c
+++ b/tests/gem_ctx_isolation.c
@@ -700,7 +700,9 @@ igt_main
 		igt_require(has_context_isolation);
 
 		gen = intel_gen(intel_get_drm_devid(fd));
-		//igt_ci_fail_on(gen > LAST_KNOWN_GEN);
+
+		igt_warn_on_f(gen > LAST_KNOWN_GEN,
+				"GEN not recognized! Test needs to be updated to run.");
 		igt_skip_on(gen > LAST_KNOWN_GEN);
 	}
 
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

Ops, sorry wrong button.

Please ignore this.

Sorry,
Antonio

On 24/09/18 09:38, Antonio Argenziano wrote:
> Add a warning to update test if GEN version is not recognized.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/gem_ctx_isolation.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
> index 4325e1c2..bd07b141 100644
> --- a/tests/gem_ctx_isolation.c
> +++ b/tests/gem_ctx_isolation.c
> @@ -700,7 +700,9 @@ igt_main
>   		igt_require(has_context_isolation);
>   
>   		gen = intel_gen(intel_get_drm_devid(fd));
> -		//igt_ci_fail_on(gen > LAST_KNOWN_GEN);
> +
> +		igt_warn_on_f(gen > LAST_KNOWN_GEN,
> +				"GEN not recognized! Test needs to be updated to run.");
>   		igt_skip_on(gen > LAST_KNOWN_GEN);
>   	}
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/gem_ctx_isoation: Add warn for newer gens. (rev2)

[Patchwork]

== Series Details ==

Series: tests/gem_ctx_isoation: Add warn for newer gens. (rev2)
URL   : https://patchwork.freedesktop.org/series/49296/
State : failure

== Summary ==

Applying: tests/gem_ctx_isoation: Add warn for newer gens.
Using index info to reconstruct a base tree...
M	tests/gem_ctx_isolation.c
Falling back to patching base and 3-way merge...
Auto-merging tests/gem_ctx_isolation.c
CONFLICT (content): Merge conflict in tests/gem_ctx_isolation.c
Patch failed at 0001 tests/gem_ctx_isoation: Add warn for newer gens.
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev