[igt-dev] [RFC] igt/debugfs_test: Increase timeout for long open debugfs.

[igt-dev] [RFC] igt/debugfs_test: Increase timeout for long open debugfs.

[Antonio Argenziano]

While most debugFS's open is quick, guc_log_dump, when guc is loaded,
might take a long time. Increase the timeout for such debugFSs.

Sending this as an RFC because I am not sure it will apply to more debugfs or
if it would be best to just move the guc_* files into another subtest.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
---
 tests/debugfs_test.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
index 2e87e442..5dfa4118 100644
--- a/tests/debugfs_test.c
+++ b/tests/debugfs_test.c
@@ -27,6 +27,23 @@
 #include <sys/types.h>
 #include <dirent.h>
 
+static bool is_long_open(const char *name)
+{
+	/* White list debugFSs that take a longer time to open. */
+	const char* slow_debugfs[] = {
+				"i915_guc_log_dump",
+				NULL
+	};
+	bool found = false;
+	int i = 0;
+
+	while (!found && slow_debugfs[i])	{
+		found = !!strncmp(name, slow_debugfs[i], sizeof(slow_debugfs[i++]));
+	}
+
+	return found;
+}
+
 static void read_and_discard_sysfs_entries(int path_fd, int indent)
 {
 	struct dirent *dirent;
@@ -63,7 +80,8 @@ static void read_and_discard_sysfs_entries(int path_fd, int indent)
 
 			igt_kmsg(KMSG_DEBUG "Reading file \"%s\"\n", dirent->d_name);
 			igt_debug("%sReading file \"%s\"\n", tabs, dirent->d_name);
-			igt_set_timeout(5, "reading sysfs entry");
+
+			igt_set_timeout(5 * (is_long_open(dirent->d_name) ? 10 : 1), "reading sysfs entry");
 
 			sub_fd = openat(path_fd, dirent->d_name, O_RDONLY);
 			if (sub_fd == -1) {
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for igt/debugfs_test: Increase timeout for long open debugfs.

[Patchwork]

== Series Details ==

Series: igt/debugfs_test: Increase timeout for long open debugfs.
URL   : https://patchwork.freedesktop.org/series/50468/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4915 -> IGTPW_1895 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1895 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1895, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50468/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1895:

  === IGT changes ===

    ==== Warnings ====

    igt@drv_selftest@live_guc:
      fi-glk-j4005:       SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1895 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-skl-iommu:       PASS -> TIMEOUT (fdo#108130)
      fi-glk-dsi:         PASS -> TIMEOUT (fdo#108130)
      fi-cfl-s3:          PASS -> TIMEOUT (fdo#108130)
      fi-bdw-gvtdvm:      PASS -> TIMEOUT (fdo#108130)
      fi-skl-6700hq:      PASS -> TIMEOUT (fdo#108130)
      fi-bxt-j4205:       PASS -> TIMEOUT (fdo#108130)
      fi-kbl-7500u:       PASS -> TIMEOUT (fdo#108130)
      fi-bdw-samus:       PASS -> TIMEOUT (fdo#108130)
      fi-snb-2520m:       PASS -> TIMEOUT (fdo#108130)
      fi-cfl-8109u:       PASS -> TIMEOUT (fdo#108130)
      fi-pnv-d510:        PASS -> TIMEOUT (fdo#108130)
      fi-ilk-650:         PASS -> TIMEOUT (fdo#108130)
      fi-ivb-3520m:       PASS -> TIMEOUT (fdo#108130)
      fi-skl-6770hq:      PASS -> TIMEOUT (fdo#108130)
      fi-byt-n2820:       PASS -> TIMEOUT (fdo#108130)
      fi-elk-e7500:       PASS -> TIMEOUT (fdo#108130)
      fi-snb-2600:        PASS -> TIMEOUT (fdo#108130)
      fi-hsw-4770r:       PASS -> TIMEOUT (fdo#108130)
      fi-skl-gvtdvm:      PASS -> TIMEOUT (fdo#108130)
      fi-kbl-guc:         PASS -> TIMEOUT (fdo#108130)
      fi-bsw-kefka:       PASS -> TIMEOUT (fdo#108130)
      fi-kbl-x1275:       PASS -> TIMEOUT (fdo#108130)
      fi-blb-e6850:       PASS -> TIMEOUT (fdo#108130)
      fi-bwr-2160:        PASS -> TIMEOUT (fdo#108130)
      fi-bdw-5557u:       PASS -> TIMEOUT (fdo#108130)
      fi-kbl-r:           PASS -> TIMEOUT (fdo#108130)
      fi-skl-guc:         PASS -> TIMEOUT (fdo#108130)
      fi-kbl-7567u:       PASS -> TIMEOUT (fdo#108130)
      fi-cnl-u:           PASS -> TIMEOUT (fdo#108130)
      fi-glk-j4005:       PASS -> TIMEOUT (fdo#108130)
      fi-byt-clapper:     PASS -> TIMEOUT (fdo#108130)
      fi-kbl-8809g:       PASS -> TIMEOUT (fdo#108130)
      fi-skl-6600u:       PASS -> TIMEOUT (fdo#108130)
      fi-bxt-dsi:         PASS -> TIMEOUT (fdo#108130)
      fi-kbl-7560u:       PASS -> TIMEOUT (fdo#108130)
      fi-cfl-8700k:       PASS -> TIMEOUT (fdo#108130)
      fi-whl-u:           PASS -> TIMEOUT (fdo#108130)
      fi-bsw-n3050:       PASS -> TIMEOUT (fdo#108130)
      fi-skl-6700k2:      PASS -> TIMEOUT (fdo#108130)
      fi-hsw-4770:        PASS -> TIMEOUT (fdo#108130)
      fi-kbl-soraka:      PASS -> TIMEOUT (fdo#108130)

    igt@drv_module_reload@basic-reload:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106725, fdo#106248)

    igt@gem_exec_suspend@basic-s4-devices:
      fi-bdw-samus:       NOTRUN -> INCOMPLETE (fdo#107773)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_execlists:
      fi-glk-j4005:       INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    igt@gem_exec_suspend@basic-s3:
      fi-bdw-samus:       INCOMPLETE (fdo#107773) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-skl-guc:         FAIL (fdo#103191) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
  fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
  fdo#108130 https://bugs.freedesktop.org/show_bug.cgi?id=108130
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (46 -> 41) ==

  Missing    (5): fi-bsw-cyan fi-byt-squawks fi-icl-u2 fi-skl-6260u fi-gdg-551 


== Build changes ==

    * IGT: IGT_4660 -> IGTPW_1895

  CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1895: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1895/
  IGT_4660: d0975646c50568e66e65b44b81d28232d059b94e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1895/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for igt/debugfs_test: Increase timeout for long open debugfs.

[Patchwork]

== Series Details ==

Series: igt/debugfs_test: Increase timeout for long open debugfs.
URL   : https://patchwork.freedesktop.org/series/50468/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4660_full -> IGTPW_1895_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1895_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1895_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50468/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1895_full:

  === IGT changes ===

    ==== Possible regressions ====

    {igt@kms_plane_alpha_blend@pipe-b-alpha-7efc}:
      shard-apl:          SKIP -> FAIL +3

    {igt@kms_plane_alpha_blend@pipe-c-alpha-7efc}:
      shard-kbl:          SKIP -> FAIL +3

    
    ==== Warnings ====

    {igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid}:
      shard-kbl:          SKIP -> PASS +9

    {igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid}:
      shard-apl:          SKIP -> PASS +9

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1895_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      shard-apl:          PASS -> TIMEOUT (fdo#108130) +1
      shard-kbl:          PASS -> TIMEOUT (fdo#108130) +1

    igt@debugfs_test@read_all_entries_display_off:
      shard-hsw:          PASS -> TIMEOUT (fdo#108130) +1

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
      shard-snb:          NOTRUN -> DMESG-WARN (fdo#107956) +2

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
      shard-kbl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
      shard-kbl:          PASS -> FAIL (fdo#108145)

    igt@kms_cursor_crc@cursor-128x42-onscreen:
      shard-apl:          PASS -> FAIL (fdo#103232)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
      shard-apl:          PASS -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-fullscreen:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411)

    {igt@kms_plane_alpha_blend@pipe-b-alpha-basic}:
      shard-apl:          SKIP -> FAIL (fdo#108145) +12

    {igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb}:
      shard-kbl:          SKIP -> FAIL (fdo#108145) +12

    igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
      shard-apl:          PASS -> FAIL (fdo#103166)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          NOTRUN -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    igt@perf_pmu@rc6-runtime-pm:
      shard-kbl:          PASS -> FAIL (fdo#105010)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@bcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS +1

    igt@gem_exec_big:
      shard-hsw:          TIMEOUT (fdo#107937) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
      shard-snb:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108130 https://bugs.freedesktop.org/show_bug.cgi?id=108130
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (6 -> 4) ==

  Missing    (2): shard-skl shard-glk 


== Build changes ==

    * IGT: IGT_4660 -> IGTPW_1895
    * Linux: CI_DRM_4912 -> CI_DRM_4915

  CI_DRM_4912: fde5d8f7153abb900a378cce97a7a6b32576a3fa @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1895: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1895/
  IGT_4660: d0975646c50568e66e65b44b81d28232d059b94e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1895/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [RFC] igt/debugfs_test: Increase timeout for long open debugfs.

[Chris Wilson]

Quoting Antonio Argenziano (2018-10-02 23:29:21)
> While most debugFS's open is quick, guc_log_dump, when guc is loaded,
> might take a long time. Increase the timeout for such debugFSs.

Is there a good clue as to why guc is that slow? We don't have umpteen
gigabytes, so 5s should be enough for even a full log surely...
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev