* [igt-dev] [PATCH i-g-t] lib: Remove incomplete assert from igt_require_fb_modifiers()
@ 2018-10-03 19:56 Chris Wilson
2018-10-03 21:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-04 9:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2018-10-03 19:56 UTC (permalink / raw)
To: igt-dev
Since the igt_assert is far from complete and does not enumerate all the
possible valid values, restrict the function to do only what it says it
will do, check for the required fb modifiers.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/ioctl_wrappers.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 5ad682f5..529eae36 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -1667,7 +1667,6 @@ void igt_require_fb_modifiers(int fd)
int ret;
ret = drmGetCap(fd, DRM_CAP_ADDFB2_MODIFIERS, &cap_modifiers);
- igt_assert(ret == 0 || errno == EINVAL);
has_modifiers = ret == 0 && cap_modifiers == 1;
cap_modifiers_tested = true;
}
--
2.19.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib: Remove incomplete assert from igt_require_fb_modifiers()
2018-10-03 19:56 [igt-dev] [PATCH i-g-t] lib: Remove incomplete assert from igt_require_fb_modifiers() Chris Wilson
@ 2018-10-03 21:01 ` Patchwork
2018-10-04 9:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2018-10-03 21:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib: Remove incomplete assert from igt_require_fb_modifiers()
URL : https://patchwork.freedesktop.org/series/50524/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4918 -> IGTPW_1905 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50524/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1905 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106725, fdo#106248)
igt@gem_exec_basic@readonly-bsd:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#105719) +1
igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
fi-glk-j4005: PASS -> FAIL (fdo#106765)
igt@kms_flip@basic-flip-vs-dpms:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: PASS -> FAIL (fdo#100368)
igt@kms_flip@basic-plain-flip:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-icl-u: PASS -> INCOMPLETE (fdo#107713)
igt@pm_rpm@module-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#107726)
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#106765 https://bugs.freedesktop.org/show_bug.cgi?id=106765
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726
== Participating hosts (48 -> 43) ==
Additional (1): fi-cfl-guc
Missing (6): fi-kbl-soraka fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-bdw-samus
== Build changes ==
* IGT: IGT_4662 -> IGTPW_1905
CI_DRM_4918: f595aba3a6e2f6972bb158eb8434b58d22d0e5f0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1905: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1905/
IGT_4662: ebf6a1dd1795e2f014ff3c47fe2eb4d5255845bd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1905/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib: Remove incomplete assert from igt_require_fb_modifiers()
2018-10-03 19:56 [igt-dev] [PATCH i-g-t] lib: Remove incomplete assert from igt_require_fb_modifiers() Chris Wilson
2018-10-03 21:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-04 9:56 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2018-10-04 9:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib: Remove incomplete assert from igt_require_fb_modifiers()
URL : https://patchwork.freedesktop.org/series/50524/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4662_full -> IGTPW_1905_full =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50524/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1905_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-kbl: PASS -> FAIL (fdo#108145)
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-apl: PASS -> FAIL (fdo#103232) +4
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-kbl: PASS -> FAIL (fdo#103232) +3
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-apl: PASS -> FAIL (fdo#103167) +6
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-kbl: PASS -> FAIL (fdo#103167) +2
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: PASS -> FAIL (fdo#103166) +3
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-snb: PASS -> FAIL (fdo#103166)
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-kbl: PASS -> FAIL (fdo#103166) +1
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_color@pipe-a-degamma:
shard-apl: FAIL (fdo#108145) -> PASS
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-kbl: FAIL (fdo#103232, fdo#103191) -> PASS
igt@kms_cursor_crc@cursor-128x42-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS +3
igt@kms_cursor_crc@cursor-64x21-onscreen:
shard-kbl: FAIL (fdo#103232) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
shard-apl: FAIL (fdo#103166) -> PASS +2
igt@pm_rpm@system-suspend-modeset:
shard-kbl: INCOMPLETE (fdo#103665, fdo#107807) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 3) ==
Missing (3): shard-skl shard-glk shard-hsw
== Build changes ==
* IGT: IGT_4662 -> IGTPW_1905
* Linux: CI_DRM_4915 -> CI_DRM_4918
CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4918: f595aba3a6e2f6972bb158eb8434b58d22d0e5f0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1905: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1905/
IGT_4662: ebf6a1dd1795e2f014ff3c47fe2eb4d5255845bd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1905/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-04 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-03 19:56 [igt-dev] [PATCH i-g-t] lib: Remove incomplete assert from igt_require_fb_modifiers() Chris Wilson
2018-10-03 21:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-04 9:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox