public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/4] tests/perf: buffer-fill: drop load helper usage
Date: Wed, 10 Oct 2018 17:57:45 +0100	[thread overview]
Message-ID: <20181010165747.23667-3-lionel.g.landwerlin@intel.com> (raw)
In-Reply-To: <20181010165747.23667-1-lionel.g.landwerlin@intel.com>

It makes the tests more reliable because the expected number of
reports is more acurate (given that we'll have almost no
context-switch reports).

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/perf.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tests/perf.c b/tests/perf.c
index 16c1adb0..36877917 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -2363,9 +2363,6 @@ test_buffer_fill(void)
 	int n_full_oa_reports = oa_buf_size / report_size;
 	uint64_t fill_duration = n_full_oa_reports * oa_period;
 
-	load_helper_init();
-	load_helper_run(HIGH);
-
 	igt_assert(fill_duration < 1000000000);
 
 	stream_fd = __perf_open(drm_fd, &param, true /* prevent_pm */);
@@ -2478,9 +2475,6 @@ test_buffer_fill(void)
 	free(buf);
 
 	__perf_close(stream_fd);
-
-	load_helper_stop();
-	load_helper_fini();
 }
 
 static void
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-10-10 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 16:57 [igt-dev] [PATCH i-g-t 0/4] tests/perf: add support for new oa buffer size parameter Lionel Landwerlin
2018-10-10 16:57 ` [igt-dev] [PATCH i-g-t 1/4] include: bump drm uAPI headers Lionel Landwerlin
2018-10-10 16:57 ` Lionel Landwerlin [this message]
2018-10-10 16:57 ` [igt-dev] [PATCH i-g-t 3/4] tests/perf: rename MAX_OA_BUFFER_SIZE Lionel Landwerlin
2018-10-10 16:57 ` [igt-dev] [PATCH i-g-t 4/4] tests/perf: add new tests for configurable OA buffer size Lionel Landwerlin
2018-10-10 17:12   ` Chris Wilson
2018-10-10 17:38     ` Lionel Landwerlin
2018-10-10 17:50 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf: add support for new oa buffer size parameter Patchwork
2018-10-10 23:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181010165747.23667-3-lionel.g.landwerlin@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox