Re: [igt-dev] [PATCH i-g-t 4/4] tests/perf: add new tests for configurable OA buffer size

[Lionel Landwerlin <lionel.g.landwerlin@intel.com>]

On 10/10/2018 18:12, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-10-10 17:57:47)
>> +       igt_subtest("buffer-fill-sized") {
>> +               size_t size = 128 * 1024; /* Smallest HW supported size. */
>> +               const size_t max_size = DEFAULT_OA_BUF_SIZE;
>> +
>> +               igt_require(kernel_supports_open_option(drm_fd, DRM_I915_PERF_PROP_OA_BUFFER_SIZE, 0));
>> +
>> +               while (size <= max_size) {
>> +                       test_buffer_fill(true, size);
>> +                       size *= 2;
> If you care about the actual bufsz, then report it back? Otherwise it
> would seem to need to be a lot more stringent on validation to only use
> the user requested size.
> -Chris
>
Hmm... Not sure what you mean.

You would prefer to have the kernel report the OA buffer size, through 
device get_param for example?


Thanks,


-

Lionel

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev