From: Daniel Vetter <daniel@ffwll.ch>
To: Deepak Singh Rawat <drawat@vmware.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
Sinclair Yeh <syeh@vmware.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
Pekka Paalanen <ppaalanen@gmail.com>,
linux-graphics-maintainer <linux-graphics-maintainer@vmware.com>
Subject: Re: [Intel-gfx] [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper
Date: Thu, 11 Oct 2018 17:25:59 +0200 [thread overview]
Message-ID: <20181011152559.GE31561@phenom.ffwll.local> (raw)
In-Reply-To: <BYAPR05MB418195CE949ED42641295378BAE10@BYAPR05MB4181.namprd05.prod.outlook.com>
On Thu, Oct 11, 2018 at 03:23:58PM +0000, Deepak Singh Rawat wrote:
> > > diff --git a/tests/meson.build b/tests/meson.build
> > > index 697ff515..5acd7aa2 100644
> > > --- a/tests/meson.build
> > > +++ b/tests/meson.build
> > > @@ -9,6 +9,7 @@ test_progs = [
> > > 'debugfs_test',
> > > 'drm_import_export',
> > > 'drm_mm',
> > > + 'drm_plane_damage',
> >
> > For future proofing I think it'd be much better if we call this drm_kms or
> > similar. The individual subtest results will be all exposed, but there's a
> > bit a problem when we always have to upgrade both igt and the kernel at
> > the same time. At least with the current CI infrastructure.
>
> Do you mean drm_kms_plane_damage? IIUC this is to allow running test
> from run-test.sh? I suppose in that case it should be named
> kms_plane_damage, because all other kms test starts with kms_*.
Ah yes, sticking to the kms_ prefix is a good idea. kms_selftests is what
I'd recommend. For both the igt wrapper here, and the kernel module.
That way it's a natural place to add all kinds of kms self tests in the
future, without the need to go through the basic scaffolding steps again.
Cheers, Daniel
>
> >
> > I'm also asking the ARM folks to type selftests for the new block_* format
> > description stuff, so this will come in handy real soon.
> > -Daniel
> >
> > > 'drm_read',
> > > 'drv_getparams_basic',
> > > 'drv_hangman',
> > > --
> > > 2.17.1
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-11 15:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 0:20 [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Deepak Rawat
2018-10-11 0:21 ` [Intel-gfx] [PATCH i-g-t 2/6] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers Deepak Rawat
2018-10-11 0:21 ` [Intel-gfx] [PATCH i-g-t 3/6] lib/igt_fb: Check for cairo surface success Deepak Rawat
2018-10-11 15:06 ` [igt-dev] " Ville Syrjälä
2018-10-11 15:48 ` Deepak Singh Rawat
2018-10-11 0:21 ` [igt-dev] [PATCH i-g-t 4/6] lib: Don't call igt_require_fb_modifiers() when no modifier Deepak Rawat
2018-10-11 14:51 ` Ville Syrjälä
2018-10-11 15:38 ` Deepak Singh Rawat
2018-10-11 15:48 ` Daniel Vetter
2018-10-11 0:21 ` [Intel-gfx] [PATCH i-g-t 5/6] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Deepak Rawat
2018-10-11 0:21 ` [Intel-gfx] [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper Deepak Rawat
2018-10-11 9:05 ` Daniel Vetter
2018-10-11 15:23 ` Deepak Singh Rawat
2018-10-11 15:25 ` Daniel Vetter [this message]
2018-10-11 9:01 ` [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Daniel Vetter
2018-10-11 9:11 ` Petri Latvala
2018-10-11 9:46 ` Daniel Vetter
2018-10-11 15:17 ` Deepak Singh Rawat
2018-10-11 15:27 ` Daniel Vetter
2018-10-11 15:32 ` Deepak Singh Rawat
2018-10-11 9:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/6] " Patchwork
2018-10-11 14:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011152559.GE31561@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=drawat@vmware.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=ppaalanen@gmail.com \
--cc=syeh@vmware.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox