From: Daniel Vetter <daniel@ffwll.ch>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Martin Peres <martin.peres@linux.intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns
Date: Fri, 12 Oct 2018 15:06:09 +0200 [thread overview]
Message-ID: <20181012130609.GP31561@phenom.ffwll.local> (raw)
In-Reply-To: <20181012102947.32489-1-petri.latvala@intel.com>
On Fri, Oct 12, 2018 at 01:29:47PM +0300, Petri Latvala wrote:
> After setting the result object text, the string retrieved from the
> old object is invalid.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> runner/resultgen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index 9fc54cdc..ed8c9266 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -828,6 +828,7 @@ static void override_result_single(struct json_object *obj)
> if (!strcmp(result, "pass") &&
> count_lines(errtext, errtext + strlen(errtext)) > 2) {
> set_result(obj, "warn");
> + result = "warn";
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Do we have unit tests for the runner that are checked when you do make
check/ninja test?
Would be really nice to have that, since on the piglit side Dylan made
that happen. And if we have that already, we definitely want a unit test
for this stuff here.
-Daniel
> }
>
> if (dmesgwarns) {
> --
> 2.18.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-12 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 10:29 [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns Petri Latvala
2018-10-12 11:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-10-12 12:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-12 13:06 ` Daniel Vetter [this message]
2018-10-12 13:29 ` [igt-dev] [PATCH i-g-t 1/1] " Martin Peres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012130609.GP31561@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@linux.intel.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox