* [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns
@ 2018-10-12 10:29 Petri Latvala
2018-10-12 11:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Petri Latvala @ 2018-10-12 10:29 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala, Martin Peres
After setting the result object text, the string retrieved from the
old object is invalid.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
runner/resultgen.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/runner/resultgen.c b/runner/resultgen.c
index 9fc54cdc..ed8c9266 100644
--- a/runner/resultgen.c
+++ b/runner/resultgen.c
@@ -828,6 +828,7 @@ static void override_result_single(struct json_object *obj)
if (!strcmp(result, "pass") &&
count_lines(errtext, errtext + strlen(errtext)) > 2) {
set_result(obj, "warn");
+ result = "warn";
}
if (dmesgwarns) {
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] runner: Fix results when there's warns and dmesg-warns
2018-10-12 10:29 [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns Petri Latvala
@ 2018-10-12 11:02 ` Patchwork
2018-10-12 12:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-12 13:06 ` [igt-dev] [PATCH i-g-t 1/1] " Daniel Vetter
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-10-12 11:02 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] runner: Fix results when there's warns and dmesg-warns
URL : https://patchwork.freedesktop.org/series/50912/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4973 -> IGTPW_1946 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50912/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1946 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gem:
{fi-apl-guc}: NOTRUN -> INCOMPLETE (fdo#106693)
==== Possible fixes ====
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (43 -> 42) ==
Additional (4): fi-skl-guc fi-icl-u fi-gdg-551 fi-apl-guc
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4673 -> IGTPW_1946
CI_DRM_4973: 60ba18212b324d02e961232953f190612d7a6ca3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1946: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1946/
IGT_4673: 54cb1aeb4e50dea9f3abae632e317875d147c4ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1946/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/1] runner: Fix results when there's warns and dmesg-warns
2018-10-12 10:29 [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns Petri Latvala
2018-10-12 11:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
@ 2018-10-12 12:29 ` Patchwork
2018-10-12 13:06 ` [igt-dev] [PATCH i-g-t 1/1] " Daniel Vetter
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-10-12 12:29 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] runner: Fix results when there's warns and dmesg-warns
URL : https://patchwork.freedesktop.org/series/50912/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4673_full -> IGTPW_1946_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1946_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1946_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50912/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1946_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS
igt@pm_rc6_residency@rc6-accuracy:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1946_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_await@wide-contexts:
shard-glk: PASS -> FAIL (fdo#106680)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_cursor_crc@cursor-128x42-onscreen:
shard-glk: PASS -> FAIL (fdo#103232) +1
shard-apl: PASS -> FAIL (fdo#103232) +1
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: PASS -> FAIL (fdo#103167) +3
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: PASS -> FAIL (fdo#103166)
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-kbl: PASS -> FAIL (fdo#108145)
shard-apl: PASS -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
shard-glk: PASS -> FAIL (fdo#108145) +1
igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
shard-kbl: NOTRUN -> FAIL (fdo#108146)
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166) +2
shard-kbl: PASS -> FAIL (fdo#103166)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@perf_pmu@rc6-runtime-pm-long:
shard-apl: PASS -> FAIL (fdo#105010)
==== Possible fixes ====
igt@gem_exec_basic@readonly-bsd:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@gem_mmap@bad-object:
shard-apl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS
igt@kms_addfb_basic@bo-too-small-due-to-tiling:
shard-snb: DMESG-WARN (fdo#107469) -> PASS +4
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_busy@extended-pageflip-hang-newfb-render-c:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_chv_cursor_fail@pipe-c-128x128-right-edge:
shard-glk: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@kms_color@pipe-c-legacy-gamma:
shard-kbl: FAIL (fdo#104782) -> PASS
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x128-dpms:
shard-apl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
shard-glk: FAIL (fdo#103167) -> PASS +6
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
shard-kbl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-apl: FAIL (fdo#103167) -> PASS +3
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: FAIL (fdo#103166) -> PASS +4
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +5
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-kbl: FAIL (fdo#103166) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
igt@perf_pmu@rc6-runtime-pm:
shard-apl: FAIL (fdo#105010) -> PASS
igt@perf_pmu@rc6-runtime-pm-long:
shard-kbl: FAIL (fdo#105010) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4673 -> IGTPW_1946
* Linux: CI_DRM_4958 -> CI_DRM_4973
CI_DRM_4958: 9990e1665029dc2ef4a9c0632b8a2f516263e595 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4973: 60ba18212b324d02e961232953f190612d7a6ca3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1946: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1946/
IGT_4673: 54cb1aeb4e50dea9f3abae632e317875d147c4ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1946/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns
2018-10-12 10:29 [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns Petri Latvala
2018-10-12 11:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-10-12 12:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-10-12 13:06 ` Daniel Vetter
2018-10-12 13:29 ` Martin Peres
2 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2018-10-12 13:06 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev, Martin Peres
On Fri, Oct 12, 2018 at 01:29:47PM +0300, Petri Latvala wrote:
> After setting the result object text, the string retrieved from the
> old object is invalid.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> runner/resultgen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index 9fc54cdc..ed8c9266 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -828,6 +828,7 @@ static void override_result_single(struct json_object *obj)
> if (!strcmp(result, "pass") &&
> count_lines(errtext, errtext + strlen(errtext)) > 2) {
> set_result(obj, "warn");
> + result = "warn";
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Do we have unit tests for the runner that are checked when you do make
check/ninja test?
Would be really nice to have that, since on the piglit side Dylan made
that happen. And if we have that already, we definitely want a unit test
for this stuff here.
-Daniel
> }
>
> if (dmesgwarns) {
> --
> 2.18.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns
2018-10-12 13:06 ` [igt-dev] [PATCH i-g-t 1/1] " Daniel Vetter
@ 2018-10-12 13:29 ` Martin Peres
0 siblings, 0 replies; 5+ messages in thread
From: Martin Peres @ 2018-10-12 13:29 UTC (permalink / raw)
To: Daniel Vetter, Petri Latvala; +Cc: igt-dev
On 12/10/2018 16:06, Daniel Vetter wrote:
> On Fri, Oct 12, 2018 at 01:29:47PM +0300, Petri Latvala wrote:
>> After setting the result object text, the string retrieved from the
>> old object is invalid.
>>
>> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
>> Cc: Martin Peres <martin.peres@linux.intel.com>
>> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>> ---
>> runner/resultgen.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/runner/resultgen.c b/runner/resultgen.c
>> index 9fc54cdc..ed8c9266 100644
>> --- a/runner/resultgen.c
>> +++ b/runner/resultgen.c
>> @@ -828,6 +828,7 @@ static void override_result_single(struct json_object *obj)
>> if (!strcmp(result, "pass") &&
>> count_lines(errtext, errtext + strlen(errtext)) > 2) {
>> set_result(obj, "warn");
>> + result = "warn";
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Do we have unit tests for the runner that are checked when you do make
> check/ninja test?
Yes, there are already tests that are executed by make check / ninja
test. Here they are:
https://cgit.freedesktop.org/drm/igt-gpu-tools/tree/runner/runner_tests.c
However, Petri said today he does not have tests for this particular
piece of code. More work needed I guess :)
>
> Would be really nice to have that, since on the piglit side Dylan made
> that happen. And if we have that already, we definitely want a unit test
> for this stuff here.
> -Daniel
>
>> }
>>
>> if (dmesgwarns) {
>> --
>> 2.18.0
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-12 13:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-12 10:29 [igt-dev] [PATCH i-g-t 1/1] runner: Fix results when there's warns and dmesg-warns Petri Latvala
2018-10-12 11:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-10-12 12:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-12 13:06 ` [igt-dev] [PATCH i-g-t 1/1] " Daniel Vetter
2018-10-12 13:29 ` Martin Peres
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox