From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
Date: Mon, 15 Oct 2018 16:57:46 +0300 [thread overview]
Message-ID: <20181015135746.GA9144@intel.com> (raw)
In-Reply-To: <20181015134338.9109-1-maarten.lankhorst@linux.intel.com>
On Mon, Oct 15, 2018 at 03:43:38PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> tests/kms_frontbuffer_tracking.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 9aecb815024f..bf4a68ff2bde 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -246,7 +246,7 @@ struct {
> .show_hidden= false,
> .step = 0,
> .only_pipes = PIPE_COUNT,
> - .shared_fb_x_offset = 500,
> + .shared_fb_x_offset = 248,
Can't see why 500 would be inherently better than 248. Although I have
to wonder why 248 instead of eg. 256. Magic numbers are just that.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> .shared_fb_y_offset = 500,
> .tiling = LOCAL_I915_FORMAT_MOD_X_TILED,
> };
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-15 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 13:43 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays Maarten Lankhorst
2018-10-15 13:57 ` Ville Syrjälä [this message]
2018-10-15 14:14 ` Maarten Lankhorst
2018-10-16 9:15 ` Maarten Lankhorst
2018-10-15 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-15 17:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015135746.GA9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox