* [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
@ 2018-10-15 13:43 Maarten Lankhorst
2018-10-15 13:57 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Maarten Lankhorst @ 2018-10-15 13:43 UTC (permalink / raw)
To: igt-dev
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
tests/kms_frontbuffer_tracking.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 9aecb815024f..bf4a68ff2bde 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -246,7 +246,7 @@ struct {
.show_hidden= false,
.step = 0,
.only_pipes = PIPE_COUNT,
- .shared_fb_x_offset = 500,
+ .shared_fb_x_offset = 248,
.shared_fb_y_offset = 500,
.tiling = LOCAL_I915_FORMAT_MOD_X_TILED,
};
--
2.19.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
2018-10-15 13:43 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays Maarten Lankhorst
@ 2018-10-15 13:57 ` Ville Syrjälä
2018-10-15 14:14 ` Maarten Lankhorst
2018-10-15 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-15 17:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2018-10-15 13:57 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
On Mon, Oct 15, 2018 at 03:43:38PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> tests/kms_frontbuffer_tracking.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 9aecb815024f..bf4a68ff2bde 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -246,7 +246,7 @@ struct {
> .show_hidden= false,
> .step = 0,
> .only_pipes = PIPE_COUNT,
> - .shared_fb_x_offset = 500,
> + .shared_fb_x_offset = 248,
Can't see why 500 would be inherently better than 248. Although I have
to wonder why 248 instead of eg. 256. Magic numbers are just that.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> .shared_fb_y_offset = 500,
> .tiling = LOCAL_I915_FORMAT_MOD_X_TILED,
> };
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
2018-10-15 13:57 ` Ville Syrjälä
@ 2018-10-15 14:14 ` Maarten Lankhorst
2018-10-16 9:15 ` Maarten Lankhorst
0 siblings, 1 reply; 6+ messages in thread
From: Maarten Lankhorst @ 2018-10-15 14:14 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
Op 15-10-18 om 15:57 schreef Ville Syrjälä:
> On Mon, Oct 15, 2018 at 03:43:38PM +0200, Maarten Lankhorst wrote:
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> tests/kms_frontbuffer_tracking.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
>> index 9aecb815024f..bf4a68ff2bde 100644
>> --- a/tests/kms_frontbuffer_tracking.c
>> +++ b/tests/kms_frontbuffer_tracking.c
>> @@ -246,7 +246,7 @@ struct {
>> .show_hidden= false,
>> .step = 0,
>> .only_pipes = PIPE_COUNT,
>> - .shared_fb_x_offset = 500,
>> + .shared_fb_x_offset = 248,
> Can't see why 500 would be inherently better than 248. Although I have
> to wonder why 248 instead of eg. 256. Magic numbers are just that.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
I'm fine with 256 too, just wanted to be evil and not make it a power of 2.
Just bump to 256 then? Either fits in 16384 bytes..
~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
2018-10-15 14:14 ` Maarten Lankhorst
@ 2018-10-16 9:15 ` Maarten Lankhorst
0 siblings, 0 replies; 6+ messages in thread
From: Maarten Lankhorst @ 2018-10-16 9:15 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
Op 15-10-18 om 16:14 schreef Maarten Lankhorst:
> Op 15-10-18 om 15:57 schreef Ville Syrjälä:
>> On Mon, Oct 15, 2018 at 03:43:38PM +0200, Maarten Lankhorst wrote:
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> ---
>>> tests/kms_frontbuffer_tracking.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
>>> index 9aecb815024f..bf4a68ff2bde 100644
>>> --- a/tests/kms_frontbuffer_tracking.c
>>> +++ b/tests/kms_frontbuffer_tracking.c
>>> @@ -246,7 +246,7 @@ struct {
>>> .show_hidden= false,
>>> .step = 0,
>>> .only_pipes = PIPE_COUNT,
>>> - .shared_fb_x_offset = 500,
>>> + .shared_fb_x_offset = 248,
>> Can't see why 500 would be inherently better than 248. Although I have
>> to wonder why 248 instead of eg. 256. Magic numbers are just that.
>>
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> I'm fine with 256 too, just wanted to be evil and not make it a power of 2.
> Just bump to 256 then? Either fits in 16384 bytes..
>
> ~Maarten
It's tiled, I guess either way stride will be 16384. So I pushed with 248 and an explanation in the commit message we round to 16384 anyway.
~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
2018-10-15 13:43 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays Maarten Lankhorst
2018-10-15 13:57 ` Ville Syrjälä
@ 2018-10-15 14:19 ` Patchwork
2018-10-15 17:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-15 14:19 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
URL : https://patchwork.freedesktop.org/series/51007/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4980 -> IGTPW_1953 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1953 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1953, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51007/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1953:
=== IGT changes ===
==== Warnings ====
igt@gem_render_tiled_blits@basic:
fi-icl-u2: SKIP -> PASS +2
== Known issues ==
Here are the changes found in IGTPW_1953 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@amdgpu/amd_basic@cs-compute:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#108094)
igt@amdgpu/amd_prime@amd-to-i915:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#107341)
igt@drv_selftest@live_hangcheck:
fi-kbl-7560u: PASS -> INCOMPLETE (fdo#108044)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
==== Possible fixes ====
igt@drv_selftest@live_evict:
fi-bsw-kefka: DMESG-WARN (fdo#107709) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107709 https://bugs.freedesktop.org/show_bug.cgi?id=107709
fdo#108044 https://bugs.freedesktop.org/show_bug.cgi?id=108044
fdo#108094 https://bugs.freedesktop.org/show_bug.cgi?id=108094
== Participating hosts (53 -> 48) ==
Additional (1): fi-kbl-8809g
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u
== Build changes ==
* IGT: IGT_4676 -> IGTPW_1953
CI_DRM_4980: 0ab590190a211799af40693064ceace077dbd082 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1953: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1953/
IGT_4676: 7e7e0c4ce267c40024012079c18168d47ae78eef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1953/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
2018-10-15 13:43 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays Maarten Lankhorst
2018-10-15 13:57 ` Ville Syrjälä
2018-10-15 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-15 17:37 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-15 17:37 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Do not skip on 4k displays.
URL : https://patchwork.freedesktop.org/series/51007/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4676_full -> IGTPW_1953_full =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51007/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1953_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ctx_isolation@vcs0-s3:
shard-apl: PASS -> FAIL (fdo#103375)
igt@gem_ctx_param@invalid-ctx-get:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-hsw: PASS -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-a-degamma:
shard-apl: PASS -> FAIL (fdo#108145, fdo#104782)
igt@kms_color@pipe-c-degamma:
shard-kbl: PASS -> FAIL (fdo#104782)
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_crc@cursor-128x42-random:
shard-glk: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#105454, fdo#106509)
igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538) +2
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
shard-apl: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
shard-glk: NOTRUN -> DMESG-FAIL (fdo#103167, fdo#106538)
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: PASS -> FAIL (fdo#103166) +2
igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166)
==== Possible fixes ====
igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
shard-kbl: FAIL (fdo#108145) -> PASS
igt@kms_color@pipe-b-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-256x256-random:
shard-glk: FAIL (fdo#103232) -> PASS +3
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-kbl: FAIL (fdo#103232, fdo#103191) -> PASS
shard-apl: FAIL (fdo#103232, fdo#103191) -> PASS
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS +6
igt@kms_cursor_crc@cursor-64x21-onscreen:
shard-kbl: FAIL (fdo#103232) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
shard-kbl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
shard-apl: FAIL (fdo#103167) -> PASS +2
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: FAIL (fdo#103167) -> PASS +9
igt@kms_frontbuffer_tracking@fbc-badstride:
shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS +1
igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
shard-glk: FAIL (fdo#108145) -> PASS +1
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +3
shard-apl: FAIL (fdo#103166) -> PASS +2
shard-kbl: FAIL (fdo#103166) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
igt@kms_vblank@pipe-a-wait-forked:
shard-glk: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@perf_pmu@rc6-runtime-pm-long:
shard-kbl: FAIL (fdo#105010) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4676 -> IGTPW_1953
* Linux: CI_DRM_4979 -> CI_DRM_4980
CI_DRM_4979: 2c411746783a4db33844f298ee88f0301cf0453e @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4980: 0ab590190a211799af40693064ceace077dbd082 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1953: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1953/
IGT_4676: 7e7e0c4ce267c40024012079c18168d47ae78eef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1953/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-16 9:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-15 13:43 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays Maarten Lankhorst
2018-10-15 13:57 ` Ville Syrjälä
2018-10-15 14:14 ` Maarten Lankhorst
2018-10-16 9:15 ` Maarten Lankhorst
2018-10-15 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-15 17:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox