From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests: Skip testdisplay when KMS is disabled
Date: Tue, 16 Oct 2018 08:54:01 -0700 [thread overview]
Message-ID: <20181016155401.GA3694@intel.com> (raw)
In-Reply-To: <717d23dbc93f2060b64a8ba00a45918ad8b6ecb8.camel@intel.com>
On Mon, Oct 15, 2018 at 09:52:25PM +0000, Souza, Jose wrote:
> On Sat, 2018-10-13 at 11:25 +0100, Chris Wilson wrote:
> > Quoting José Roberto de Souza (2018-10-12 22:28:27)
> > > This test should be skiped when KMS is disabled.
> > >
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > tests/testdisplay.c | 5 +----
> > > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > Testdisplay is really an oddball that doesn't belong amid the igt
> > suite
> > of tests/
> >
> > > diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> > > index b13c3d70..9972fb3c 100644
> > > --- a/tests/testdisplay.c
> > > +++ b/tests/testdisplay.c
> > > @@ -457,10 +457,7 @@ int update_display(bool probe)
> > > int c;
> > >
> > > resources = drmModeGetResources(drm_fd);
> > > - if (!resources) {
> > > - igt_warn("drmModeGetResources failed: %s\n",
> > > strerror(errno));
> > > - return 0;
> > > - }
> > > + igt_require(resources);
> >
> > Hmm, looks like there's a drmSetClientCap() that would fail earlier.
> > I
> > think ideally we would pass resources into the function.
> >
> > For now, this is a simple improvement
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Fwiw,
> > https://patchwork.freedesktop.org/patch/254962/
> > https://patchwork.freedesktop.org/patch/254961/
> > are the remaining issues for BAT + no display.
>
>
> Thanks. Could someone merge this 2?
> I'm waiting the GitLab migration to ask commit rights.
Done. Thanks for patch and reviews.
>
> > -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-16 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 21:28 [igt-dev] [PATCH i-g-t 1/2] lib: Skip tests that require fb modifiers when KMS is disabled José Roberto de Souza
2018-10-12 21:28 ` [igt-dev] [PATCH i-g-t 2/2] tests: Skip testdisplay " José Roberto de Souza
2018-10-13 10:25 ` Chris Wilson
2018-10-15 21:52 ` Souza, Jose
2018-10-16 15:54 ` Rodrigo Vivi [this message]
2018-10-12 21:58 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: Skip tests that require fb modifiers " Patchwork
2018-10-13 2:05 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-13 10:20 ` [igt-dev] [PATCH i-g-t 1/2] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016155401.GA3694@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox