[igt-dev] [PATCH i-g-t 1/2] lib: Skip tests that require fb modifiers when KMS is disabled

[igt-dev] [PATCH i-g-t 1/2] lib: Skip tests that require fb modifiers when KMS is disabled

[José Roberto de Souza]

When KMS is disabled, drmGetCap() for DRM_CAP_ADDFB2_MODIFIERS() will
return -1 and set errno as EOPNOTSUPP, the current assert was only
checking for a sucess result or invalid argument causing
prime_vgem@basic-fence-flip test to fail when KMS is disabled.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 lib/ioctl_wrappers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 0929c43f..bda9a764 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -1661,7 +1661,7 @@ void igt_require_fb_modifiers(int fd)
 		int ret;
 
 		ret = drmGetCap(fd, DRM_CAP_ADDFB2_MODIFIERS, &cap_modifiers);
-		igt_assert(ret == 0 || errno == EINVAL);
+		igt_assert(ret == 0 || errno == EINVAL || errno == EOPNOTSUPP);
 		has_modifiers = ret == 0 && cap_modifiers == 1;
 		cap_modifiers_tested = true;
 	}
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] tests: Skip testdisplay when KMS is disabled

[José Roberto de Souza]

This test should be skiped when KMS is disabled.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/testdisplay.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/testdisplay.c b/tests/testdisplay.c
index b13c3d70..9972fb3c 100644
--- a/tests/testdisplay.c
+++ b/tests/testdisplay.c
@@ -457,10 +457,7 @@ int update_display(bool probe)
 	int c;
 
 	resources = drmModeGetResources(drm_fd);
-	if (!resources) {
-		igt_warn("drmModeGetResources failed: %s\n", strerror(errno));
-		return 0;
-	}
+	igt_require(resources);
 
 	connectors = calloc(resources->count_connectors,
 			    sizeof(struct connector));
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: Skip tests that require fb modifiers when KMS is disabled

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: Skip tests that require fb modifiers when KMS is disabled
URL   : https://patchwork.freedesktop.org/series/50960/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4973 -> IGTPW_1950 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50960/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1950 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_evict:
      fi-bsw-kefka:       PASS -> DMESG-WARN (fdo#107709)

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362, fdo#103191)

    igt@pm_rpm@module-reload:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#107726)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107709 https://bugs.freedesktop.org/show_bug.cgi?id=107709
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726


== Participating hosts (43 -> 40) ==

  Additional (3): fi-skl-guc fi-icl-u fi-gdg-551 
  Missing    (6): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4673 -> IGTPW_1950

  CI_DRM_4973: 60ba18212b324d02e961232953f190612d7a6ca3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1950: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1950/
  IGT_4673: 54cb1aeb4e50dea9f3abae632e317875d147c4ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1950/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: Skip tests that require fb modifiers when KMS is disabled

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: Skip tests that require fb modifiers when KMS is disabled
URL   : https://patchwork.freedesktop.org/series/50960/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4673_full -> IGTPW_1950_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1950_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1950_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50960/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1950_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1950_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_await@wide-contexts:
      shard-glk:          PASS -> FAIL (fdo#106680)

    igt@gem_exec_store@basic-bsd2:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL (fdo#106641)

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-glk:          PASS -> FAIL (fdo#103232) +1

    igt@kms_cursor_crc@cursor-64x21-random:
      shard-apl:          PASS -> FAIL (fdo#103232)
      shard-kbl:          PASS -> FAIL (fdo#103232)
      shard-glk:          NOTRUN -> FAIL (fdo#103232)

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#106538, fdo#105763)

    igt@kms_flip@flip-vs-modeset-vs-hang-interruptible:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105602, fdo#103313, fdo#103558) +3

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-kbl:          PASS -> FAIL (fdo#103167)
      shard-apl:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
      shard-glk:          PASS -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-render:
      shard-apl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558) +15

    igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
      shard-kbl:          PASS -> FAIL (fdo#108145) +1
      shard-apl:          PASS -> FAIL (fdo#108145)

    igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
      shard-glk:          PASS -> FAIL (fdo#108145) +2

    igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
      shard-kbl:          NOTRUN -> FAIL (fdo#108146)

    igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
      shard-apl:          PASS -> FAIL (fdo#103166) +1

    igt@pm_rpm@reg-read-ioctl:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558) +32

    
    ==== Possible fixes ====

    igt@gem_exec_basic@readonly-bsd:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@gem_mmap@bad-object:
      shard-apl:          DMESG-WARN (fdo#105602, fdo#103558) -> PASS

    igt@kms_addfb_basic@bo-too-small-due-to-tiling:
      shard-snb:          DMESG-WARN (fdo#107469) -> PASS +4

    igt@kms_chv_cursor_fail@pipe-c-128x128-right-edge:
      shard-glk:          INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    igt@kms_color@pipe-c-legacy-gamma:
      shard-kbl:          FAIL (fdo#104782) -> PASS
      shard-apl:          FAIL (fdo#104782) -> PASS

    igt@kms_cursor_crc@cursor-128x128-dpms:
      shard-apl:          FAIL (fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          DMESG-WARN (fdo#106538, fdo#105763) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
      shard-apl:          FAIL (fdo#103167) -> PASS +3

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          FAIL (fdo#103167) -> PASS +6

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-glk:          FAIL (fdo#103166) -> PASS +3

    igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
      shard-glk:          FAIL (fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-apl:          FAIL (fdo#103166) -> PASS +4

    igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
      shard-kbl:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@perf_pmu@rc6-runtime-pm:
      shard-apl:          FAIL (fdo#105010) -> PASS

    igt@perf_pmu@rc6-runtime-pm-long:
      shard-kbl:          FAIL (fdo#105010) -> PASS

    
    ==== Warnings ====

    igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
      shard-apl:          FAIL (fdo#108145) -> DMESG-FAIL (fdo#105602, fdo#108145, fdo#103558) +1

    igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
      shard-kbl:          FAIL (fdo#108145) -> DMESG-FAIL (fdo#105602, fdo#103313, fdo#108145, fdo#103558)

    igt@kms_sysfs_edid_timing:
      shard-apl:          FAIL (fdo#100047) -> DMESG-FAIL (fdo#105602, fdo#100047, fdo#103558)

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
  fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
  fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (6 -> 5) ==

  Missing    (1): shard-skl 


== Build changes ==

    * IGT: IGT_4673 -> IGTPW_1950
    * Linux: CI_DRM_4958 -> CI_DRM_4973

  CI_DRM_4958: 9990e1665029dc2ef4a9c0632b8a2f516263e595 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4973: 60ba18212b324d02e961232953f190612d7a6ca3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1950: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1950/
  IGT_4673: 54cb1aeb4e50dea9f3abae632e317875d147c4ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1950/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib: Skip tests that require fb modifiers when KMS is disabled

[Chris Wilson]

Quoting José Roberto de Souza (2018-10-12 22:28:26)
> When KMS is disabled, drmGetCap() for DRM_CAP_ADDFB2_MODIFIERS() will
> return -1 and set errno as EOPNOTSUPP, the current assert was only
> checking for a sucess result or invalid argument causing
> prime_vgem@basic-fence-flip test to fail when KMS is disabled.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  lib/ioctl_wrappers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 0929c43f..bda9a764 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -1661,7 +1661,7 @@ void igt_require_fb_modifiers(int fd)
>                 int ret;
>  
>                 ret = drmGetCap(fd, DRM_CAP_ADDFB2_MODIFIERS, &cap_modifiers);
> -               igt_assert(ret == 0 || errno == EINVAL);
> +               igt_assert(ret == 0 || errno == EINVAL || errno == EOPNOTSUPP);

I just think this is a dumb assert, but that's just me. I suggested we
remove it since it is not essential for answering the question of
whether we have the *cap* and that is *all* that is being asked here,
but something has to be done.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests: Skip testdisplay when KMS is disabled

[Chris Wilson]

Quoting José Roberto de Souza (2018-10-12 22:28:27)
> This test should be skiped when KMS is disabled.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  tests/testdisplay.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Testdisplay is really an oddball that doesn't belong amid the igt suite
of tests/

> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index b13c3d70..9972fb3c 100644
> --- a/tests/testdisplay.c
> +++ b/tests/testdisplay.c
> @@ -457,10 +457,7 @@ int update_display(bool probe)
>         int c;
>  
>         resources = drmModeGetResources(drm_fd);
> -       if (!resources) {
> -               igt_warn("drmModeGetResources failed: %s\n", strerror(errno));
> -               return 0;
> -       }
> +       igt_require(resources);

Hmm, looks like there's a drmSetClientCap() that would fail earlier. I
think ideally we would pass resources into the function.

For now, this is a simple improvement
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Fwiw,
https://patchwork.freedesktop.org/patch/254962/
https://patchwork.freedesktop.org/patch/254961/
are the remaining issues for BAT + no display.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests: Skip testdisplay when KMS is disabled

[Souza, Jose]

On Sat, 2018-10-13 at 11:25 +0100, Chris Wilson wrote:
> Quoting José Roberto de Souza (2018-10-12 22:28:27)
> > This test should be skiped when KMS is disabled.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  tests/testdisplay.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Testdisplay is really an oddball that doesn't belong amid the igt
> suite
> of tests/
> 
> > diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> > index b13c3d70..9972fb3c 100644
> > --- a/tests/testdisplay.c
> > +++ b/tests/testdisplay.c
> > @@ -457,10 +457,7 @@ int update_display(bool probe)
> >         int c;
> >  
> >         resources = drmModeGetResources(drm_fd);
> > -       if (!resources) {
> > -               igt_warn("drmModeGetResources failed: %s\n",
> > strerror(errno));
> > -               return 0;
> > -       }
> > +       igt_require(resources);
> 
> Hmm, looks like there's a drmSetClientCap() that would fail earlier.
> I
> think ideally we would pass resources into the function.
> 
> For now, this is a simple improvement
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Fwiw,
> https://patchwork.freedesktop.org/patch/254962/
> https://patchwork.freedesktop.org/patch/254961/
> are the remaining issues for BAT + no display.


Thanks. Could someone merge this 2?
I'm waiting the GitLab migration to ask commit rights.

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests: Skip testdisplay when KMS is disabled

[Rodrigo Vivi]

On Mon, Oct 15, 2018 at 09:52:25PM +0000, Souza, Jose wrote:
> On Sat, 2018-10-13 at 11:25 +0100, Chris Wilson wrote:
> > Quoting José Roberto de Souza (2018-10-12 22:28:27)
> > > This test should be skiped when KMS is disabled.
> > > 
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > >  tests/testdisplay.c | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > Testdisplay is really an oddball that doesn't belong amid the igt
> > suite
> > of tests/
> > 
> > > diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> > > index b13c3d70..9972fb3c 100644
> > > --- a/tests/testdisplay.c
> > > +++ b/tests/testdisplay.c
> > > @@ -457,10 +457,7 @@ int update_display(bool probe)
> > >         int c;
> > >  
> > >         resources = drmModeGetResources(drm_fd);
> > > -       if (!resources) {
> > > -               igt_warn("drmModeGetResources failed: %s\n",
> > > strerror(errno));
> > > -               return 0;
> > > -       }
> > > +       igt_require(resources);
> > 
> > Hmm, looks like there's a drmSetClientCap() that would fail earlier.
> > I
> > think ideally we would pass resources into the function.
> > 
> > For now, this is a simple improvement
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Fwiw,
> > https://patchwork.freedesktop.org/patch/254962/
> > https://patchwork.freedesktop.org/patch/254961/
> > are the remaining issues for BAT + no display.
> 
> 
> Thanks. Could someone merge this 2?
> I'm waiting the GitLab migration to ask commit rights.

Done. Thanks for patch and reviews.

> 
> > -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev