[igt-dev] [PATCH i-g-t 1/4] tests/kms_3d: Unset all crtcs before the test

[igt-dev] [PATCH i-g-t 1/4] tests/kms_3d: Unset all crtcs before the test

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

On pre-HSW we have separate encoders for the DP and HDMI ports,
but both can't be enabled at the same time. The test fails to
account for that and can thus fail when the kernel rejects
the modeset. We can avoid that by turning off all the ports
beforehand.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_3d.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index df8185abebc4..5aeb5dd11e6b 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -57,6 +57,8 @@ igt_simple_main
 	}
 	igt_require(connector);
 
+	kmstest_unset_all_crtcs(drm_fd, res);
+
 	kmstest_edid_add_3d(igt_kms_get_base_edid(), EDID_LENGTH, &edid,
 			    &length);
 
-- 
2.18.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/4] tests/kms_hdmi_inject: Unset all crtcs before the test

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

On pre-HSW we have separate encoders for the DP and HDMI ports,
but both can't be enabled at the same time. The test fails to
account for that and can thus fail when the kernel rejects
the modeset. We can avoid that by turning off all the ports
beforehand.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_hdmi_inject.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
index 699bad5b73e2..d26200006850 100644
--- a/tests/kms_hdmi_inject.c
+++ b/tests/kms_hdmi_inject.c
@@ -260,6 +260,8 @@ igt_main
 
 		connector = get_connector(drm_fd, res);
 		igt_require(connector);
+
+		kmstest_unset_all_crtcs(drm_fd, res);
 	}
 
 	igt_subtest("inject-4k")
-- 
2.18.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/4] tests/kms_3d: Accept any HDMI connector

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Connector forcing works just fine even if it already has
something physically connected. So accept any HDMI connector
for the test.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_3d.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index 5aeb5dd11e6b..949c4c8acbf6 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -47,8 +47,7 @@ igt_simple_main
 
 		connector = drmModeGetConnectorCurrent(drm_fd, res->connectors[i]);
 
-		if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA &&
-		    connector->connection == DRM_MODE_DISCONNECTED)
+		if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA)
 			break;
 
 		drmModeFreeConnector(connector);
-- 
2.18.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 4/4] tests/kms_hdmi_inject: Accept any HDMI connector

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Connector forcing works just fine even if it already has
something physically connected. So accept any HDMI connector
for the test.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_hdmi_inject.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
index d26200006850..caf63064d899 100644
--- a/tests/kms_hdmi_inject.c
+++ b/tests/kms_hdmi_inject.c
@@ -41,8 +41,7 @@ get_connector(int drm_fd, drmModeRes *res)
 		connector =
 			drmModeGetConnectorCurrent(drm_fd, res->connectors[i]);
 
-		if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA &&
-		    connector->connection == DRM_MODE_DISCONNECTED)
+		if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA)
 			break;
 
 		drmModeFreeConnector(connector);
-- 
2.18.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] tests/kms_3d: Unset all crtcs before the test

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/4] tests/kms_3d: Unset all crtcs before the test
URL   : https://patchwork.freedesktop.org/series/52181/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4712 -> IGTPW_2045 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_2045 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2045, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/52181/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2045:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_contexts:
      fi-kbl-7560u:       PASS -> INCOMPLETE

    igt@drv_selftest@live_hangcheck:
      fi-skl-6700k2:      PASS -> INCOMPLETE

    
    ==== Warnings ====

    igt@prime_vgem@basic-fence-flip:
      fi-ivb-3520m:       SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_2045 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-cfl-8109u:       PASS -> DMESG-WARN (fdo#107345) +3
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)
      fi-icl-u:           PASS -> INCOMPLETE (fdo#107713)

    
    ==== Possible fixes ====

    igt@gem_ctx_create@basic-files:
      fi-icl-u2:          DMESG-WARN (fdo#107724) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    
    ==== Warnings ====

    igt@drv_selftest@live_contexts:
      fi-icl-u2:          DMESG-FAIL (fdo#108569) -> INCOMPLETE (fdo#108315)

    
  fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
  fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
  fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569


== Participating hosts (52 -> 47) ==

  Additional (1): fi-cnl-u 
  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4712 -> IGTPW_2045

  CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2045: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2045/
  IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2045/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 1/4] tests/kms_3d: Unset all crtcs before the test

[Arkadiusz Hiler]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

On pre-HSW we have separate encoders for the DP and HDMI ports,
but both can't be enabled at the same time. The test fails to
account for that and can thus fail when the kernel rejects
the modeset. We can avoid that by turning off all the ports
beforehand.

v2: rebased (Arek)

Cc: Simon Ser <simon.ser@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/kms_3d.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index 8ade6d34..aed3bee3 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -56,6 +56,8 @@ igt_simple_main
 	}
 	igt_require(connector);
 
+	kmstest_unset_all_crtcs(drm_fd, res);
+
 	edid = igt_kms_get_3d_edid();
 
 	kmstest_force_edid(drm_fd, connector, edid);
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/4] tests/kms_3d: Unset all crtcs before the test

[Arkadiusz Hiler]

On Thu, Jul 25, 2019 at 03:35:43PM +0300, Arkadiusz Hiler wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> On pre-HSW we have separate encoders for the DP and HDMI ports,
> but both can't be enabled at the same time. The test fails to
> account for that and can thus fail when the kernel rejects
> the modeset. We can avoid that by turning off all the ports
> beforehand.
> 
> v2: rebased (Arek)


Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105594

> Cc: Simon Ser <simon.ser@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev