From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/1] tests/pm_rpm: Assert that we get connector data
Date: Thu, 8 Nov 2018 12:33:15 +0200 [thread overview]
Message-ID: <20181108103315.20378-1-petri.latvala@intel.com> (raw)
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5088/fi-byt-clapper/igt@pm_rpm@module-reload.html
shows the test crashing in get_connector_edid. Directly there, not in
any libdrm function. The only way I see that can happen is if
drmModeGetConnectorCurrent() returned NULL.
TODO: Change commit message from random guessing to an explanation of
an actual cause.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108675
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
tests/pm_rpm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 7488efd7..547e08aa 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -396,6 +396,7 @@ static void init_mode_set_data(struct mode_set_data *data)
for (int i = 0; i < data->res->count_connectors; i++) {
data->connectors[i] = drmModeGetConnectorCurrent(drm_fd,
data->res->connectors[i]);
+ igt_assert(data->connectors[i]);
data->edids[i] = get_connector_edid(data->connectors[i], i);
}
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2018-11-08 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 10:33 Petri Latvala [this message]
2018-11-08 11:15 ` [igt-dev] [PATCH i-g-t 1/1] tests/pm_rpm: Assert that we get connector data Chris Wilson
2018-11-08 11:22 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108103315.20378-1-petri.latvala@intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox