[igt-dev] [PATCH i-g-t 1/1] tests/pm_rpm: Assert that we get connector data

[igt-dev] [PATCH i-g-t 1/1] tests/pm_rpm: Assert that we get connector data

[Petri Latvala]

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5088/fi-byt-clapper/igt@pm_rpm@module-reload.html
shows the test crashing in get_connector_edid. Directly there, not in
any libdrm function. The only way I see that can happen is if
drmModeGetConnectorCurrent() returned NULL.

TODO: Change commit message from random guessing to an explanation of
an actual cause.

References: https://bugs.freedesktop.org/show_bug.cgi?id=108675
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 tests/pm_rpm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 7488efd7..547e08aa 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -396,6 +396,7 @@ static void init_mode_set_data(struct mode_set_data *data)
 		for (int i = 0; i < data->res->count_connectors; i++) {
 			data->connectors[i] = drmModeGetConnectorCurrent(drm_fd,
 									 data->res->connectors[i]);
+			igt_assert(data->connectors[i]);
 			data->edids[i] = get_connector_edid(data->connectors[i], i);
 		}
 
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/1] tests/pm_rpm: Assert that we get connector data

[Chris Wilson]

Quoting Petri Latvala (2018-11-08 10:33:15)
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5088/fi-byt-clapper/igt@pm_rpm@module-reload.html
> shows the test crashing in get_connector_edid. Directly there, not in
> any libdrm function. The only way I see that can happen is if
> drmModeGetConnectorCurrent() returned NULL.
> 
> TODO: Change commit message from random guessing to an explanation of
> an actual cause.

Also you have to include an exciting to fix pun.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] tests/pm_rpm: Assert that we get connector data

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/1] tests/pm_rpm: Assert that we get connector data
URL   : https://patchwork.freedesktop.org/series/52217/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4712 -> IGTPW_2046 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_2046 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2046, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/52217/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2046:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@module-reload:
      fi-kbl-7567u:       PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@kms_busy@basic-flip-a:
      fi-kbl-7567u:       PASS -> SKIP +36

    
== Known issues ==

  Here are the changes found in IGTPW_2046 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload-inject:
      fi-kbl-7567u:       PASS -> DMESG-WARN (fdo#105602) +2

    igt@gem_exec_suspend@basic-s3:
      fi-kbl-7567u:       PASS -> DMESG-WARN (fdo#105602, fdo#105079)
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-icl-u:           PASS -> INCOMPLETE (fdo#107713)

    
    ==== Possible fixes ====

    igt@kms_chamelium@common-hpd-after-suspend:
      fi-skl-6700k2:      FAIL (fdo#103841) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (52 -> 47) ==

  Additional (1): fi-cnl-u 
  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4712 -> IGTPW_2046

  CI_DRM_5097: c20dfc4f015dfd41246beb7d72338aa50543a5ef @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2046: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2046/
  IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2046/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev