public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: IGT development <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] gitlab-CI: Force a UTF-8 local
Date: Fri, 7 Dec 2018 19:28:16 +0200	[thread overview]
Message-ID: <20181207172816.GA9144@intel.com> (raw)
In-Reply-To: <20181206182714.31393-1-daniel.vetter@ffwll.ch>

On Thu, Dec 06, 2018 at 07:27:14PM +0100, Daniel Vetter wrote:
> python is brittle otherwise and loves to just blow up. Especially
> when you have commits with non-ASCII characters, which gitlab CI
> injects into the docker env.
> 
> Strangely we've only seen this go boom on the ninja test target
> in the arm64 cross-compile. For paranoia roll it out everywhere.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  .gitlab-ci.yml | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index efd01be0ea07..5c457ab0431b 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -22,6 +22,7 @@ stages:
>  build:tests-fedora:
>    stage: build
>    script:
> +    - export LANG=C.UTF-8

LC_ALL?

>      - meson $MESON_OPTIONS build
>      - ninja -C build
>      - ninja -C build igt-gpu-tools-doc
> @@ -33,6 +34,7 @@ build:tests-fedora-no-libunwind:
>    stage: build
>    script:
>      - dnf remove -y libunwind-devel
> +    - export LANG=C.UTF-8
>      - meson -Dlibunwind=false build
>      - ninja -C build
>  
> @@ -41,6 +43,7 @@ build:tests-fedora-oldest-meson:
>    stage: build
>    script:
>      - dnf remove -y meson
> +    - export LANG=C.UTF-8
>      - pip3 install /usr/src/meson-*.tar.gz
>      - meson $MESON_OPTIONS build
>      - ninja -C build
> @@ -50,6 +53,7 @@ build:tests-debian-meson:
>    image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
>    stage: build
>    script:
> +    - export LANG=C.UTF-8
>      - meson $MESON_OPTIONS build
>      - ninja -C build
>      - cp build/tests/test-list.txt meson-test-list.txt
> @@ -62,6 +66,7 @@ build:tests-debian-meson-arm64:
>    stage: build
>    script:
>      - export PKG_CONFIG_PATH=/usr/lib/aarch64-linux-gnu/pkgconfig/
> +    - export LANG=C.UTF-8
>      - meson --cross-file meson-cross-arm64.txt build
>      - ninja -C build
>    artifacts:
> @@ -85,7 +90,9 @@ test:ninja-test:
>    dependencies:
>      - build:tests-fedora
>    stage: test
> -  script: ninja -C build test
> +  script:
> +    - export LANG=C.UTF-8
> +    - ninja -C build test
>  
>  test:ninja-test-arm64:
>    image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-arm64:latest
> @@ -94,6 +101,7 @@ test:ninja-test-arm64:
>    stage: test
>    script:
>      - export PKG_CONFIG_PATH=/usr/lib/aarch64-linux-gnu/pkgconfig/
> +    - export LANG=C.UTF-8
>      - env > build/envdump.txt
>      - locale
>      - locale -a
> @@ -117,6 +125,7 @@ pages:
>      - build:tests-fedora
>    stage: deploy
>    script:
> +    - export LANG=C.UTF-8
>      - ninja -C build igt-gpu-tools-doc
>      - cp -r build/docs/reference/igt-gpu-tools/html public
>    artifacts:
> -- 
> 2.20.0.rc1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-12-07 17:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 18:27 [igt-dev] [PATCH i-g-t] gitlab-CI: Force a UTF-8 local Daniel Vetter
2018-12-06 18:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-07 10:50 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2018-12-07 14:00 ` Daniel Vetter
2018-12-11 14:45   ` Jani Nikula
2018-12-07 15:12 ` [igt-dev] ✓ Fi.CI.BAT: success for gitlab-CI: Force a UTF-8 local (rev2) Patchwork
2018-12-07 17:28 ` Ville Syrjälä [this message]
2018-12-10  9:45   ` [igt-dev] [PATCH i-g-t] gitlab-CI: Force a UTF-8 local Daniel Vetter
2018-12-10 16:02     ` Ville Syrjälä
2018-12-07 22:11 ` [igt-dev] ✓ Fi.CI.IGT: success for gitlab-CI: Force a UTF-8 local (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207172816.GA9144@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox