From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: IGT development <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] gitlab-CI: Force a UTF-8 local
Date: Mon, 10 Dec 2018 18:02:41 +0200 [thread overview]
Message-ID: <20181210160241.GF9144@intel.com> (raw)
In-Reply-To: <20181210094536.GL21184@phenom.ffwll.local>
On Mon, Dec 10, 2018 at 10:45:36AM +0100, Daniel Vetter wrote:
> On Fri, Dec 07, 2018 at 07:28:16PM +0200, Ville Syrjälä wrote:
> > On Thu, Dec 06, 2018 at 07:27:14PM +0100, Daniel Vetter wrote:
> > > python is brittle otherwise and loves to just blow up. Especially
> > > when you have commits with non-ASCII characters, which gitlab CI
> > > injects into the docker env.
> > >
> > > Strangely we've only seen this go boom on the ninja test target
> > > in the arm64 cross-compile. For paranoia roll it out everywhere.
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > ---
> > > .gitlab-ci.yml | 11 ++++++++++-
> > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index efd01be0ea07..5c457ab0431b 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -22,6 +22,7 @@ stages:
> > > build:tests-fedora:
> > > stage: build
> > > script:
> > > + - export LANG=C.UTF-8
> >
> > LC_ALL?
>
> Implied by setting LANG. I checked by looking at the output of locale. I
> honestly have no idea what should be done.
I think LANG only provides the default for the all the LC_ env
variables if you haven't set anything at all, whereas LC_ALL
overrides all of them even if they're set.
unset LC_MESSAGES
unset LANG
unset LC_ALL
LANG=foo locale -> foo
LANG=foo LC_MESSAGES=bar locale -> bar
LANG=foo LC_MESSAGES=bar LC_ALL=hah -> hah
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-10 16:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 18:27 [igt-dev] [PATCH i-g-t] gitlab-CI: Force a UTF-8 local Daniel Vetter
2018-12-06 18:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-07 10:50 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2018-12-07 14:00 ` Daniel Vetter
2018-12-11 14:45 ` Jani Nikula
2018-12-07 15:12 ` [igt-dev] ✓ Fi.CI.BAT: success for gitlab-CI: Force a UTF-8 local (rev2) Patchwork
2018-12-07 17:28 ` [igt-dev] [PATCH i-g-t] gitlab-CI: Force a UTF-8 local Ville Syrjälä
2018-12-10 9:45 ` Daniel Vetter
2018-12-10 16:02 ` Ville Syrjälä [this message]
2018-12-07 22:11 ` [igt-dev] ✓ Fi.CI.IGT: success for gitlab-CI: Force a UTF-8 local (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210160241.GF9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox