From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
Date: Thu, 13 Dec 2018 10:52:34 +0100 [thread overview]
Message-ID: <20181213095234.5251-1-maarten.lankhorst@linux.intel.com> (raw)
Typically PSR enables in around 136 ms, but on some tests the we have
to explicitly make sure that the gpu is idle before rendering.
Otherwise, sometimes we wait for the background flusher to finish,
which will take at least a second longer, and causes the wait for
PSR to timeout.
On kms_frontbuffer_tracking:
Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 350ms
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 1598ms
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/kms_frontbuffer_tracking.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 276ef83ce386..7924bb902a2a 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1642,6 +1642,9 @@ static void __do_assertions(const struct test_mode *t, int flags,
{
flags = adjust_assertion_flags(t, flags);
+ /* Make sure any submitted rendering is now idle. */
+ gem_quiescent_gpu(drm.fd);
+
igt_debug("checking asserts in line %i\n", line);
wait_user(2, "Paused before assertions.");
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2018-12-13 9:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 9:52 Maarten Lankhorst [this message]
2018-12-13 10:00 ` [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Daniel Vetter
2018-12-13 10:05 ` Chris Wilson
2018-12-14 0:18 ` Dhinakaran Pandiyan
2018-12-14 0:22 ` Dhinakaran Pandiyan
2018-12-14 9:31 ` Maarten Lankhorst
2018-12-13 10:20 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-13 11:44 ` Patchwork
2018-12-13 11:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-12-13 12:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-13 12:49 ` Chris Wilson
2018-12-13 13:39 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213095234.5251-1-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox