public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] igt/amdgpu_amd_prime: Bail if we fail to create more contexts
Date: Thu, 13 Dec 2018 11:57:03 +0000	[thread overview]
Message-ID: <20181213115703.24192-1-chris@chris-wilson.co.uk> (raw)

amdgpu has started to report out of space after creating a few contexts.
This is not the scope of this test as here we just verifying that fences
created in amd can be imported and used for synchronisation by i915 and
for that we just need at least one context created!

References: https://bugs.freedesktop.org/show_bug.cgi?id=109049
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/amdgpu/amd_prime.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
index bda0ce83d..518c88963 100644
--- a/tests/amdgpu/amd_prime.c
+++ b/tests/amdgpu/amd_prime.c
@@ -354,8 +354,8 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 			contexts = realloc(contexts, size * sizeof(*contexts));
 		}
 
-		r = amdgpu_cs_ctx_create(device, &contexts[count]);
-		igt_assert_eq(r, 0);
+		if (amdgpu_cs_ctx_create(device, &contexts[count]))
+			break;
 
 		r = amdgpu_cs_submit(contexts[count], 0, &ibs_request, 1);
 		igt_assert_eq(r, 0);
@@ -364,6 +364,7 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 	}
 
 	igt_info("Reservation width = %ld\n", count);
+	igt_require(count);
 
 	amdgpu_bo_export(ib_result_handle,
 			 amdgpu_bo_handle_type_dma_buf_fd,
-- 
2.20.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2018-12-13 11:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 11:57 Chris Wilson [this message]
2018-12-13 12:31 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/amdgpu_amd_prime: Bail if we fail to create more contexts Patchwork
2018-12-13 14:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-13 15:28 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
2018-12-13 15:36   ` Chris Wilson
2018-12-13 15:45     ` Chris Wilson
2018-12-13 15:41 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213115703.24192-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox