Re: [igt-dev] [PATCH i-g-t] igt/amdgpu_amd_prime: Bail if we fail to create more contexts

[Antonio Argenziano <antonio.argenziano@intel.com>]

On 13/12/18 03:57, Chris Wilson wrote:
> amdgpu has started to report out of space after creating a few contexts.
> This is not the scope of this test as here we just verifying that fences
> created in amd can be imported and used for synchronisation by i915 and
> for that we just need at least one context created!
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109049
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

LGTM.

Reviwed-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   tests/amdgpu/amd_prime.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
> index bda0ce83d..518c88963 100644
> --- a/tests/amdgpu/amd_prime.c
> +++ b/tests/amdgpu/amd_prime.c
> @@ -354,8 +354,8 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)

doesn't i915_to_amd have the same issue?

Antonio

>   			contexts = realloc(contexts, size * sizeof(*contexts));
>   		}
>   
> -		r = amdgpu_cs_ctx_create(device, &contexts[count]);
> -		igt_assert_eq(r, 0);
> +		if (amdgpu_cs_ctx_create(device, &contexts[count]))
> +			break;
>   
>   		r = amdgpu_cs_submit(contexts[count], 0, &ibs_request, 1);
>   		igt_assert_eq(r, 0);
> @@ -364,6 +364,7 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
>   	}
>   
>   	igt_info("Reservation width = %ld\n", count);
> +	igt_require(count);
>   
>   	amdgpu_bo_export(ib_result_handle,
>   			 amdgpu_bo_handle_type_dma_buf_fd,
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev