From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [igt-dev] [PATCH i-g-t 7/8] tests/fbcon_fbt: Add and use psr_long_wait_exit() to test updates in PSR
Date: Mon, 7 Jan 2019 11:10:55 -0800 [thread overview]
Message-ID: <20190107191056.22759-7-jose.souza@intel.com> (raw)
In-Reply-To: <20190107191056.22759-1-jose.souza@intel.com>
After getting back to fbcon it tests if PSR had a update but since
fbcon can take a while it have some big sleep in place, so what it
is actualy testing is if fbcon is updating the screen.
In this test the update of the screen comes from the fbcon cursor
blinking, the problem is that 40ms is a small interval to detect
cursor blinking and the test can fail some times, so a bigger timeout
to wait for exit is need.
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
lib/igt_psr.c | 5 +++++
lib/igt_psr.h | 1 +
tests/kms_fbcon_fbt.c | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index 82012e6d..28e7e99c 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -47,6 +47,11 @@ bool psr_wait_exit(int debugfs_fd)
return igt_wait(psr_active(debugfs_fd, false), 40, 10);
}
+bool psr_long_wait_exit(int debugfs_fd)
+{
+ return igt_wait(psr_active(debugfs_fd, false), 500, 10);
+}
+
static ssize_t psr_write(int debugfs_fd, const char *buf)
{
return igt_sysfs_write(debugfs_fd, "i915_edp_psr_debug", buf,
diff --git a/lib/igt_psr.h b/lib/igt_psr.h
index d3336c2d..d52a7e08 100644
--- a/lib/igt_psr.h
+++ b/lib/igt_psr.h
@@ -32,6 +32,7 @@
bool psr_wait_entry(int debugfs_fd);
bool psr_wait_exit(int debugfs_fd);
+bool psr_long_wait_exit(int debugfs_fd);
bool psr_enable(int debugfs_fd);
bool psr_disable(int debugfs_fd);
bool psr_sink_support(int debugfs_fd);
diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index 3e218dc8..cdba1c6e 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -198,7 +198,7 @@ static bool psr_wait_until_enabled(int debugfs_fd)
static bool psr_wait_until_update(int debugfs_fd)
{
- return psr_wait_exit(debugfs_fd);
+ return psr_long_wait_exit(debugfs_fd);
}
static void disable_features(int debugfs_fd)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-07 19:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 19:10 [igt-dev] [PATCH i-g-t 1/8] lib/psr: Add a macro with the maximum lenght of i915_edp_psr_status and use it José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 2/8] lib/psr: Share the code check if sink supports PSR José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 3/8] tests/fbcon_fbt: Use psr_wait_entry() to wait PSR be enabled José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 4/8] tests/fbcon_fbt: Allow fbcon to bind when running this test José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 5/8] tests/fbcon_fbt: Add wait_until_update() callback to features José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 6/8] tests/fbcon_fbt: Use psr_wait_exit() to test updates in PSR José Roberto de Souza
2019-01-07 19:10 ` José Roberto de Souza [this message]
2019-01-07 20:41 ` [igt-dev] [PATCH i-g-t 7/8] tests/fbcon_fbt: Add and use psr_long_wait_exit() " Chris Wilson
2019-01-08 14:01 ` Souza, Jose
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 8/8] tests/fbcon_fbt: Do not print debugfs of features José Roberto de Souza
2019-01-07 20:44 ` Chris Wilson
2019-01-07 19:52 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] lib/psr: Add a macro with the maximum lenght of i915_edp_psr_status and use it Patchwork
2019-01-07 20:38 ` [igt-dev] [PATCH i-g-t 1/8] " Chris Wilson
2019-01-08 13:52 ` Souza, Jose
2019-01-07 22:52 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/8] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107191056.22759-7-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox