From: "Souza, Jose" <jose.souza@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 7/8] tests/fbcon_fbt: Add and use psr_long_wait_exit() to test updates in PSR
Date: Tue, 8 Jan 2019 14:01:26 +0000 [thread overview]
Message-ID: <90c1a2af15d5eeaf5f052eca439e600df27fdffb.camel@intel.com> (raw)
In-Reply-To: <154689371427.27300.17200738894983499973@skylake-alporthouse-com>
[-- Attachment #1.1: Type: text/plain, Size: 1045 bytes --]
On Mon, 2019-01-07 at 20:41 +0000, Chris Wilson wrote:
> Quoting José Roberto de Souza (2019-01-07 19:10:55)
> > After getting back to fbcon it tests if PSR had a update but since
> > fbcon can take a while it have some big sleep in place, so what it
> > is actualy testing is if fbcon is updating the screen.
> > In this test the update of the screen comes from the fbcon cursor
> > blinking, the problem is that 40ms is a small interval to detect
> > cursor blinking and the test can fail some times, so a bigger
> > timeout
> > to wait for exit is need.
>
> So what happens if you disable the cursor blink?
It would fail, I can add a patch on top saving the previous state of
/sys/class/graphics/fbcon/cursor_blink enabling it and then restoring.
> Do you actually need to
> open the fbdev and draw something to ensure the path you want
> exercised
> is?
Paulo was the one that wrote the test he can answer better but I guess
he wanted to test if fbcon would show up after draw to fbdev and
teardown.
> -Chris
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-08 14:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 19:10 [igt-dev] [PATCH i-g-t 1/8] lib/psr: Add a macro with the maximum lenght of i915_edp_psr_status and use it José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 2/8] lib/psr: Share the code check if sink supports PSR José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 3/8] tests/fbcon_fbt: Use psr_wait_entry() to wait PSR be enabled José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 4/8] tests/fbcon_fbt: Allow fbcon to bind when running this test José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 5/8] tests/fbcon_fbt: Add wait_until_update() callback to features José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 6/8] tests/fbcon_fbt: Use psr_wait_exit() to test updates in PSR José Roberto de Souza
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 7/8] tests/fbcon_fbt: Add and use psr_long_wait_exit() " José Roberto de Souza
2019-01-07 20:41 ` Chris Wilson
2019-01-08 14:01 ` Souza, Jose [this message]
2019-01-07 19:10 ` [igt-dev] [PATCH i-g-t 8/8] tests/fbcon_fbt: Do not print debugfs of features José Roberto de Souza
2019-01-07 20:44 ` Chris Wilson
2019-01-07 19:52 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] lib/psr: Add a macro with the maximum lenght of i915_edp_psr_status and use it Patchwork
2019-01-07 20:38 ` [igt-dev] [PATCH i-g-t 1/8] " Chris Wilson
2019-01-08 13:52 ` Souza, Jose
2019-01-07 22:52 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/8] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90c1a2af15d5eeaf5f052eca439e600df27fdffb.camel@intel.com \
--to=jose.souza@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox