public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Deepak Rawat <drawat@vmware.com>
To: thellstrom@vmware.com, igt-dev@lists.freedesktop.org
Cc: Deepak Rawat <drawat@vmware.com>, linux-graphics-maintainer@vmware.com
Subject: [igt-dev] [PATCH i-g-t 3/3] igt/kms_addfb_basic: Add missing calls to gem_close
Date: Tue, 15 Jan 2019 16:22:30 -0800	[thread overview]
Message-ID: <20190116002230.2545-4-drawat@vmware.com> (raw)
In-Reply-To: <20190116002230.2545-1-drawat@vmware.com>

Few gem_close calls were missing add them.

Signed-off-by: Deepak Rawat <drawat@vmware.com>
---
 tests/kms_addfb_basic.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 9c4c2c4d..dd948ca8 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -372,9 +372,11 @@ static void tiling_tests(int fd)
 			if (is_dumb) {
 				kmstest_dumb_destroy(fd, tiled_x_bo);
 				kmstest_dumb_destroy(fd, tiled_y_bo);
+				kmstest_dumb_destroy(fd, gem_bo);
 			} else {
 				gem_close(fd, tiled_x_bo);
 				gem_close(fd, tiled_y_bo);
+				gem_close(fd, gem_bo);
 			}
 		}
 	}
@@ -651,6 +653,7 @@ static void prop_tests(int fd)
 	struct drm_mode_obj_get_properties get_props = {};
 	struct drm_mode_obj_set_property set_prop = {};
 	uint64_t prop, prop_val;
+	bool is_dumb = false;
 
 	f.width = 1024;
 	f.height = 1024;
@@ -659,7 +662,7 @@ static void prop_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, &is_dumb);
 		igt_assert(gem_bo);
 
 		f.handles[0] = gem_bo;
@@ -704,8 +707,14 @@ static void prop_tests(int fd)
 				    &set_prop) == -1 && errno == EINVAL);
 	}
 
-	igt_fixture
+	igt_fixture {
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
+		if (is_dumb) {
+			kmstest_dumb_destroy(fd, gem_bo);
+		} else {
+			gem_close(fd, gem_bo);
+		}
+	}
 
 }
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-01-16  0:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16  0:22 [igt-dev] [PATCH i-g-t 0/3] Fixes to kms_addfb_basic + RFC IGT buf alloc Deepak Rawat
2019-01-16  0:22 ` [igt-dev] [PATCH i-g-t 1/3] igt/kms_addfb_basic: Call dumb destroy in case have dumb buffer Deepak Rawat
2019-01-16  0:22 ` [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling Deepak Rawat
2019-01-16  8:42   ` Chris Wilson
2019-01-16 16:11     ` Deepak Singh Rawat
2019-01-16 16:17       ` Chris Wilson
2019-01-16 16:34         ` Deepak Singh Rawat
2019-01-16 16:44           ` Chris Wilson
2019-01-16 16:53             ` Deepak Singh Rawat
2019-01-16  0:22 ` Deepak Rawat [this message]
2019-01-16  4:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes to kms_addfb_basic + RFC IGT buf alloc Patchwork
2019-01-16  6:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190116002230.2545-4-drawat@vmware.com \
    --to=drawat@vmware.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox