From: Deepak Singh Rawat <drawat@vmware.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
Thomas Hellstrom <thellstrom@vmware.com>
Cc: Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling
Date: Wed, 16 Jan 2019 08:53:39 -0800 [thread overview]
Message-ID: <77dde6a256254a5e154e4cd72d3d31c902318b2f.camel@vmware.com> (raw)
In-Reply-To: <154765705852.22625.17782170270847006148@skylake-alporthouse-com>
On Wed, 2019-01-16 at 16:44 +0000, Chris Wilson wrote:
> It's not just testing a backend tiling format, but also the
> corresponding I915_FORMAT_MOD. It won't generalise more than a
> starting
> point for testing other backend specific DRM_FORMAT_MODIFIERS.
>
> That addfb_expected_ret() is bogus. A different backend may reuse the
> same value as I915_FORMAT_MOD_Y_TILED for a completely different
> purpose, that ends up being valid for the given addfb.
>
> My reading is addfb25_tests(); addfb25_ytile(); tiling_tests(); are
> all
> i915-specific and should be placed in an i915 subtest group. And that
> we
> should try to extract the (one?) generic addfb25 tests.
> -Chris
Thanks for the explanation. I agree.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-16 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 0:22 [igt-dev] [PATCH i-g-t 0/3] Fixes to kms_addfb_basic + RFC IGT buf alloc Deepak Rawat
2019-01-16 0:22 ` [igt-dev] [PATCH i-g-t 1/3] igt/kms_addfb_basic: Call dumb destroy in case have dumb buffer Deepak Rawat
2019-01-16 0:22 ` [igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling Deepak Rawat
2019-01-16 8:42 ` Chris Wilson
2019-01-16 16:11 ` Deepak Singh Rawat
2019-01-16 16:17 ` Chris Wilson
2019-01-16 16:34 ` Deepak Singh Rawat
2019-01-16 16:44 ` Chris Wilson
2019-01-16 16:53 ` Deepak Singh Rawat [this message]
2019-01-16 0:22 ` [igt-dev] [PATCH i-g-t 3/3] igt/kms_addfb_basic: Add missing calls to gem_close Deepak Rawat
2019-01-16 4:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes to kms_addfb_basic + RFC IGT buf alloc Patchwork
2019-01-16 6:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77dde6a256254a5e154e4cd72d3d31c902318b2f.camel@vmware.com \
--to=drawat@vmware.com \
--cc=Linux-graphics-maintainer@vmware.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox