public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
	eben@raspberrypi.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [igt-dev] [PATCH i-g-t v3 02/14] igt: fb: Reduce tile size alignment for non intel platforms
Date: Tue, 22 Jan 2019 14:42:45 +0100	[thread overview]
Message-ID: <20190122134257.14038-3-maxime.ripard@bootlin.com> (raw)
In-Reply-To: <20190122134257.14038-1-maxime.ripard@bootlin.com>

Aligning the width on 64 pixels only make sense on intel platforms, make
sure to add a check against this.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 lib/igt_fb.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index e23908e28c07..1a5c338ea532 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -204,7 +204,11 @@ void igt_get_fb_tile_size(int fd, uint64_t tiling, int fb_bpp,
 {
 	switch (tiling) {
 	case LOCAL_DRM_FORMAT_MOD_NONE:
-		*width_ret = 64;
+		if (is_i915_device(fd))
+			*width_ret = 64;
+		else
+			*width_ret = 1;
+
 		*height_ret = 1;
 		break;
 	case LOCAL_I915_FORMAT_MOD_X_TILED:
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-01-22 13:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 13:42 [igt-dev] [PATCH i-g-t v3 00/14] igt: chamelium: Test YUV buffers using the Chamelium Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 01/14] igt: fb: Add subsampling parameters to the formats Maxime Ripard
2019-01-22 13:42 ` Maxime Ripard [this message]
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 03/14] igt: fb: generic YUV convertion function Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 04/14] igt: fb: Move i915 YUV buffer clearing code to a function Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 05/14] igt: fb: Move size computation to the common path Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 06/14] igt: fb: Refactor dumb buffer allocation path Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 07/14] igt: fb: Account for all planes bpp Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 08/14] igt: fb: Don't pass the stride when allocating a dumb, multi-planar buffer Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 09/14] igt: fb: Clear YUV dumb buffers Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 10/14] igt: fb: Rework YUV i915 allocation path Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 11/14] igt: fb: Add a bunch of new YUV formats Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 12/14] igt: tests: chamelium: Start to unify tests Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 13/14] igt: tests: chamelium: Convert VGA tests to do_test_display Maxime Ripard
2019-01-22 13:42 ` [igt-dev] [PATCH i-g-t v3 14/14] igt: tests: chamelium: Add YUV formats tests Maxime Ripard
2019-01-22 14:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for igt: chamelium: Test YUV buffers using the Chamelium (rev5) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122134257.14038-3-maxime.ripard@bootlin.com \
    --to=maxime.ripard@bootlin.com \
    --cc=eben@raspberrypi.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox