public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH 1/2] tests/kms_cursor_crc.c: Improve test_cursor_alpha()
@ 2019-01-24  5:40 Mamta Shukla
  2019-01-24  5:57 ` [igt-dev] [PATCH i-g-t, 2/2] tests/kms_cursor_crc.c: Remove framebuffer at the end of the test Mamta Shukla
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Mamta Shukla @ 2019-01-24  5:40 UTC (permalink / raw)
  To: igt-dev; +Cc: hamohammed.sa, daniel

Changes in test_cursor_alpha() to fix CRC mismatch error
[1] Set cursor plane in HW test using drmModeSetCursor()
[2] Remove igt_display_commit()
[3] Add igt_remove_fb() after disabling the cursor plane in HW test.

This function is aligned with test_cursor_size.
With the above changes,got passing results for alpha blending support
added in VKMS CRC API.

Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
---
 tests/kms_cursor_crc.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 3c9856d9..c1ea7faf 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -413,24 +413,26 @@ static void test_cursor_alpha(data_t *data, double a)
 	uint32_t fb_id;
 	int curw=data->curw;
 	int curh=data->curh;
+	int ret;
 
 	/*alpha cursor fb*/
-	fb_id = igt_create_color_fb(data->drm_fd, curw, curh,
+	fb_id = igt_create_fb(data->drm_fd, curw, curh,
 				    DRM_FORMAT_ARGB8888,
 				    LOCAL_DRM_FORMAT_MOD_NONE,
-				    1.0, 1.0, 1.0,
 				    &data->fb);
 	igt_assert(fb_id);
 	cr = igt_get_cairo_ctx(data->drm_fd, &data->fb);
-	draw_cursor(cr, 0, 0, curw, curh, a);
+	igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a);
 	igt_put_cairo_ctx(data->drm_fd, &data->fb, cr);
 
 	/*Hardware Test*/
 	cursor_enable(data);
-	igt_display_commit(display);
+	ret=drmModeSetCursor(data->drm_fd, data->output->config.crtc->crtc_id, data->fb.gem_handle, curw, curh);
+	igt_assert_eq(ret, 0);
 	igt_wait_for_vblank(data->drm_fd, data->pipe);
 	igt_pipe_crc_collect_crc(pipe_crc, &crc);
 	cursor_disable(data);
+	igt_remove_fb(data->drm_fd, &data->fb);
 
 	/*Software Test*/
 	cr = igt_get_cairo_ctx(data->drm_fd, &data->primary_fb);
@@ -447,7 +449,6 @@ static void test_cursor_alpha(data_t *data, double a)
 	igt_paint_color(cr, 0, 0, data->screenw, data->screenh,
 			0.0, 0.0, 0.0);
 	igt_put_cairo_ctx(data->drm_fd, &data->primary_fb, cr);
-	igt_remove_fb(data->drm_fd, &data->fb);
 }
 
 static void test_cursor_transparent(data_t *data)
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-24 21:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24  5:40 [igt-dev] [PATCH 1/2] tests/kms_cursor_crc.c: Improve test_cursor_alpha() Mamta Shukla
2019-01-24  5:57 ` [igt-dev] [PATCH i-g-t, 2/2] tests/kms_cursor_crc.c: Remove framebuffer at the end of the test Mamta Shukla
2019-01-24  6:34 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/2] tests/kms_cursor_crc.c: Improve test_cursor_alpha() Patchwork
2019-01-24  7:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-24 21:10 ` [igt-dev] [PATCH i-g-t, 1/2] " Rodrigo Siqueira

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox