* [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Check the strlen() for an empty file
@ 2019-01-29 11:24 Chris Wilson
2019-01-29 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-01-29 11:24 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
igt_sysfs_get() only returns NULL if the open() fails, and a valid
string otherwise. So if the read() fails with ENODEV (because sysfs
doesn't provide the driver with an ->open() callback), we return an
empty string, and "No error captured" otherwise.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109481
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_capture.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
index eca73ab11..56837dfca 100644
--- a/tests/i915/gem_exec_capture.c
+++ b/tests/i915/gem_exec_capture.c
@@ -519,6 +519,11 @@ static bool has_capture(int fd)
return async > 0;
}
+static size_t safer_strlen(const char *s)
+{
+ return s ? strlen(s) : 0;
+}
+
igt_main
{
const struct intel_execution_engine *e;
@@ -544,7 +549,7 @@ igt_main
dir = igt_sysfs_open(fd, NULL);
igt_require(igt_sysfs_set(dir, "error", "Begone!"));
- igt_require(igt_sysfs_get(dir, "error"));
+ igt_require(safer_strlen(igt_sysfs_get(dir, "error")) > 0);
}
for (e = intel_execution_engines; e->name; e++) {
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_capture: Check the strlen() for an empty file
2019-01-29 11:24 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Check the strlen() for an empty file Chris Wilson
@ 2019-01-29 11:56 ` Patchwork
2019-01-29 15:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-29 23:38 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Antonio Argenziano
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-29 11:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_capture: Check the strlen() for an empty file
URL : https://patchwork.freedesktop.org/series/55899/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5500 -> IGTPW_2314
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55899/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2314 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: PASS -> FAIL [fdo#104008]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: {SKIP} [fdo#109271] / [fdo#109278] -> PASS +2
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (46 -> 40)
------------------------------
Additional (1): fi-icl-y
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-6700hq
Build changes
-------------
* IGT: IGT_4798 -> IGTPW_2314
CI_DRM_5500: a76602bc7e9c1661ac1328103ef67dbc342a7655 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2314: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2314/
IGT_4798: 998e0a4aedf10fb5f7c271018cd80d874668bf55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2314/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_capture: Check the strlen() for an empty file
2019-01-29 11:24 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Check the strlen() for an empty file Chris Wilson
2019-01-29 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-29 15:17 ` Patchwork
2019-01-29 23:38 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Antonio Argenziano
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-29 15:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_capture: Check the strlen() for an empty file
URL : https://patchwork.freedesktop.org/series/55899/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5500_full -> IGTPW_2314_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55899/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2314_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_pwrite@big-gtt-backwards:
- shard-snb: PASS -> INCOMPLETE [fdo#105411] +1
* igt@i915_suspend@sysfs-reader:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_busy@basic-modeset-b:
- shard-snb: NOTRUN -> FAIL [fdo#109490]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956] +2
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_color@pipe-a-ctm-max:
- shard-kbl: PASS -> FAIL [fdo#108147]
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-a-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-glk: PASS -> FAIL [fdo#103184]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +5
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@perf_pmu@rc6-runtime-pm:
- shard-glk: PASS -> FAIL [fdo#105010]
- shard-apl: PASS -> FAIL [fdo#105010]
- shard-kbl: PASS -> FAIL [fdo#105010]
#### Possible fixes ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-kbl: FAIL [fdo#106641] -> PASS
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +3
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: FAIL [fdo#103232] -> PASS +5
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: FAIL [fdo#103232] -> PASS +6
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +1
- shard-apl: FAIL [fdo#103166] -> PASS
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-glk: FAIL [fdo#105010] -> PASS
- shard-kbl: FAIL [fdo#105010] -> PASS
* igt@prime_busy@hang-blt:
- shard-snb: FAIL [fdo#108807] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108807]: https://bugs.freedesktop.org/show_bug.cgi?id=108807
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109490]: https://bugs.freedesktop.org/show_bug.cgi?id=109490
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4798 -> IGTPW_2314
* Piglit: piglit_4509 -> None
CI_DRM_5500: a76602bc7e9c1661ac1328103ef67dbc342a7655 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2314: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2314/
IGT_4798: 998e0a4aedf10fb5f7c271018cd80d874668bf55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2314/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_exec_capture: Check the strlen() for an empty file
2019-01-29 11:24 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Check the strlen() for an empty file Chris Wilson
2019-01-29 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-29 15:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-01-29 23:38 ` Antonio Argenziano
2 siblings, 0 replies; 4+ messages in thread
From: Antonio Argenziano @ 2019-01-29 23:38 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 29/01/19 03:24, Chris Wilson wrote:
> igt_sysfs_get() only returns NULL if the open() fails, and a valid
> string otherwise. So if the read() fails with ENODEV (because sysfs
> doesn't provide the driver with an ->open() callback), we return an
> empty string, and "No error captured" otherwise.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109481
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
LGTM.
Reviwed-by: Antonio Argenziano <antonio.argenziano@intel.com>
> ---
> tests/i915/gem_exec_capture.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
> index eca73ab11..56837dfca 100644
> --- a/tests/i915/gem_exec_capture.c
> +++ b/tests/i915/gem_exec_capture.c
> @@ -519,6 +519,11 @@ static bool has_capture(int fd)
> return async > 0;
> }
>
> +static size_t safer_strlen(const char *s)
> +{
> + return s ? strlen(s) : 0;
> +}
> +
> igt_main
> {
> const struct intel_execution_engine *e;
> @@ -544,7 +549,7 @@ igt_main
>
> dir = igt_sysfs_open(fd, NULL);
> igt_require(igt_sysfs_set(dir, "error", "Begone!"));
> - igt_require(igt_sysfs_get(dir, "error"));
> + igt_require(safer_strlen(igt_sysfs_get(dir, "error")) > 0);
> }
>
> for (e = intel_execution_engines; e->name; e++) {
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-29 23:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-29 11:24 [igt-dev] [PATCH i-g-t] i915/gem_exec_capture: Check the strlen() for an empty file Chris Wilson
2019-01-29 11:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-29 15:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-29 23:38 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Antonio Argenziano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox