public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_fbcon_fbt: Do a full connector probe.
Date: Mon,  4 Feb 2019 12:55:56 -0800	[thread overview]
Message-ID: <20190204205556.32512-1-dhinakaran.pandiyan@intel.com> (raw)

kms_fbtcon_fbt appears to fail when it is the first test that is executed
after module load.
'Test requirement not met in function set_mode_for_one_screen, file
../tests/kms_fbcon_fbt.c:153:
Test requirement: i < drm->res->count_connectors'
The problem seems to be that the 1920x1080 bios fb is re-used and that
prunes the 4k mode before test execution. Later, when the test does not
do a full-probe, the eDP connector does not have any valid modes.

<7>[   12.444411] [drm:drm_mode_debug_printmodeline] Modeline
191:"3840x2160" 60 533250 3840 3888 3920 4000 2160 2163 2168 2222 0x48
0xa
<7>[   12.444418] [drm:drm_mode_prune_invalid] Not using 3840x2160 mode:
VIRTUAL_X

Fix this by calling drmModeGetConnector() instead
drmModeGetConnectorCurrent()

Note that that test is still expected to fail as PSR status checks are
broken.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109518
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 tests/kms_fbcon_fbt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index 9d0d5a36..40465a1c 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -67,7 +67,7 @@ static void setup_drm(struct drm_info *drm)
 	igt_assert(drm->res->count_connectors <= MAX_CONNECTORS);
 
 	for (i = 0; i < drm->res->count_connectors; i++)
-		drm->connectors[i] = drmModeGetConnectorCurrent(drm->fd,
+		drm->connectors[i] = drmModeGetConnector(drm->fd,
 						drm->res->connectors[i]);
 
 	kmstest_set_vt_graphics_mode();
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-02-05  3:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 20:55 Dhinakaran Pandiyan [this message]
2019-02-05  4:22 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Do a full connector probe Patchwork
2019-02-05  5:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-05 18:45 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
2019-02-06  3:29   ` Dhinakaran Pandiyan
2019-04-26  6:53     ` Daniel Vetter
2019-02-28 18:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Do a full connector probe. (rev2) Patchwork
2019-02-28 22:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-06  0:20 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_fbcon_fbt: Do a full connector probe. (rev3) Patchwork
2019-04-07  0:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204205556.32512-1-dhinakaran.pandiyan@intel.com \
    --to=dhinakaran.pandiyan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox