* [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
@ 2019-02-07 8:08 Katarzyna Dec
2019-02-07 8:11 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Katarzyna Dec @ 2019-02-07 8:08 UTC (permalink / raw)
To: igt-dev
When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE
to 1M which is not reflected in test_close() loop.
Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
---
tests/i915/gem_mmap_wc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
index 110883eb..bff0fa2a 100644
--- a/tests/i915/gem_mmap_wc.c
+++ b/tests/i915/gem_mmap_wc.c
@@ -285,7 +285,7 @@ test_close(int fd)
memset(ptr, 0xcc, OBJECT_SIZE);
gem_close(fd, handle);
- for (i = 0; i < 4096; i++)
+ for (i = 0; i < OBJECT_SIZE/4096; i++)
igt_assert(ptr[i*4096+i] == 0xcc);
munmap(ptr, OBJECT_SIZE);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
2019-02-07 8:08 [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE Katarzyna Dec
@ 2019-02-07 8:11 ` Chris Wilson
2019-02-07 8:34 ` Katarzyna Dec
2019-02-07 8:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-07 10:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-02-07 8:11 UTC (permalink / raw)
To: Katarzyna Dec, igt-dev
Quoting Katarzyna Dec (2019-02-07 08:08:04)
> When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE
> to 1M which is not reflected in test_close() loop.
Why would you bother running this test on simulation? It's just a test
of the kernel reference counting.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
2019-02-07 8:11 ` Chris Wilson
@ 2019-02-07 8:34 ` Katarzyna Dec
2019-02-07 8:41 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Katarzyna Dec @ 2019-02-07 8:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Thu, Feb 07, 2019 at 08:11:28AM +0000, Chris Wilson wrote:
> Quoting Katarzyna Dec (2019-02-07 08:08:04)
> > When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE
> > to 1M which is not reflected in test_close() loop.
>
> Why would you bother running this test on simulation? It's just a test
> of the kernel reference counting.
> -Chris
So why do we have different object size for simulation in this test when we
should not bother?
Btw - I am fixing a bug in your code.
I wanted to talk to you on irc, but something is not working for me....
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
2019-02-07 8:34 ` Katarzyna Dec
@ 2019-02-07 8:41 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-02-07 8:41 UTC (permalink / raw)
To: Katarzyna Dec; +Cc: igt-dev
Quoting Katarzyna Dec (2019-02-07 08:34:44)
> On Thu, Feb 07, 2019 at 08:11:28AM +0000, Chris Wilson wrote:
> > Quoting Katarzyna Dec (2019-02-07 08:08:04)
> > > When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE
> > > to 1M which is not reflected in test_close() loop.
> >
> > Why would you bother running this test on simulation? It's just a test
> > of the kernel reference counting.
> > -Chris
> So why do we have different object size for simulation in this test when we
> should not bother?
No idea. All hw interaction should be covered by selftests (this
certainly is), the raison d'etre for igt is to cover user observable
behaviour. For the simulator, we should just be able to use seftests
followed by bare uABI checks before moving onto real workloads.
> Btw - I am fixing a bug in your code.
Nope, that is nothing to do with me. Someone else thought is was a good
idea. I do not like having tests vary, make different tests.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
2019-02-07 8:08 [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE Katarzyna Dec
2019-02-07 8:11 ` Chris Wilson
@ 2019-02-07 8:41 ` Patchwork
2019-02-07 10:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-02-07 8:41 UTC (permalink / raw)
To: Katarzyna Dec; +Cc: igt-dev
== Series Details ==
Series: tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
URL : https://patchwork.freedesktop.org/series/56329/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5557 -> IGTPW_2349
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56329/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2349 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
Participating hosts (47 -> 44)
------------------------------
Additional (3): fi-skl-guc fi-skl-6770hq fi-hsw-peppy
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4812 -> IGTPW_2349
CI_DRM_5557: 72302b1c5245655423f75a857aec82f037991b6f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2349: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2349/
IGT_4812: 592b854fead32c2b0dac7198edfb9a6bffd66932 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2349/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
2019-02-07 8:08 [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE Katarzyna Dec
2019-02-07 8:11 ` Chris Wilson
2019-02-07 8:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-02-07 10:30 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-02-07 10:30 UTC (permalink / raw)
To: Katarzyna Dec; +Cc: igt-dev
== Series Details ==
Series: tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE
URL : https://patchwork.freedesktop.org/series/56329/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5557_full -> IGTPW_2349_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56329/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2349_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_params@secure-non-root:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_exec_schedule@pi-ringfull-bsd2:
- shard-kbl: NOTRUN -> FAIL [fdo#103158] +2
* igt@gem_mmap_gtt@hang:
- shard-kbl: NOTRUN -> FAIL [fdo#109469]
* igt@gem_partial_pwrite_pread@writes-after-reads-snoop:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@i915_suspend@sysfs-reader:
- shard-snb: PASS -> FAIL [fdo#103375]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
- shard-glk: PASS -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956] +3
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-hang-newfb-render-a:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> FAIL [fdo#108597] +1
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +2
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-glk: PASS -> FAIL [fdo#100368]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +3
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590] +2
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] +4
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: NOTRUN -> INCOMPLETE [fdo#103665]
#### Possible fixes ####
* igt@gem_exec_blt@cold-min:
- shard-glk: DMESG-WARN [fdo#105763] / [fdo#106538] -> PASS
* igt@i915_selftest@live_hangcheck:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS +1
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +3
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: FAIL [fdo#103232] -> PASS +3
* igt@kms_flip@basic-plain-flip:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
- shard-snb: {SKIP} [fdo#109271] -> PASS +5
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +3
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-glk: DMESG-WARN [fdo#109244] -> INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109469]: https://bugs.freedesktop.org/show_bug.cgi?id=109469
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4812 -> IGTPW_2349
* Piglit: piglit_4509 -> None
CI_DRM_5557: 72302b1c5245655423f75a857aec82f037991b6f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2349: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2349/
IGT_4812: 592b854fead32c2b0dac7198edfb9a6bffd66932 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2349/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-07 10:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-07 8:08 [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE Katarzyna Dec
2019-02-07 8:11 ` Chris Wilson
2019-02-07 8:34 ` Katarzyna Dec
2019-02-07 8:41 ` Chris Wilson
2019-02-07 8:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-07 10:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox